| Message ID | 1586191361-16598-4-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ov5645: Deprecate usage of the clock-frequency | expand |
Hi Prabhakar, Thank you for the patch. On Mon, Apr 06, 2020 at 05:42:39PM +0100, Lad Prabhakar wrote: > PLL's on platforms might not be so accurate enough to generate the > required clock frequency, so instead of erroring out on xvlck frequency > mismatch just warn the user and continue ahead in probe. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/i2c/ov5645.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c > index 52848fff8a08..314760349adf 100644 > --- a/drivers/media/i2c/ov5645.c > +++ b/drivers/media/i2c/ov5645.c > @@ -1103,11 +1103,8 @@ static int ov5645_probe(struct i2c_client *client) > } > /* external clock must be 24MHz, allow 1% tolerance */ > xclk_freq = clk_get_rate(ov5645->xclk); > - if (xclk_freq < 23760000 || xclk_freq > 24240000) { > - dev_err(dev, "external clock frequency %u is not supported\n", > - xclk_freq); > - return -EINVAL; > - } > + if (xclk_freq < 23760000 || xclk_freq > 24240000) > + dev_warn(dev, "xvclk mismatched, modes are based on 24MHz\n"); > > for (i = 0; i < OV5645_NUM_SUPPLIES; i++) > ov5645->supplies[i].supply = ov5645_supply_name[i];
Hi Prabhakar, On Mon, Apr 6, 2020 at 6:43 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > PLL's on platforms might not be so accurate enough to generate the > required clock frequency, so instead of erroring out on xvlck frequency xvclk? (but see below) > mismatch just warn the user and continue ahead in probe. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Like for 2/5, what about the xvclk naming? > --- a/drivers/media/i2c/ov5645.c > +++ b/drivers/media/i2c/ov5645.c > @@ -1103,11 +1103,8 @@ static int ov5645_probe(struct i2c_client *client) > } > /* external clock must be 24MHz, allow 1% tolerance */ > xclk_freq = clk_get_rate(ov5645->xclk); > - if (xclk_freq < 23760000 || xclk_freq > 24240000) { > - dev_err(dev, "external clock frequency %u is not supported\n", > - xclk_freq); > - return -EINVAL; > - } > + if (xclk_freq < 23760000 || xclk_freq > 24240000) > + dev_warn(dev, "xvclk mismatched, modes are based on 24MHz\n"); Calling it "xvclk" here will confuse the user, as the clock is named "xclk" in DT? Gr{oetje,eeting}s, Geert
Hi Geert, Thank you for the review. On Tue, Apr 7, 2020 at 8:19 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Mon, Apr 6, 2020 at 6:43 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > PLL's on platforms might not be so accurate enough to generate the > > required clock frequency, so instead of erroring out on xvlck frequency > > xvclk? (but see below) > > > mismatch just warn the user and continue ahead in probe. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Like for 2/5, what about the xvclk naming? > > > --- a/drivers/media/i2c/ov5645.c > > +++ b/drivers/media/i2c/ov5645.c > > @@ -1103,11 +1103,8 @@ static int ov5645_probe(struct i2c_client *client) > > } > > /* external clock must be 24MHz, allow 1% tolerance */ > > xclk_freq = clk_get_rate(ov5645->xclk); > > - if (xclk_freq < 23760000 || xclk_freq > 24240000) { > > - dev_err(dev, "external clock frequency %u is not supported\n", > > - xclk_freq); > > - return -EINVAL; > > - } > > + if (xclk_freq < 23760000 || xclk_freq > 24240000) > > + dev_warn(dev, "xvclk mismatched, modes are based on 24MHz\n"); > > Calling it "xvclk" here will confuse the user, as the clock is named > "xclk" in DT? > Agreed Ill replace it with xclk in the warning. Cheers, --Prabhakar > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c index 52848fff8a08..314760349adf 100644 --- a/drivers/media/i2c/ov5645.c +++ b/drivers/media/i2c/ov5645.c @@ -1103,11 +1103,8 @@ static int ov5645_probe(struct i2c_client *client) } /* external clock must be 24MHz, allow 1% tolerance */ xclk_freq = clk_get_rate(ov5645->xclk); - if (xclk_freq < 23760000 || xclk_freq > 24240000) { - dev_err(dev, "external clock frequency %u is not supported\n", - xclk_freq); - return -EINVAL; - } + if (xclk_freq < 23760000 || xclk_freq > 24240000) + dev_warn(dev, "xvclk mismatched, modes are based on 24MHz\n"); for (i = 0; i < OV5645_NUM_SUPPLIES; i++) ov5645->supplies[i].supply = ov5645_supply_name[i];
PLL's on platforms might not be so accurate enough to generate the required clock frequency, so instead of erroring out on xvlck frequency mismatch just warn the user and continue ahead in probe. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- drivers/media/i2c/ov5645.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)