diff mbox series

docs/devicetree: mailbox: fix trivial typo

Message ID 1589139491-6301-1-git-send-email-l4stpr0gr4m@gmail.com (mailing list archive)
State Mainlined
Commit 35b9c0fdb9f666628ecda02b1fc44306933a2d97
Headers show
Series docs/devicetree: mailbox: fix trivial typo | expand

Commit Message

Kangmin Park May 10, 2020, 7:38 p.m. UTC
From: Kangmin Park <l4stpr0gr4m@gmail.com>

Fix node id typo in example

Signed-off-by: Kangmin Park <l4stpr0gr4m@gmail.com>
---
 Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michal Simek May 11, 2020, 7 a.m. UTC | #1
On 10. 05. 20 21:38, l4stpr0gr4m@gmail.com wrote:
> From: Kangmin Park <l4stpr0gr4m@gmail.com>
> 
> Fix node id typo in example

I think it is more than typo. It is incorrect unit-address which doesn't
match the first address specified in the reg property of the node.

Here is line from dt binding spec.
"The unit-address must match the first address specified in the
reg property of the node."



> 
> Signed-off-by: Kangmin Park <l4stpr0gr4m@gmail.com>

IIRC subject should start with dt-bindings:


> ---
>  Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
> index 4438432..ad76edc 100644
> --- a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
> +++ b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
> @@ -87,7 +87,7 @@ Example:
>  		ranges;
>  
>  		/* APU<->RPU0 IPI mailbox controller */
> -		ipi_mailbox_rpu0: mailbox@ff90400 {
> +		ipi_mailbox_rpu0: mailbox@ff990400 {
>  			reg = <0xff990400 0x20>,
>  			      <0xff990420 0x20>,
>  			      <0xff990080 0x20>,
> 

Change is correct.

With nits above applied please add my
Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
index 4438432..ad76edc 100644
--- a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
+++ b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
@@ -87,7 +87,7 @@  Example:
 		ranges;
 
 		/* APU<->RPU0 IPI mailbox controller */
-		ipi_mailbox_rpu0: mailbox@ff90400 {
+		ipi_mailbox_rpu0: mailbox@ff990400 {
 			reg = <0xff990400 0x20>,
 			      <0xff990420 0x20>,
 			      <0xff990080 0x20>,