| Message ID | 1591437017-5295-1-git-send-email-yangtiezhu@loongson.cn (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 3d21f0b4126650a92f2df531a5f3a2d27aa9a09f |
| Headers | show |
| Series | [1/3] irqchip/ti-sci-inta: Remove dead code in ti_sci_inta_set_type() | expand |
On 06/06/2020 12:50, Tiezhu Yang wrote: > In the function ti_sci_inta_set_type(), the statement "return -EINVAL;" > out of switch case is dead code, remove it. > Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver") Right? > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> > --- > drivers/irqchip/irq-ti-sci-inta.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c > index 7e3ebf6..c20c9f7 100644 > --- a/drivers/irqchip/irq-ti-sci-inta.c > +++ b/drivers/irqchip/irq-ti-sci-inta.c > @@ -433,8 +433,6 @@ static int ti_sci_inta_set_type(struct irq_data *data, unsigned int type) > default: > return -EINVAL; > } > - > - return -EINVAL; > } > > static struct irq_chip ti_sci_inta_irq_chip = { > For all 3 patches: Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> And you might need re-send it with --cover-letter
On Sat, 6 Jun 2020 17:50:15 +0800, Tiezhu Yang wrote: > In the function ti_sci_inta_set_type(), the statement "return -EINVAL;" > out of switch case is dead code, remove it. Applied to irq/irqchip-5.9: [1/3] irqchip/ti-sci-inta: Remove dead code in ti_sci_inta_set_type() commit: 3d21f0b4126650a92f2df531a5f3a2d27aa9a09f [2/3] irqchip/ti-sci-inta: Fix return value about devm_ioremap_resource() commit: 4b127a14cb1385dd355c7673d975258d5d668922 [3/3] irqchip/ti-sci-inta: Fix typo about MODULE_AUTHOR commit: ef6b0bf43be5c17790a14a8ed806d7d8fe0a25be Thanks, M.
diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c index 7e3ebf6..c20c9f7 100644 --- a/drivers/irqchip/irq-ti-sci-inta.c +++ b/drivers/irqchip/irq-ti-sci-inta.c @@ -433,8 +433,6 @@ static int ti_sci_inta_set_type(struct irq_data *data, unsigned int type) default: return -EINVAL; } - - return -EINVAL; } static struct irq_chip ti_sci_inta_irq_chip = {
In the function ti_sci_inta_set_type(), the statement "return -EINVAL;" out of switch case is dead code, remove it. Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> --- drivers/irqchip/irq-ti-sci-inta.c | 2 -- 1 file changed, 2 deletions(-)