| Message ID | 1593186236-12760-2-git-send-email-sumitg@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add cpufreq driver for Tegra194 | expand |
On Fri, Jun 26, 2020 at 09:13:53PM +0530, Sumit Gupta wrote: > To do frequency scaling on all CPUs within T194 CPU Complex, we need > to query BPMP for data on valid operating points. Document a compatible > string under 'cpus' node to represent the CPU Complex for binding drivers > like cpufreq which don't have their node or CPU Complex node to bind to. > Also, document a property to point to the BPMP device that can be queried > for all CPUs. > > Signed-off-by: Sumit Gupta <sumitg@nvidia.com> > --- > Documentation/devicetree/bindings/arm/cpus.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml > index a018147..737b55e 100644 > --- a/Documentation/devicetree/bindings/arm/cpus.yaml > +++ b/Documentation/devicetree/bindings/arm/cpus.yaml > @@ -162,6 +162,7 @@ properties: > - nvidia,tegra132-denver > - nvidia,tegra186-denver > - nvidia,tegra194-carmel > + - nvidia,tegra194-ccplex > - qcom,krait > - qcom,kryo > - qcom,kryo260 > @@ -255,6 +256,14 @@ properties: > > where voltage is in V, frequency is in MHz. > > + nvidia,bpmp: > + $ref: '/schemas/types.yaml#/definitions/phandle' > + descrption: | > + Specifies the bpmp node that needs to be queried to get > + operating point data for all CPUs. > + > + Optional for NVIDIA Tegra194 Carmel CPUs Hi, The code (next patches) suggests, that the property is relevant for Tegra194 only. If it is required for compatible=tegra194-ccplex, then maybe you can mark it so (there is already similar constraint described in the file, just before the example section). Best Regards, Michał Mirosław
On Fri, 26 Jun 2020 21:13:53 +0530, Sumit Gupta wrote: > To do frequency scaling on all CPUs within T194 CPU Complex, we need > to query BPMP for data on valid operating points. Document a compatible > string under 'cpus' node to represent the CPU Complex for binding drivers > like cpufreq which don't have their node or CPU Complex node to bind to. > Also, document a property to point to the BPMP device that can be queried > for all CPUs. > > Signed-off-by: Sumit Gupta <sumitg@nvidia.com> > --- > Documentation/devicetree/bindings/arm/cpus.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/cpus.yaml: properties:nvidia,bpmp: Additional properties are not allowed ('descrption' was unexpected) /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/cpus.yaml: properties:nvidia,bpmp: 'descrption' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize', 'unevaluatedProperties', 'uniqueItems'] /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/cpus.yaml: properties:nvidia,bpmp: {'$ref': '/schemas/types.yaml#/definitions/phandle', 'descrption': 'Specifies the bpmp node that needs to be queried to get\noperating point data for all CPUs.\n\nOptional for NVIDIA Tegra194 Carmel CPUs\n'} is not valid under any of the given schemas (Possible causes of the failure): /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/cpus.yaml: properties:nvidia,bpmp: 'description' is a required property Documentation/devicetree/bindings/Makefile:20: recipe for target 'Documentation/devicetree/bindings/arm/cpus.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/arm/cpus.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... Makefile:1347: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1317775 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml index a018147..737b55e 100644 --- a/Documentation/devicetree/bindings/arm/cpus.yaml +++ b/Documentation/devicetree/bindings/arm/cpus.yaml @@ -162,6 +162,7 @@ properties: - nvidia,tegra132-denver - nvidia,tegra186-denver - nvidia,tegra194-carmel + - nvidia,tegra194-ccplex - qcom,krait - qcom,kryo - qcom,kryo260 @@ -255,6 +256,14 @@ properties: where voltage is in V, frequency is in MHz. + nvidia,bpmp: + $ref: '/schemas/types.yaml#/definitions/phandle' + descrption: | + Specifies the bpmp node that needs to be queried to get + operating point data for all CPUs. + + Optional for NVIDIA Tegra194 Carmel CPUs + power-domains: $ref: '/schemas/types.yaml#/definitions/phandle-array' description:
To do frequency scaling on all CPUs within T194 CPU Complex, we need to query BPMP for data on valid operating points. Document a compatible string under 'cpus' node to represent the CPU Complex for binding drivers like cpufreq which don't have their node or CPU Complex node to bind to. Also, document a property to point to the BPMP device that can be queried for all CPUs. Signed-off-by: Sumit Gupta <sumitg@nvidia.com> --- Documentation/devicetree/bindings/arm/cpus.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)