From patchwork Wed Jul 15 11:24:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Beznea X-Patchwork-Id: 11665013 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ABCAD13A4 for ; Wed, 15 Jul 2020 11:26:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85CA820658 for ; Wed, 15 Jul 2020 11:26:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Pgc2m4Td"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="wTIObREP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85CA820658 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GueeHWKyPbrHHK9hpdgwUgdKW6IS6oQaSgMXmAvThtE=; b=Pgc2m4TdGtVNynu7kYp/qV0tx lzBFLWfE58zAQ6xKaGZLPnrHmO5bKYIm3qgFxMOipyrCz+dI+1bGs8VgAu1CdcKeWn8iYj9LDl78+ mILn+kv9I8FsgQ5ZF7uP6u3GREhyjmYYlPT2jy4LVlnZaM9n6cdb+v4UT/7xv4teZFksnghD3pSuE vxfljPJBijwIuR6js710IA2PqL6+kv5VKUKWhBZkQ9CBELUXYJOZhBqZWSmMdaeuXOMhf6YtZcAv6 UKVlEQ3qV6ZP9hALdqCQ/dsyyeTEAHsyvWAVikj7nQX1DNoMWbuILaTeuaYgKPtPnZAhA3Rk75/WH S1KAOT68A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvfWo-0004Js-Aj; Wed, 15 Jul 2020 11:24:46 +0000 Received: from esa3.microchip.iphmx.com ([68.232.153.233]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvfWk-0004J6-Kx for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 11:24:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1594812282; x=1626348282; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=SnrVXchj5oje7KzV5m8bHCbpwoS/HOfvs9d3eno49eU=; b=wTIObREPi5pbPXAkgSG/AkiwO8QMxz+dTzkwjn4ZWBRYeJnkJteofqYx MCbfBkCCKFq8L+Vfwdl2ebhx57YqsAt0K+/yydeyUEQlRtpF58eA3p9ZK LO4KTyq/U2G1ieZPWfe6ZoeMHhl0+Qxm0dzenZEOTJ5FjOHWsjph6uyKt C3TI7iPyUZ23oM+zXYbm5ginYpLRZxx59z+N11AnoZiOjxugS/nXljZxA 8BdEc9XVDm2axQgVfHVd625GVwpFKq/L0e2J6ET2I8GWSRjUqSyldW29P XXXu+AqHN8xDMtiWZFxoY7IjTg3tNqQlun7DzRlACX+/OGsXIlIhgTqz/ g==; IronPort-SDR: PXXQ6iws6jNB7HWOdIevOcnYrYk/9g2UBkrGV+A9h60NqbExZ4FrpSUp/u/MIb1DMX0e1IO8Ta 9f5pXkGfa5cf/DVwWI/tDGgsbHWOPvvA4F/hRHZwK+wrgRIAMhjFYbePyKbyB5I/ZgDs7zJjAs xGOLgQ78ySdQ5c5Jr02MuInBAwFoRyMenENGoHA2F50wZO/RNgwtPbCzjPzXhJeJMwWumFp9C1 EAOYR62I4rmsIA/F6ThJUOHSkNmwtwOIbcOwC3w9RdLdfVZ45BpBZ5CtUNCI1h63wcrMYgSiF9 06Q= X-IronPort-AV: E=Sophos;i="5.75,355,1589266800"; d="scan'208";a="83962772" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 15 Jul 2020 04:24:41 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 15 Jul 2020 04:24:41 -0700 Received: from m18063-ThinkPad-T460p.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Wed, 15 Jul 2020 04:24:06 -0700 From: Claudiu Beznea To: , , , , Subject: [PATCH 02/19] clk: at91: clk-generated: check best_rate against ranges Date: Wed, 15 Jul 2020 14:24:10 +0300 Message-ID: <1594812267-6697-3-git-send-email-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1594812267-6697-1-git-send-email-claudiu.beznea@microchip.com> References: <1594812267-6697-1-git-send-email-claudiu.beznea@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_072442_876205_3BF17A26 X-CRM114-Status: UNSURE ( 9.99 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [68.232.153.233 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [68.232.153.233 listed in wl.mailspike.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Claudiu Beznea , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bbrezillon@kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Check best_rate against available clock ranges. Fixes: df70aeef6083 ("clk: at91: add generated clock driver") Signed-off-by: Claudiu Beznea Reviewed-by: Alexandre Belloni --- drivers/clk/at91/clk-generated.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/at91/clk-generated.c b/drivers/clk/at91/clk-generated.c index 995a13133cfb..f8e557e0e1b8 100644 --- a/drivers/clk/at91/clk-generated.c +++ b/drivers/clk/at91/clk-generated.c @@ -185,8 +185,8 @@ static int clk_generated_determine_rate(struct clk_hw *hw, __clk_get_name((req->best_parent_hw)->clk), req->best_parent_rate); - if (best_rate < 0) - return best_rate; + if (best_rate < 0 || (gck->range.max && best_rate > gck->range.max)) + return -EINVAL; req->rate = best_rate; return 0;