From patchwork Wed Jul 22 07:38:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Beznea X-Patchwork-Id: 11677605 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6484A138A for ; Wed, 22 Jul 2020 07:40:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C11920714 for ; Wed, 22 Jul 2020 07:40:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Uu1oCch6"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="Jd6rxWIV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C11920714 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hsmc7FMAZH+hb6xnHz5j4H4xFdkIa7Jo4qmjjkYZI6Q=; b=Uu1oCch6lUzAk044eYTC68q6j nj7k3OTFF0nyKuQ/Z5H96z44IkdmIpqW8SmegAGF+CEV6GzCpkKjnR57mJ5w7uFEjY4uMtnrL0lMB lqzItIvL044y66vUHTn8Oz3ulaEEdY2+18YfNgV2v521C1WJy1y1UAFmetxmjYUX0hPabaXjzlGRr Auh0afnJyG3M0fnzDv3dS1T3wAkK64GU7ZSUJ/TwGxNMs7Y9WlkizDrCHGMQu0lTVOzLxn0Znr7Xd jmbHac9qxXaVyXvl1z2G5Rkc4WXqqM2PpFGvSGKgEMbqR16wwyJIzPWJeHIbOOYWuv06yyhI3RMcx hkOQhQM1A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jy9LC-0008Cw-US; Wed, 22 Jul 2020 07:39:02 +0000 Received: from esa4.microchip.iphmx.com ([68.232.154.123]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jy9Kz-00086R-1G for linux-arm-kernel@lists.infradead.org; Wed, 22 Jul 2020 07:38:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1595403528; x=1626939528; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=1lgGYgjpKH2HGPHaQHzzdMzBnMOFYGIAlTJ2p5Kf5wU=; b=Jd6rxWIV5X4U9xPBR0zPV/PhUk77eifNRCMoWDd22sVhLttczsBOw1DI HRyIU4Jnr96Onp0uzHugTr6Mzv4/r3nCRKzvfj+4BgNJVWFjduojx2MCp dpvsUi2kEVSTSDkoO/obgcoxuBNgKvkMjvAZnPWNwk9nRTYWxdPbe/KiN KxmMfLQVNGemn6blIk0LK9eojgc95B34bYX3z2zkR7LFBxFwAJzScbfrA x7R2uyHEkN34aR9LkLIQ7+qjGBPmcOhd24gTZf0c17yRq1v7AaL7jF6A/ MeaV88/AgQeXlxUf5h/3ItfvG3pA9fYs/z3L/O8fX8KHmyOv5ijL8QK2g w==; IronPort-SDR: cW1cbX+autDWg6THeeQ1ukLA4jZOGqtLAxReC21dFS7YZN/RTWXu3rIHFM9KsXh22fkqM7WvzF 7itHJ86DaLwTY8qUc6E890eQgxuis8ujiRA968r3Su0mM7ppQhyDTEpm+09lYZT5M9hIcxlZ0b kWj9p2pMN1f23enX2wZdirmiSDuaOwz6h5dvgvkBD9bSszta19ibaiVesjfc5RJlz2JP5LaGEa ioOxi/LDynCQmfAo9sJc8aEc/BTdpJkKdCfgFFov+5m/wJNl2UB8HFm+QQvUw3Xp8cn22tgPI9 f+I= X-IronPort-AV: E=Sophos;i="5.75,381,1589266800"; d="scan'208";a="80862097" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 22 Jul 2020 00:38:48 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 22 Jul 2020 00:38:48 -0700 Received: from m18063-ThinkPad-T460p.microchip.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Wed, 22 Jul 2020 00:38:45 -0700 From: Claudiu Beznea To: , , , , Subject: [PATCH v2 04/18] clk: at91: sam9x60-pll: use logical or for range check Date: Wed, 22 Jul 2020 10:38:12 +0300 Message-ID: <1595403506-8209-5-git-send-email-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1595403506-8209-1-git-send-email-claudiu.beznea@microchip.com> References: <1595403506-8209-1-git-send-email-claudiu.beznea@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200722_033849_293927_0698CFFA X-CRM114-Status: GOOD ( 10.12 ) X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [68.232.154.123 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [68.232.154.123 listed in wl.mailspike.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Claudiu Beznea , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bbrezillon@kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Use logical or for range check. In case bestrate is not in characteristics->output[0].min..characteristics->output[0].max range we should return -ERANGE. Fixes: a436c2a447e59 ("clk: at91: add sam9x60 PLL driver") Signed-off-by: Claudiu Beznea Reviewed-by: Alexandre Belloni --- drivers/clk/at91/clk-sam9x60-pll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/at91/clk-sam9x60-pll.c b/drivers/clk/at91/clk-sam9x60-pll.c index 3522eae2edd6..4b7b6c435d4e 100644 --- a/drivers/clk/at91/clk-sam9x60-pll.c +++ b/drivers/clk/at91/clk-sam9x60-pll.c @@ -231,7 +231,7 @@ static long sam9x60_pll_get_best_div_mul(struct sam9x60_pll *pll, } /* Check if bestrate is a valid output rate */ - if (bestrate < characteristics->output[0].min && + if (bestrate < characteristics->output[0].min || bestrate > characteristics->output[0].max) return -ERANGE;