| Message ID | 1604050097-91302-1-git-send-email-zou_wei@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] usb: Make sync_all_pins static | expand |
On Fri, Oct 30, 2020 at 11:18 AM Zou Wei <zou_wei@huawei.com> wrote: The title can be more precise. > Fix the following sparse warning: > > drivers/usb/misc/brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static? Do we really need to know the path? > The sync_all_pins has only call site within brcmstb-usb-pinmap.c sync_all_pins() > It should be static Missed period.
On Fri, Oct 30, 2020 at 01:18:33PM +0200, Andy Shevchenko wrote: > On Fri, Oct 30, 2020 at 11:18 AM Zou Wei <zou_wei@huawei.com> wrote: > > The title can be more precise. > > > Fix the following sparse warning: > > > > drivers/usb/misc/brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static? > > Do we really need to know the path? That's the warning message from the tool, why complain about it? thanks, greg k-h
diff --git a/drivers/usb/misc/brcmstb-usb-pinmap.c b/drivers/usb/misc/brcmstb-usb-pinmap.c index 02144c3..cc9618d 100644 --- a/drivers/usb/misc/brcmstb-usb-pinmap.c +++ b/drivers/usb/misc/brcmstb-usb-pinmap.c @@ -216,7 +216,7 @@ static int parse_pins(struct device *dev, struct device_node *dn, return 0; } -void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata) +static void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata) { struct out_pin *pout; struct in_pin *pin;
Fix the following sparse warning: drivers/usb/misc/brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static? The sync_all_pins has only call site within brcmstb-usb-pinmap.c It should be static Fixes: 517c4c44b323 ("usb: Add driver to allow any GPIO to be used for 7211 USB signals") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> --- drivers/usb/misc/brcmstb-usb-pinmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)