| Message ID | 1610705349-24310-1-git-send-email-abaci-bugfix@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drivers/pinctrl/bcm: Simplify bool comparison | expand |
On 1/15/2021 2:09 AM, Jiapeng Zhong wrote: > Fix the follow coccicheck warnings: > > ./drivers/pinctrl/bcm/pinctrl-ns2-mux.c:856:29-38: WARNING: > Comparison to bool. > Sorry I must be missing something here. Why is there a warning while 'pull_up' and 'pull_down' are already of type 'bool' and compared to 'false'? > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> > --- > drivers/pinctrl/bcm/pinctrl-ns2-mux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c > index 57044ab..0fe4a1f 100644 > --- a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c > +++ b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c > @@ -853,7 +853,7 @@ static int ns2_pin_config_get(struct pinctrl_dev *pctldev, unsigned int pin, > switch (param) { > case PIN_CONFIG_BIAS_DISABLE: > ns2_pin_get_pull(pctldev, pin, &pull_up, &pull_down); > - if ((pull_up == false) && (pull_down == false)) > + if (!pull_up && !pull_down) Looks fine as improvement, but I'm curious why there's a warning to start with. Thanks, Ray > return 0; > else > return -EINVAL; >
On Fri, Jan 15, 2021 at 7:24 PM Ray Jui <ray.jui@broadcom.com> wrote: > > - if ((pull_up == false) && (pull_down == false)) > > + if (!pull_up && !pull_down) > > Looks fine as improvement, but I'm curious why there's a warning to > start with. There is no semantic difference. This is a purely syntactic warning. Yours, Linus Walleij
On Fri, Jan 15, 2021 at 11:09 AM Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> wrote: > Fix the follow coccicheck warnings: > > ./drivers/pinctrl/bcm/pinctrl-ns2-mux.c:856:29-38: WARNING: > Comparison to bool. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> Patch applied. Yours, Linus Walleij
diff --git a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c index 57044ab..0fe4a1f 100644 --- a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c +++ b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c @@ -853,7 +853,7 @@ static int ns2_pin_config_get(struct pinctrl_dev *pctldev, unsigned int pin, switch (param) { case PIN_CONFIG_BIAS_DISABLE: ns2_pin_get_pull(pctldev, pin, &pull_up, &pull_down); - if ((pull_up == false) && (pull_down == false)) + if (!pull_up && !pull_down) return 0; else return -EINVAL;
Fix the follow coccicheck warnings: ./drivers/pinctrl/bcm/pinctrl-ns2-mux.c:856:29-38: WARNING: Comparison to bool. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> --- drivers/pinctrl/bcm/pinctrl-ns2-mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)