From patchwork Thu Jan 21 10:57:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuldeep Singh X-Patchwork-Id: 12035569 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55038C433E9 for ; Thu, 21 Jan 2021 11:00:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E17B923787 for ; Thu, 21 Jan 2021 11:00:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E17B923787 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:Message-Id:Date:Subject:To: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SWyNSkTM8yU/iRr3Bx9LUAwLeCcHANIqRsbRYV9o10A=; b=cPRNERLdFdEwjTzGiD/qOiZGnJ fbmr/iDdnd31aXa6ia8lAyUTVNupgWoZ34aYsH8+tuPfORvRDP+LDnMp9W2O7qy0pD4qlPK4KC+cs BNqyI4GACj72ZSDa6tshNJAD3eZW/2HWzkUCCZX4C2e9BMvfE/g3Q7Up8B65E4Wzs9KO7bY8VHc9x KypqW5KXqQTYK40b6E1XwBmyuTRWgCY8kL7/kZkyrb2zpt1UzSYoN/f4h1X5cm82OJspOrTq2nK1e 8UCSIqj7XYUiHZgq0ZgKTGBOcK160FvHvYXV5Gzvh5bI2Cdju/tkCvMSpiuYS2oWA1K6PvrCQDwns J29EZbQw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2XfK-0001DK-Rt; Thu, 21 Jan 2021 10:58:14 +0000 Received: from inva021.nxp.com ([92.121.34.21]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2XfG-0001BX-I2 for linux-arm-kernel@lists.infradead.org; Thu, 21 Jan 2021 10:58:11 +0000 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id AA55D200C68; Thu, 21 Jan 2021 11:58:09 +0100 (CET) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 05D4B200C74; Thu, 21 Jan 2021 11:58:07 +0100 (CET) Received: from lsv03124.swis.in-blr01.nxp.com (lsv03124.swis.in-blr01.nxp.com [92.120.146.121]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 8F92740297; Thu, 21 Jan 2021 11:58:03 +0100 (CET) From: Kuldeep Singh To: Shawn Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [Patch v2 2/3] arm64: dtsi: ls1028a: Update flexcan properties Date: Thu, 21 Jan 2021 16:27:38 +0530 Message-Id: <1611226659-30129-3-git-send-email-kuldeep.singh@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1611226659-30129-1-git-send-email-kuldeep.singh@nxp.com> References: <1611226659-30129-1-git-send-email-kuldeep.singh@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210121_055810_721271_31B1ED93 X-CRM114-Status: GOOD ( 10.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kuldeep Singh , linux-arm-kernel@lists.infradead.org, Li Yang MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org LS1028A supports two flexcan controllers similar to LX2160A. There's already a compatible entry defined i.e "fsl,lx2160ar1-flexcan" which can be further reused for LS1028A. Please note, "fsl,ls1028ar1-flexcan" compatible entry doesn't exists and can be safely removed. LS1028A has a single peripheral clock (i.e platform clock) source connected to both "ipg" and "per" and therefore, remove "sysclk" as clock source from device-tree. Signed-off-by: Kuldeep Singh --- Hi Shawn, I would like to mention the motivation behind compatible string change. There's no ls1028a compatible entry i.e " fsl,ls1028ar1-flexcan" in flexcan driver. See below. https://elixir.bootlin.com/linux/latest/source/drivers/net/can/flexcan.c#L1913 And the documentation says that ls1028a entry should be followed by lx2160a. https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml#L42 Since ls1028a entry is not present, anyway lx2160a entry will be eventually used. Please let me know your views. arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi index e00acad..d28bd52 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi @@ -408,21 +408,25 @@ }; can0: can@2180000 { - compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-flexcan"; + compatible = "fsl,lx2160ar1-flexcan"; reg = <0x0 0x2180000 0x0 0x10000>; interrupts = ; - clocks = <&sysclk>, <&clockgen QORIQ_CLK_PLATFORM_PLL - QORIQ_CLK_PLL_DIV(2)>; + clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL + QORIQ_CLK_PLL_DIV(2)>, + <&clockgen QORIQ_CLK_PLATFORM_PLL + QORIQ_CLK_PLL_DIV(2)>; clock-names = "ipg", "per"; status = "disabled"; }; can1: can@2190000 { - compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-flexcan"; + compatible = "fsl,lx2160ar1-flexcan"; reg = <0x0 0x2190000 0x0 0x10000>; interrupts = ; - clocks = <&sysclk>, <&clockgen QORIQ_CLK_PLATFORM_PLL - QORIQ_CLK_PLL_DIV(2)>; + clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL + QORIQ_CLK_PLL_DIV(2)>, + <&clockgen QORIQ_CLK_PLATFORM_PLL + QORIQ_CLK_PLL_DIV(2)>; clock-names = "ipg", "per"; status = "disabled"; };