| Message ID | 1612247872-32603-1-git-send-email-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | psci: remove unneeded semicolon | expand |
On Tue, Feb 02, 2021 at 02:37:52PM +0800, Yang Li wrote: > Eliminate the following coccicheck warning: > ./drivers/firmware/psci/psci.c:141:2-3: Unneeded semicolon Nit: subject should read "psci: Remove unneeded semicolon" > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/firmware/psci/psci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Please send a v2 and address it to Mark, me and arm@kernel.org so that they can pick it up. Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index f5fc429..35b355e 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -138,7 +138,7 @@ static int psci_to_linux_errno(int errno) > return -EINVAL; > case PSCI_RET_DENIED: > return -EPERM; > - }; > + } > > return -EINVAL; > } > -- > 1.8.3.1 >
On Wed, Apr 28, 2021 at 10:41:30AM +0100, Lorenzo Pieralisi wrote: > On Tue, Feb 02, 2021 at 02:37:52PM +0800, Yang Li wrote: > > Eliminate the following coccicheck warning: > > ./drivers/firmware/psci/psci.c:141:2-3: Unneeded semicolon > > Nit: subject should read "psci: Remove unneeded semicolon" > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > > --- > > drivers/firmware/psci/psci.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Please send a v2 and address it to Mark, me and arm@kernel.org so > that they can pick it up. > Though I assume they still check arm@kernel.org, soc@kernel.org is new and more preferred these days. I just checked MAINTAINERS entry to be sure and I see only soc@kernel.org. So please add soc@kernel.org to the list, may be it gets quicker attention than the other
diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c index f5fc429..35b355e 100644 --- a/drivers/firmware/psci/psci.c +++ b/drivers/firmware/psci/psci.c @@ -138,7 +138,7 @@ static int psci_to_linux_errno(int errno) return -EINVAL; case PSCI_RET_DENIED: return -EPERM; - }; + } return -EINVAL; }
Eliminate the following coccicheck warning: ./drivers/firmware/psci/psci.c:141:2-3: Unneeded semicolon Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/firmware/psci/psci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)