| Message ID | 1615621683-2122-1-git-send-email-wangqing@vivo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | gpu: drm: mediatek: delete redundant printing of return value | expand |
Hi, Wang: Wang Qing <wangqing@vivo.com> 於 2021年3月13日 週六 下午3:48寫道： > > platform_get_irq() has already checked and printed the return value, > the printing here is nothing special, it is not necessary at all. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Wang Qing <wangqing@vivo.com> > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c > index b05f900..0ac4962 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -751,10 +751,8 @@ static int mtk_dpi_probe(struct platform_device *pdev) > } > > dpi->irq = platform_get_irq(pdev, 0); > - if (dpi->irq <= 0) { > - dev_err(dev, "Failed to get irq: %d\n", dpi->irq); > + if (dpi->irq <= 0) > return -EINVAL; > - } > > ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > NULL, &dpi->next_bridge); > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index b05f900..0ac4962 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -751,10 +751,8 @@ static int mtk_dpi_probe(struct platform_device *pdev) } dpi->irq = platform_get_irq(pdev, 0); - if (dpi->irq <= 0) { - dev_err(dev, "Failed to get irq: %d\n", dpi->irq); + if (dpi->irq <= 0) return -EINVAL; - } ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, NULL, &dpi->next_bridge);
platform_get_irq() has already checked and printed the return value, the printing here is nothing special, it is not necessary at all. Signed-off-by: Wang Qing <wangqing@vivo.com> --- drivers/gpu/drm/mediatek/mtk_dpi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)