| Message ID | 1617990965-35337-7-git-send-email-radhey.shyam.pandey@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Xilinx DMA enhancements and optimization | expand |
On 4/9/21 7:56 PM, Radhey Shyam Pandey wrote: > Schedule tasklet with high priority to ensure that callback processing > is prioritized. It improves throughput for netdev dma clients. Do you have specific numbers on the throughput improvement?
> -----Original Message----- > From: Lars-Peter Clausen <lars@metafoo.de> > Sent: Thursday, April 15, 2021 12:41 PM > To: Radhey Shyam Pandey <radheys@xilinx.com>; vkoul@kernel.org; > robh+dt@kernel.org; Michal Simek <michals@xilinx.com> > Cc: dmaengine@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; git > <git@xilinx.com> > Subject: Re: [RFC v2 PATCH 6/7] dmaengine: xilinx_dma: Use > tasklet_hi_schedule for timing critical usecase > > On 4/9/21 7:56 PM, Radhey Shyam Pandey wrote: > > Schedule tasklet with high priority to ensure that callback processing > > is prioritized. It improves throughput for netdev dma clients. > Do you have specific numbers on the throughput improvement? IIRC there was ~5% performance improvement but I did that a long back on an older kernel 4.8 and after that onward I always checked overall performance (having all optimization applied). In next version i will redo incremental profiling and capture improvement % in the commit description. Thanks, Radhey
diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index f2305a73cb91..a2ea2d649332 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -1829,7 +1829,7 @@ static irqreturn_t xilinx_mcdma_irq_handler(int irq, void *data) spin_unlock(&chan->lock); } - tasklet_schedule(&chan->tasklet); + tasklet_hi_schedule(&chan->tasklet); return IRQ_HANDLED; }
Schedule tasklet with high priority to ensure that callback processing is prioritized. It improves throughput for netdev dma clients. Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> -- Changes for v2: - None --- drivers/dma/xilinx/xilinx_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)