| Message ID | 1620302579-5949-1-git-send-email-tiantao6@hisilicon.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm_pmu: move to use request_irq by IRQF_NO_AUTOEN flag | expand |
On Thu, May 06, 2021 at 08:02:59PM +0800, Tian Tao wrote: > request_irq() after setting IRQ_NOAUTOEN as below > irq_set_status_flags(irq, IRQ_NOAUTOEN); > request_irq(dev, irq...); > can be replaced by request_irq() with IRQF_NO_AUTOEN flag. > > this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which > is being merged: https://lore.kernel.org/patchwork/patch/1388765/ > > Signed-off-by: Tian Tao <tiantao6@hisilicon.com> > --- > drivers/perf/arm_pmu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c > index d4f7f1f..6bcfc52 100644 > --- a/drivers/perf/arm_pmu.c > +++ b/drivers/perf/arm_pmu.c > @@ -644,11 +644,9 @@ int armpmu_request_irq(int irq, int cpu) > } > > irq_flags = IRQF_PERCPU | > - IRQF_NOBALANCING | > + IRQF_NOBALANCING | IRQF_NO_AUTOEN | > IRQF_NO_THREAD; > > - irq_set_status_flags(irq, IRQ_NOAUTOEN); > - > err = request_nmi(irq, handler, irq_flags, "arm-pmu", > per_cpu_ptr(&cpu_armpmu, cpu)); Please can you update drivers/perf/qcom_l2_pmu.c at the same time? Will
在 2021/6/1 20:46, Will Deacon 写道: > On Thu, May 06, 2021 at 08:02:59PM +0800, Tian Tao wrote: >> request_irq() after setting IRQ_NOAUTOEN as below >> irq_set_status_flags(irq, IRQ_NOAUTOEN); >> request_irq(dev, irq...); >> can be replaced by request_irq() with IRQF_NO_AUTOEN flag. >> >> this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which >> is being merged: https://lore.kernel.org/patchwork/patch/1388765/ >> >> Signed-off-by: Tian Tao <tiantao6@hisilicon.com> >> --- >> drivers/perf/arm_pmu.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c >> index d4f7f1f..6bcfc52 100644 >> --- a/drivers/perf/arm_pmu.c >> +++ b/drivers/perf/arm_pmu.c >> @@ -644,11 +644,9 @@ int armpmu_request_irq(int irq, int cpu) >> } >> >> irq_flags = IRQF_PERCPU | >> - IRQF_NOBALANCING | >> + IRQF_NOBALANCING | IRQF_NO_AUTOEN | >> IRQF_NO_THREAD; >> >> - irq_set_status_flags(irq, IRQ_NOAUTOEN); >> - >> err = request_nmi(irq, handler, irq_flags, "arm-pmu", >> per_cpu_ptr(&cpu_armpmu, cpu)); > Please can you update drivers/perf/qcom_l2_pmu.c at the same time? ok I will send v2. > > Will > . >
diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c index d4f7f1f..6bcfc52 100644 --- a/drivers/perf/arm_pmu.c +++ b/drivers/perf/arm_pmu.c @@ -644,11 +644,9 @@ int armpmu_request_irq(int irq, int cpu) } irq_flags = IRQF_PERCPU | - IRQF_NOBALANCING | + IRQF_NOBALANCING | IRQF_NO_AUTOEN | IRQF_NO_THREAD; - irq_set_status_flags(irq, IRQ_NOAUTOEN); - err = request_nmi(irq, handler, irq_flags, "arm-pmu", per_cpu_ptr(&cpu_armpmu, cpu));
request_irq() after setting IRQ_NOAUTOEN as below irq_set_status_flags(irq, IRQ_NOAUTOEN); request_irq(dev, irq...); can be replaced by request_irq() with IRQF_NO_AUTOEN flag. this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which is being merged: https://lore.kernel.org/patchwork/patch/1388765/ Signed-off-by: Tian Tao <tiantao6@hisilicon.com> --- drivers/perf/arm_pmu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)