| Message ID | 1621857218-28590-1-git-send-email-tiantao6@hisilicon.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] hwrng: exynos: Use pm_runtime_resume_and_get() to replace open coding | expand |
On 24/05/2021 07:53, Tian Tao wrote: > use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and > pm_runtime_put_noidle. this change is just to simplify the code, no > actual functional changes. > > Signed-off-by: Tian Tao <tiantao6@hisilicon.com> > --- > v2: drop unnecessary change about if condition. > --- > drivers/char/hw_random/exynos-trng.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
It was <2021-05-24 pon 19:53>, when Tian Tao wrote: > use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and > pm_runtime_put_noidle. this change is just to simplify the code, no > actual functional changes. > > Signed-off-by: Tian Tao <tiantao6@hisilicon.com> > --- > v2: drop unnecessary change about if condition. > --- > drivers/char/hw_random/exynos-trng.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Acked-by: Łukasz Stelmach <l.stelmach@samsung.com> > diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c > index c8db62b..9cc3d54 100644 > --- a/drivers/char/hw_random/exynos-trng.c > +++ b/drivers/char/hw_random/exynos-trng.c > @@ -196,10 +196,9 @@ static int __maybe_unused exynos_trng_resume(struct device *dev) > { > int ret; > > - ret = pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); > if (ret < 0) { > dev_err(dev, "Could not get runtime PM.\n"); > - pm_runtime_put_noidle(dev); > return ret; > }
Tian Tao <tiantao6@hisilicon.com> wrote: > use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and > pm_runtime_put_noidle. this change is just to simplify the code, no > actual functional changes. > > Signed-off-by: Tian Tao <tiantao6@hisilicon.com> > --- > v2: drop unnecessary change about if condition. > --- > drivers/char/hw_random/exynos-trng.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Patch applied. Thanks.
diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c index c8db62b..9cc3d54 100644 --- a/drivers/char/hw_random/exynos-trng.c +++ b/drivers/char/hw_random/exynos-trng.c @@ -196,10 +196,9 @@ static int __maybe_unused exynos_trng_resume(struct device *dev) { int ret; - ret = pm_runtime_get_sync(dev); + ret = pm_runtime_resume_and_get(dev); if (ret < 0) { dev_err(dev, "Could not get runtime PM.\n"); - pm_runtime_put_noidle(dev); return ret; }
use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and pm_runtime_put_noidle. this change is just to simplify the code, no actual functional changes. Signed-off-by: Tian Tao <tiantao6@hisilicon.com> --- v2: drop unnecessary change about if condition. --- drivers/char/hw_random/exynos-trng.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)