diff mbox series

Revert "ARM: dts: bcm283x: increase dwc2's RX FIFO size"

Message ID 1622293371-5997-1-git-send-email-stefan.wahren@i2se.com (mailing list archive)
State New, archived
Headers show
Series Revert "ARM: dts: bcm283x: increase dwc2's RX FIFO size" | expand

Commit Message

Stefan Wahren May 29, 2021, 1:02 p.m. UTC
This reverts commit 278407a53c3b33fb820332c4d39eb39316c3879a.

The original change breaks USB config on Raspberry Pi Zero and Pi 4 B,
because it exceeds the total fifo size of 4080. A naive attempt to reduce
g-tx-fifo-size doesn't help on Raspberry Pi Zero. So better go back.

Fixes: 278407a53c3b ("ARM: dts: bcm283x: increase dwc2's RX FIFO size")
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Pavel Hofman <pavel.hofman@ivitera.com>
---
 arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi        | 2 +-
 arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Nicolas Saenz Julienne June 8, 2021, 10:06 a.m. UTC | #1
On Sat, 2021-05-29 at 15:02 +0200, Stefan Wahren wrote:
> This reverts commit 278407a53c3b33fb820332c4d39eb39316c3879a.
> 
> The original change breaks USB config on Raspberry Pi Zero and Pi 4 B,
> because it exceeds the total fifo size of 4080. A naive attempt to reduce
> g-tx-fifo-size doesn't help on Raspberry Pi Zero. So better go back.
> 
> Fixes: 278407a53c3b ("ARM: dts: bcm283x: increase dwc2's RX FIFO size")
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Cc: Pavel Hofman <pavel.hofman@ivitera.com>
> ---

Applied for next.

Regards,
Nicolas
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi b/arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi
index 20322de..e2fd961 100644
--- a/arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi
+++ b/arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi
@@ -1,7 +1,7 @@ 
 // SPDX-License-Identifier: GPL-2.0
 &usb {
 	dr_mode = "otg";
-	g-rx-fifo-size = <558>;
+	g-rx-fifo-size = <256>;
 	g-np-tx-fifo-size = <32>;
 	/*
 	 * According to dwc2 the sum of all device EP
diff --git a/arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi b/arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi
index 1409d1b..0ff0e9e 100644
--- a/arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi
+++ b/arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi
@@ -1,7 +1,7 @@ 
 // SPDX-License-Identifier: GPL-2.0
 &usb {
 	dr_mode = "peripheral";
-	g-rx-fifo-size = <558>;
+	g-rx-fifo-size = <256>;
 	g-np-tx-fifo-size = <32>;
 	g-tx-fifo-size = <256 256 512 512 512 768 768>;
 };