From patchwork Thu Feb 21 10:02:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 2171101 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 719E03FD4E for ; Thu, 21 Feb 2013 10:06:16 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1U8SzL-00051i-EY; Thu, 21 Feb 2013 10:02:51 +0000 Received: from moutng.kundenserver.de ([212.227.17.10]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U8SzH-00051C-PA for linux-arm-kernel@lists.infradead.org; Thu, 21 Feb 2013 10:02:49 +0000 Received: from wuerfel.localnet (HSI-KBW-46-223-90-92.hsi.kabel-badenwuerttemberg.de [46.223.90.92]) by mrelayeu.kundenserver.de (node=mreu4) with ESMTP (Nemesis) id 0LftFf-1UfYtf27Vj-00pbFQ; Thu, 21 Feb 2013 11:02:40 +0100 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: Re: arm64 defconfig breakage (gpio) in next-20130218 Date: Thu, 21 Feb 2013 11:02:15 +0100 Message-ID: <1634805.kh17mYrJe5@wuerfel> User-Agent: KMail/4.10 rc3 (Linux/3.8.0-4-generic; KDE/4.10.0; x86_64; ; ) In-Reply-To: <20130221093104.GB23442@S2101-09.ap.freescale.net> References: <20130218111410.GA10572@e106331-lin.cambridge.arm.com> <20130221093104.GB23442@S2101-09.ap.freescale.net> MIME-Version: 1.0 X-Provags-ID: V02:K0:YrMP3g/OeVuDrHhx6dafyvEot9qpoFIK6c9AJ4mc1Kg d5Bs7vd1kOylXHVZd2U6/tBBTodztY+4uWY6BHW5+0QPu7we5r I9lMzeOWqo02EaUWdtZmgdbxYTEVI7oR21yOioqQpqufb9PA/P QbNfdSThFDIQE7tRrHqAWFh7bXLVJojDBzmN272+WwePKtPXUp flc5iQLgHeUr/2GTRHaz4zMuYf5ZCqmXvOHbLB5+fj4bZ72wvC 9G6pdPwfsZf1t4xufAJXm6wno5zD/ThkQh8b8QYMkATbihk7DQ /QwWdnKDfjLeuI6dSScHtREFGJtkykI9N8KgI1HG7u2oqVrVh7 gamkmJUZlyMnAlWBK5N0= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130221_050248_120381_C022D013 X-CRM114-Status: GOOD ( 12.98 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.17.10 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Mark Rutland , Grant Likely , Linus Walleij , Shawn Guo , Catalin Marinas X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Thursday 21 February 2013 17:31:07 Shawn Guo wrote: > > > > I've bisected this down to 0fa2fd9a0d: "Merge branch 'linusw/devel' of > > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git into > > gpio/next". Both parent commits build fine. > > > > I've played around a bit, and selecting ARCH_REQUIRE_GPIOLIB in the arm64 > > Kconfig fixes the issue, but I'm unfamilar with gpio{,lib} and I'm not sure > > that's the best/correct way of solving this. > > Kconfig GENERIC_GPIO is designed as an option defined at architecture > level and select by platform who knows how gpio driver/API is > implemented. The following change should fix the error. > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index f532ce5..aca4a25 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -93,7 +93,7 @@ config IOMMU_HELPER > def_bool SWIOTLB > > config GENERIC_GPIO > - def_bool y > + bool > > source "init/Kconfig" But we have no arm64 platforms that would pick GENERIC_GPIO, it's expected to come from GPIOLIB anyway. I think the right fix is this: Arnd Acked-by: Catalin Marinas diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index ab4aa54..3fab0db 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -3,6 +3,7 @@ config ARM64 select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE select ARCH_WANT_COMPAT_IPC_PARSE_VERSION select ARCH_WANT_FRAME_POINTERS + select ARCH_WANT_OPTIONAL_GPIOLIB select ARM_AMBA select ARM_ARCH_TIMER select CLONE_BACKWARDS @@ -92,9 +93,6 @@ config SWIOTLB config IOMMU_HELPER def_bool SWIOTLB -config GENERIC_GPIO - def_bool y - source "init/Kconfig" source "kernel/Kconfig.freezer"