diff mbox series

[v2,2/7] dt-binding: phy: Add iMX8MP PCIe PHY binding

Message ID 1646644054-24421-3-git-send-email-hongxing.zhu@nxp.com (mailing list archive)
State New, archived
Headers show
Series Add the iMX8MP PCIe support | expand

Commit Message

Hongxing Zhu March 7, 2022, 9:07 a.m. UTC 
Add i.MX8MP PCIe PHY binding.

Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
 Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Rob Herring (Arm) March 8, 2022, 1:07 a.m. UTC | #1 
On Mon, 07 Mar 2022 17:07:29 +0800, Richard Zhu wrote:
> Add i.MX8MP PCIe PHY binding.
> 
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
>  Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.example.dt.yaml: pcie-phy@32f00000: resets: [[4294967295, 26]] is too short
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.example.dt.yaml: pcie-phy@32f00000: reset-names: ['pciephy'] is too short
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1601963

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.
Hongxing Zhu March 10, 2022, 2:04 a.m. UTC | #2 
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 2022年3月8日 9:08
> To: Hongxing Zhu <hongxing.zhu@nxp.com>
> Cc: kernel@pengutronix.de; linux-phy@lists.infradead.org;
> shawnguo@kernel.org; linux-pci@vger.kernel.org;
> alexander.stein@ew.tq-group.com; bhelgaas@google.com;
> linux-arm-kernel@lists.infradead.org; p.zabel@pengutronix.de;
> lorenzo.pieralisi@arm.com; devicetree@vger.kernel.org; vkoul@kernel.org;
> l.stach@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 2/7] dt-binding: phy: Add iMX8MP PCIe PHY binding
> 
> On Mon, 07 Mar 2022 17:07:29 +0800, Richard Zhu wrote:
> > Add i.MX8MP PCIe PHY binding.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):

Hi Rob:
Thanks for your help. Would be fixed in next version.

Best Regards
Richard Zhu

> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/fs
> l,imx8-pcie-phy.example.dt.yaml: pcie-phy@32f00000: resets: [[4294967295,
> 26]] is too short
> 	From schema:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/fs
> l,imx8-pcie-phy.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/fs
> l,imx8-pcie-phy.example.dt.yaml: pcie-phy@32f00000: reset-names: ['pciephy']
> is too short
> 	From schema:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/fs
> l,imx8-pcie-phy.yaml
> 
> doc reference errors (make refcheckdocs):
> 
> See
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchw
> ork.ozlabs.org%2Fpatch%2F1601963&amp;data=04%7C01%7Chongxing.zhu%
> 40nxp.com%7Cd1f3b562533e4c666e8508da00a01379%7C686ea1d3bc2b4c6
> fa92cd99c5c301635%7C0%7C1%7C637822984762155977%7CUnknown%7CT
> WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJ
> XVCI6Mn0%3D%7C3000&amp;sdata=bONN5kLwoBPe3D0KwURR1FapNFcGI3js
> K7XLPzZeZnQ%3D&amp;reserved=0
> 
> This check can fail if there are any dependencies. The base for a patch series is
> generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml
index b6421eedece3..3646b3ed4375 100644
--- a/Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml
@@ -16,6 +16,7 @@  properties:
   compatible:
     enum:
       - fsl,imx8mm-pcie-phy
+      - fsl,imx8mp-pcie-phy
 
   reg:
     maxItems: 1
@@ -28,11 +29,12 @@  properties:
       - const: ref
 
   resets:
-    maxItems: 1
+    maxItems: 2
 
   reset-names:
     items:
       - const: pciephy
+      - const: perst
 
   fsl,refclk-pad-mode:
     description: |