| Message ID | 1647416417-15176-2-git-send-email-kyrie.wu@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | support mt8186 encoder | expand |
On Wed, 2022-03-16 at 15:40 +0800, kyrie.wu wrote: > From: kyrie wu <kyrie.wu@mediatek.com> > > Adds encoder dt-bindings for mt8186. > > Signed-off-by: kyrie wu <kyrie.wu@mediatek.com> > --- > .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 1 > + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec- > encoder.yaml > b/Documentation/devicetree/bindings/media/mediatek,vcodec- > encoder.yaml > index e7b65a91c92c..6d52947f30a5 100644 > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec- > encoder.yaml > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec- > encoder.yaml > @@ -22,6 +22,7 @@ properties: > - mediatek,mt8183-vcodec-enc > - mediatek,mt8192-vcodec-enc > - mediatek,mt8195-vcodec-enc > + - mediatek,mt8186-vcodec-enc > Hello Kyrie, As metioned in v1, I think it's better to move the 8186 below 8183. BRs, Rex > reg: > maxItems: 1
On Wed, 2022-03-16 at 18:41 +0800, Rex-BC Chen wrote: > On Wed, 2022-03-16 at 15:40 +0800, kyrie.wu wrote: > > From: kyrie wu <kyrie.wu@mediatek.com> > > > > Adds encoder dt-bindings for mt8186. > > > > Signed-off-by: kyrie wu <kyrie.wu@mediatek.com> > > --- > > .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | > > 1 > > + > > 1 file changed, 1 insertion(+) > > > > diff --git > > a/Documentation/devicetree/bindings/media/mediatek,vcodec- > > encoder.yaml > > b/Documentation/devicetree/bindings/media/mediatek,vcodec- > > encoder.yaml > > index e7b65a91c92c..6d52947f30a5 100644 > > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec- > > encoder.yaml > > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec- > > encoder.yaml > > @@ -22,6 +22,7 @@ properties: > > - mediatek,mt8183-vcodec-enc > > - mediatek,mt8192-vcodec-enc > > - mediatek,mt8195-vcodec-enc > > + - mediatek,mt8186-vcodec-enc > > > > Hello Kyrie, > > As metioned in v1, I think it's better to move the 8186 below 8183. > > BRs, > Rex > > reg: > > maxItems: 1 > > Hello Kyrie, By the way, I see you re-use 8183 data in v1. I think the binding should be somthing like this: Before you send next patch, make sure you run the binding check. compatible: oneOf: -items: - enum: - mediatek,mt8173-vcodec-enc-vp8 - mediatek,mt8173-vcodec-enc - mediatek,mt8183-vcodec-enc - mediatek,mt8192-vcodec-enc - mediatek,mt8195-vcodec-enc -items: - enum: - mediatek,mt8186-vcodec-enc - const: mediatek,mt8183-vcodec-enc BRs, Rex
diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml index e7b65a91c92c..6d52947f30a5 100644 --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml @@ -22,6 +22,7 @@ properties: - mediatek,mt8183-vcodec-enc - mediatek,mt8192-vcodec-enc - mediatek,mt8195-vcodec-enc + - mediatek,mt8186-vcodec-enc reg: maxItems: 1