From patchwork Thu Apr 14 19:19:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksandr Tyshchenko X-Patchwork-Id: 12818583 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D449AC433EF for ; Fri, 15 Apr 2022 11:27:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Resent-Message-ID:Resent-Date:Resent-CC: Resent-To:Resent-From:Reply-To:Content-ID:Content-Description:Resent-Sender: List-Owner; bh=rtPZ3XuGgIgKdA/N1k9NLlOKTqPI+3IGyiwJJ712CHU=; b=jkM92C0gn7nkP9 fwEPEn2Q5EabVPENb+WKFCGsslYymWGbPvZqIq+qDAIPFVleOIZhFbvKut+9a8YjLQKEC7iugYURr /xMDgOMLWvnLv3j/7bp6CjAIjOO8h+pV8Nc/NwnZOn2immwXuM0UmycR7HikXCFMMUXDk12IZhfUt sLjWbbrb41M50fb9Od8tNbb8bkUbQbt/LesEHmpUhFRZHcZdx3J1HdBCXimrmqwXsskz1sU2fXdKI 5IGSVMTwQKpidBsFV+d5F6fMRxnHV2LIamblRqyPLvXdABV6mRE3LZuBesEfPBkdoNYgPlvaw2eXx 3zf+TNfKBnH4VzciS+dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfK5a-009oyV-BI; Fri, 15 Apr 2022 11:26:10 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfK5U-009owS-1d for linux-arm-kernel@lists.infradead.org; Fri, 15 Apr 2022 11:26:08 +0000 Received: by mail-lf1-x131.google.com with SMTP id o2so13550886lfu.13 for ; Fri, 15 Apr 2022 04:26:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=resent-from:resent-to:resent-cc:resent-date:resent-message-id:from :to:cc:subject:date:message-id:in-reply-to:references; bh=nXDE5bXmpYq/ePRB6NaY2RzAfrYEzRtO2mFypRZiPSg=; b=Eq7PwnM0XleRm5YPsGqg91OHdJc5Bz/QYoNmr8a1zdr97ZFSW21u0AsS3lhKeonB3x HVdJYrNQnjSOWOhewkW4iFO8FLebwzh4uRvKJbJFmLnAjqFXnP7mBmwOO4joggQb65Q5 wckYGbhPA9i1ADbGtw1jKrgSczHEg8xLOhMQ4tmI9D1/HdStmITY3G6zVccDu5+UQDFV f9SJYRunrCNuD7WTgwkQxfzme98rBQ25wEE6uMJvWkThMLME9SkG3GUsul6Uxo7XJgoA MSOeGuYDW3ujH2PnK0n9OOpWIqvQ8VIYgk1g/ENZl5OjCDEdI1w8d3nuC244Q4hP2qkh /xGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:resent-from:resent-to:resent-cc:resent-date :resent-message-id:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nXDE5bXmpYq/ePRB6NaY2RzAfrYEzRtO2mFypRZiPSg=; b=cv0kBlYdP2VTqci9uH38jVocbbuAwJAWFVLDgsVRmr0vwBTtXgXYhD9IKQLcifdA+e wpdbdU4YvAOYLo7AQ6y28grybVjrAalMYAO2SJfUsSt1yft6bCPmv5cSFi7WgQCkofkP ydEViRD89+DVK8dhYmBjfeFn8VuQUGr+L7PzhDs3/6prpLph0buaZLeaWGkIc9c/Ovdf HTe5UhtTUSzhs95X+zhZkLz6xR5rrOM7u5h6HeyO6PyW4ffgi2GdNUxUN2VOA+s0+taT 8j7GIKHEFOlHXg7BofXmAD9OMw1nDekYF0e/EYzWLJ2xwmWO3juW5xCV7Bk03YX2SbCy 1L9g== X-Gm-Message-State: AOAM531Yrg2U7qEJCcgBQmQyThGkEUeOQ+tV2IxcHCKOfK/XsFDmWMJt uHW93qAlxq3EwrwFBeOCiOYMVEh3mAM= X-Google-Smtp-Source: ABdhPJwQUMLDuQmDNQ9duq8PHRInfJALjMJoF+AvpFCI7v8cLXSm2dXjetT5oApLe8iGQOKRvYazvw== X-Received: by 2002:a05:6512:3a85:b0:464:f83e:f680 with SMTP id q5-20020a0565123a8500b00464f83ef680mr4852202lfu.371.1650021960536; Fri, 15 Apr 2022 04:26:00 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id q17-20020a2e8751000000b00244beaacef1sm253479ljj.18.2022.04.15.04.25.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Apr 2022 04:26:00 -0700 (PDT) Resent-From: Oleksandr Resent-To: linux-arm-kernel@lists.infradead.org Resent-CC: Christoph Hellwig , "Michael S. Tsirkin" Resent-Date: Fri, 15 Apr 2022 14:25:59 +0300 Resent-Message-ID: Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id l3-20020a194943000000b0046b928d2795sm85001lfj.67.2022.04.14.12.19.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Apr 2022 12:19:40 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Boris Ostrovsky , Stefano Stabellini , Julien Grall , Oleksandr Tyshchenko Subject: [RFC PATCH 2/6] virtio: add option to restrict memory access under Xen Date: Thu, 14 Apr 2022 22:19:29 +0300 Message-Id: <1649963973-22879-3-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1649963973-22879-1-git-send-email-olekstysh@gmail.com> References: <1649963973-22879-1-git-send-email-olekstysh@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220415_042604_179411_274757D5 X-CRM114-Status: GOOD ( 32.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Juergen Gross In order to support virtio in Xen guests add a config option enabling the user to specify whether in all Xen guests virtio should be able to access memory via Xen grant mappings only on the host side. This applies to fully virtualized guests only, as for paravirtualized guests this is mandatory. This requires to switch arch_has_restricted_virtio_memory_access() from a pure stub to a real function on x86 systems (Arm systems are not covered by now). Add the needed functionality by providing a special set of DMA ops handling the needed grant operations for the I/O pages. Signed-off-by: Juergen Gross --- arch/x86/mm/init.c | 15 ++++ arch/x86/mm/mem_encrypt.c | 5 -- arch/x86/xen/Kconfig | 9 +++ drivers/xen/Kconfig | 20 ++++++ drivers/xen/Makefile | 1 + drivers/xen/xen-virtio.c | 177 ++++++++++++++++++++++++++++++++++++++++++++++ include/xen/xen-ops.h | 8 +++ 7 files changed, 230 insertions(+), 5 deletions(-) create mode 100644 drivers/xen/xen-virtio.c diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index d8cfce2..526a3b2 100644 --- a/arch/x86/mm/init.c +++ b/arch/x86/mm/init.c @@ -8,6 +8,8 @@ #include #include +#include + #include #include #include @@ -1065,3 +1067,16 @@ unsigned long max_swapfile_size(void) return pages; } #endif + +#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS +int arch_has_restricted_virtio_memory_access(void) +{ + if (IS_ENABLED(CONFIG_XEN_PV_VIRTIO) && xen_pv_domain()) + return 1; + if (IS_ENABLED(CONFIG_XEN_HVM_VIRTIO_GRANT) && xen_hvm_domain()) + return 1; + + return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT); +} +EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access); +#endif diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c index 50d2099..dda020f 100644 --- a/arch/x86/mm/mem_encrypt.c +++ b/arch/x86/mm/mem_encrypt.c @@ -77,8 +77,3 @@ void __init mem_encrypt_init(void) print_mem_encrypt_feature_info(); } -int arch_has_restricted_virtio_memory_access(void) -{ - return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT); -} -EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access); diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig index 85246dd..dffdffd 100644 --- a/arch/x86/xen/Kconfig +++ b/arch/x86/xen/Kconfig @@ -92,3 +92,12 @@ config XEN_DOM0 select X86_X2APIC if XEN_PVH && X86_64 help Support running as a Xen Dom0 guest. + +config XEN_PV_VIRTIO + bool "Xen virtio support for PV guests" + depends on XEN_VIRTIO && XEN_PV + default y + help + Support virtio for running as a paravirtualized guest. This will + need support on the backend side (qemu or kernel, depending on the + virtio device types used). diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index 120d32f..fc61f7a 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -335,4 +335,24 @@ config XEN_UNPOPULATED_ALLOC having to balloon out RAM regions in order to obtain physical memory space to create such mappings. +config XEN_VIRTIO + bool "Xen virtio support" + default n + depends on VIRTIO && DMA_OPS + select ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS + help + Enable virtio support for running as Xen guest. Depending on the + guest type this will require special support on the backend side + (qemu or kernel, depending on the virtio device types used). + +config XEN_HVM_VIRTIO_GRANT + bool "Require virtio for fully virtualized guests to use grant mappings" + depends on XEN_VIRTIO && X86_64 + default y + help + Require virtio for fully virtualized guests to use grant mappings. + This will avoid the need to give the backend the right to map all + of the guest memory. This will need support on the backend side + (qemu or kernel, depending on the virtio device types used). + endmenu diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile index 5aae66e..767009c 100644 --- a/drivers/xen/Makefile +++ b/drivers/xen/Makefile @@ -39,3 +39,4 @@ xen-gntalloc-y := gntalloc.o xen-privcmd-y := privcmd.o privcmd-buf.o obj-$(CONFIG_XEN_FRONT_PGDIR_SHBUF) += xen-front-pgdir-shbuf.o obj-$(CONFIG_XEN_UNPOPULATED_ALLOC) += unpopulated-alloc.o +obj-$(CONFIG_XEN_VIRTIO) += xen-virtio.o diff --git a/drivers/xen/xen-virtio.c b/drivers/xen/xen-virtio.c new file mode 100644 index 00000000..cfd5eda --- /dev/null +++ b/drivers/xen/xen-virtio.c @@ -0,0 +1,177 @@ +// SPDX-License-Identifier: GPL-2.0-only +/****************************************************************************** + * Xen virtio driver - enables using virtio devices in Xen guests. + * + * Copyright (c) 2021, Juergen Gross + */ + +#include +#include +#include +#include +#include +#include +#include + +#define XEN_GRANT_ADDR_OFF 0x8000000000000000ULL + +static inline dma_addr_t grant_to_dma(grant_ref_t grant) +{ + return XEN_GRANT_ADDR_OFF | ((dma_addr_t)grant << PAGE_SHIFT); +} + +static inline grant_ref_t dma_to_grant(dma_addr_t dma) +{ + return (grant_ref_t)((dma & ~XEN_GRANT_ADDR_OFF) >> PAGE_SHIFT); +} + +/* + * DMA ops for Xen virtio frontends. + * + * Used to act as a kind of software IOMMU for Xen guests by using grants as + * DMA addresses. + * Such a DMA address is formed by using the grant reference as a frame + * number and setting the highest address bit (this bit is for the backend + * to be able to distinguish it from e.g. a mmio address). + * + * Note that for now we hard wire dom0 to be the backend domain. In order to + * support any domain as backend we'd need to add a way to communicate the + * domid of this backend, e.g. via Xenstore or via the PCI-device's config + * space. + */ +static void *xen_virtio_dma_alloc(struct device *dev, size_t size, + dma_addr_t *dma_handle, gfp_t gfp, + unsigned long attrs) +{ + unsigned int n_pages = PFN_UP(size); + unsigned int i; + unsigned long pfn; + grant_ref_t grant; + void *ret; + + ret = (void *)__get_free_pages(gfp, get_order(size)); + if (!ret) + return NULL; + + pfn = virt_to_pfn(ret); + + if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) { + free_pages((unsigned long)ret, get_order(size)); + return NULL; + } + + for (i = 0; i < n_pages; i++) { + gnttab_grant_foreign_access_ref(grant + i, 0, + pfn_to_gfn(pfn + i), 0); + } + + *dma_handle = grant_to_dma(grant); + + return ret; +} + +static void xen_virtio_dma_free(struct device *dev, size_t size, void *vaddr, + dma_addr_t dma_handle, unsigned long attrs) +{ + unsigned int n_pages = PFN_UP(size); + unsigned int i; + grant_ref_t grant; + + grant = dma_to_grant(dma_handle); + + for (i = 0; i < n_pages; i++) + gnttab_end_foreign_access_ref(grant + i); + + gnttab_free_grant_reference_seq(grant, n_pages); + + free_pages((unsigned long)vaddr, get_order(size)); +} + +static struct page *xen_virtio_dma_alloc_pages(struct device *dev, size_t size, + dma_addr_t *dma_handle, + enum dma_data_direction dir, + gfp_t gfp) +{ + WARN_ONCE(1, "xen_virtio_dma_alloc_pages size %ld\n", size); + return NULL; +} + +static void xen_virtio_dma_free_pages(struct device *dev, size_t size, + struct page *vaddr, dma_addr_t dma_handle, + enum dma_data_direction dir) +{ + WARN_ONCE(1, "xen_virtio_dma_free_pages size %ld\n", size); +} + +static dma_addr_t xen_virtio_dma_map_page(struct device *dev, struct page *page, + unsigned long offset, size_t size, + enum dma_data_direction dir, + unsigned long attrs) +{ + grant_ref_t grant; + + if (gnttab_alloc_grant_references(1, &grant)) + return 0; + + gnttab_grant_foreign_access_ref(grant, 0, xen_page_to_gfn(page), + dir == DMA_TO_DEVICE); + + return grant_to_dma(grant) + offset; +} + +static void xen_virtio_dma_unmap_page(struct device *dev, dma_addr_t dma_handle, + size_t size, enum dma_data_direction dir, + unsigned long attrs) +{ + grant_ref_t grant; + + grant = dma_to_grant(dma_handle); + + gnttab_end_foreign_access_ref(grant); + + gnttab_free_grant_reference(grant); +} + +static int xen_virtio_dma_map_sg(struct device *dev, struct scatterlist *sg, + int nents, enum dma_data_direction dir, + unsigned long attrs) +{ + WARN_ONCE(1, "xen_virtio_dma_map_sg nents %d\n", nents); + return -EINVAL; +} + +static void xen_virtio_dma_unmap_sg(struct device *dev, struct scatterlist *sg, + int nents, enum dma_data_direction dir, + unsigned long attrs) +{ + WARN_ONCE(1, "xen_virtio_dma_unmap_sg nents %d\n", nents); +} + +static int xen_virtio_dma_dma_supported(struct device *dev, u64 mask) +{ + return 1; +} + +static const struct dma_map_ops xen_virtio_dma_ops = { + .alloc = xen_virtio_dma_alloc, + .free = xen_virtio_dma_free, + .alloc_pages = xen_virtio_dma_alloc_pages, + .free_pages = xen_virtio_dma_free_pages, + .mmap = dma_common_mmap, + .get_sgtable = dma_common_get_sgtable, + .map_page = xen_virtio_dma_map_page, + .unmap_page = xen_virtio_dma_unmap_page, + .map_sg = xen_virtio_dma_map_sg, + .unmap_sg = xen_virtio_dma_unmap_sg, + .dma_supported = xen_virtio_dma_dma_supported, +}; + +void xen_virtio_setup_dma_ops(struct device *dev) +{ + dev->dma_ops = &xen_virtio_dma_ops; +} +EXPORT_SYMBOL_GPL(xen_virtio_setup_dma_ops); + +MODULE_DESCRIPTION("Xen virtio support driver"); +MODULE_AUTHOR("Juergen Gross "); +MODULE_LICENSE("GPL"); diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h index a3584a3..ae3c1bc 100644 --- a/include/xen/xen-ops.h +++ b/include/xen/xen-ops.h @@ -221,4 +221,12 @@ static inline void xen_preemptible_hcall_end(void) { } #endif /* CONFIG_XEN_PV && !CONFIG_PREEMPTION */ +#ifdef CONFIG_XEN_VIRTIO +void xen_virtio_setup_dma_ops(struct device *dev); +#else +static inline void xen_virtio_setup_dma_ops(struct device *dev) +{ +} +#endif /* CONFIG_XEN_VIRTIO */ + #endif /* INCLUDE_XEN_OPS_H */