| Message ID | 1669958.qjJ7i3NBPv@wasted.cogentembedded.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jun 01, 2016 at 01:33:49AM +0300, Sergei Shtylyov wrote: > R8A7792 SoC doesn't have the EtherMAC core, so SMSC LAN89218 Ethernet > chip was used instead on the Blanche board; this chip is compatible with > SMSC LAN9115 for which there's a (device tree aware) driver. Describe > the chip in the Blanche device tree; enable DHCP and NFS root in the > kernel command line for the kernel booting. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> At this time I do not have access to documentation or hardware for this board. So I am relying on you to test this and make sure it complies with the spec. What you have looks reasonable to me: Acked-by: Simon Horman <horms+renesas@verge.net.au>
Hi Sergei, On Wed, Jun 1, 2016 at 12:33 AM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > --- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts > +++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts > + ethernet@18000000 { > + compatible = "smsc,lan89218", "smsc,lan9115"; The "smsc,lan89218" needs to be documented in the device tree bindings. Google couldn't find any evidence you submitted a patch for that. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hello. On 6/1/2016 11:22 AM, Geert Uytterhoeven wrote: >> --- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts >> +++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts > >> + ethernet@18000000 { >> + compatible = "smsc,lan89218", "smsc,lan9115"; > > The "smsc,lan89218" needs to be documented in the device tree bindings. Have you looked at those bindings? > Google couldn't find any evidence you submitted a patch for that. Because the bindings document *any* LAN9115 compatible chip already. > Gr{oetje,eeting}s, > > Geert MBR, Sergei
Hi Sergei, On Wed, Jun 1, 2016 at 2:16 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > On 6/1/2016 11:22 AM, Geert Uytterhoeven wrote: >>> --- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts >>> +++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts >> >>> + ethernet@18000000 { >>> + compatible = "smsc,lan89218", "smsc,lan9115"; >> >> >> The "smsc,lan89218" needs to be documented in the device tree bindings. > > Have you looked at those bindings? Now I did. >> Google couldn't find any evidence you submitted a patch for that. > > Because the bindings document *any* LAN9115 compatible chip already. Ah, generic wildcard, not listing valid values. Hence checkpatch complained... Google predict-while-you-type suggests "lan89218aq"? Should you use that? BTW, that's why we always want to document all valid values... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 06/01/2016 03:27 PM, Geert Uytterhoeven wrote: >>>> --- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts >>>> +++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts >>> >>>> + ethernet@18000000 { >>>> + compatible = "smsc,lan89218", "smsc,lan9115"; >>> >>> >>> The "smsc,lan89218" needs to be documented in the device tree bindings. >> >> Have you looked at those bindings? > > Now I did. > >>> Google couldn't find any evidence you submitted a patch for that. >> >> Because the bindings document *any* LAN9115 compatible chip already. > > Ah, generic wildcard, not listing valid values. Hence checkpatch complained... Note that it doesn't complain about "smsc,lan9220" though that is only mentioned in the example. > Google predict-while-you-type suggests "lan89218aq"? Should you use that? No, my googling shows that the suffix can be different, and the Microchip (the new owner?) has it without the suffix on their site. > BTW, that's why we always want to document all valid values... > Gr{oetje,eeting}s, > > Geert MBR, Sergei
Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts +++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts @@ -21,7 +21,7 @@ }; chosen { - bootargs = "ignore_loglevel"; + bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp"; stdout-path = "serial0:115200n8"; }; @@ -29,6 +29,27 @@ device_type = "memory"; reg = <0 0x40000000 0 0x40000000>; }; + + d3_3v: regulator-3v3 { + compatible = "regulator-fixed"; + regulator-name = "D3.3V"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + + ethernet@18000000 { + compatible = "smsc,lan89218", "smsc,lan9115"; + reg = <0 0x18000000 0 0x100>; + phy-mode = "mii"; + interrupt-parent = <&irqc>; + interrupts = <0 IRQ_TYPE_EDGE_FALLING>; + smsc,irq-push-pull; + reg-io-width = <4>; + vddvario-supply = <&d3_3v>; + vdd33a-supply = <&d3_3v>; + }; }; &extal_clk {
R8A7792 SoC doesn't have the EtherMAC core, so SMSC LAN89218 Ethernet chip was used instead on the Blanche board; this chip is compatible with SMSC LAN9115 for which there's a (device tree aware) driver. Describe the chip in the Blanche device tree; enable DHCP and NFS root in the kernel command line for the kernel booting. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- arch/arm/boot/dts/r8a7792-blanche.dts | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-)