From patchwork Fri Sep 29 21:44:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 9978735 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3FEE260329 for ; Fri, 29 Sep 2017 21:45:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2E5BB298C9 for ; Fri, 29 Sep 2017 21:45:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2C374298D5; Fri, 29 Sep 2017 21:45:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B8240298C9 for ; Fri, 29 Sep 2017 21:45:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:Subject:From:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8Bty36yWhwkV9skTA/4vKJlot4Y1iHF4UvheDtC2Y9s=; b=eox0uF7K6YdPML HIrpGu3xgeFi0g032rTmM4CjwdWgn6TSbJl0jbZBK/pMdHUbeGBMbGmDrM0GOL3O2Rr4eOtWnrqHj NLeBDxpYwtDk9/GsWAQjnYz7leT0GLz+53YZaeBGOZ81IqpoXnNEYsh74p76vJ2aGJ60RjIudPcBU tH3KMFu/TzqjF/x0YDEZI283jeJIxGP9YTH6ndGlsezLidnWDwCp82ZFGfLmIpVjOeLU9YJ8IMhLv AFbYOPFRFwHsyrxSRzDsaTBwDlgkqCDxRh6rgU51YDcn1pR8IvvhD+h6fwjS01DDPj/Qrj/eyslcg ThlZAEUrrUJg5/gjckqQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dy35V-0000GB-I0; Fri, 29 Sep 2017 21:44:49 +0000 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dy35R-0000DQ-1l for linux-arm-kernel@lists.infradead.org; Fri, 29 Sep 2017 21:44:46 +0000 Received: by mail-wm0-x242.google.com with SMTP id b189so495665wmd.2 for ; Fri, 29 Sep 2017 14:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=LTuKy1Xwd8mtvu3VuafgSNgW+gXj7XLoyvKnIT7Ra3o=; b=CU9+qJ7+Zzrg3dS1g8NzFYVM4ekj3dd+Gfn8GfjpAvyqeCVm4m5YEEKTzeY0QeyIfe RXa4Plm1oq/lBwVgoNBQXwoDqQPY2oBdR9QORbqBJ1goBb4yPajfXQCRmeqAmk6IH7fI 2mAToJo4cTCKBv3tIK1fyuhRQIQZk49/yK6MgFjWeSQIbQmb6NwXCKQp0TzyRPW1zRbA dyhZGwVmFM7P9V/lD8SCZhieBmNPppPWjNorznzfR+tS/gqXbQmMyv1Uu+NyPDZSmfrv egDaAl9pViEORiy/0p+Rb79pFh8gMRkbM0R0l46S985mNayxmH3IeV+ZyMoHRtuHQ1sk pRcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=LTuKy1Xwd8mtvu3VuafgSNgW+gXj7XLoyvKnIT7Ra3o=; b=EgGD8ppwrlX6qAal/u0qCH6rapkqAuBfbqATLB2FcNQTuN5pYB6RyipTv+sPjq27tu Hy0JEuuQPzcdXLiXP3LdT9VEQBMVU6C1QwsQsFCejFLFciNc0AStulJm4dbMfTwZenW0 OZf+Su0iQkxg3tzz7sVkIOLBsDXuBWu+VTimWPLFTtfI3hIC5MnS2Y3jW13YGWZBgqiC 14EgsKbw4bHImqgAbTK80KbHoekmb7gS5SCwQvm8t1JrhuXWr/ZzQbVOauDS3xvGVxKl pqXDgdnhiicH3CVsG4ik/zlS87leRDeyC7nHirHPDcvd3zTnZ4rajXMnf/bgbP29Jl1k B+Mg== X-Gm-Message-State: AHPjjUi84jA2iFz8M2YXBA5Sk9/BGJbIGqJnL1VcEpfdqTm7xVkO7x+V n+MYPd63hzpdVsdYJHe696kIjw== X-Google-Smtp-Source: AOwi7QCwfn2JsLpAvbIPUKMxs8zweV/035xB5Io99oqZyNfGbYdZN+Kc8WWpMZ9X0l9PSVvHvFOnhg== X-Received: by 10.80.143.98 with SMTP id 89mr11233212edy.273.1506721462380; Fri, 29 Sep 2017 14:44:22 -0700 (PDT) Received: from ?IPv6:2003:ea:8bcb:c500:506a:6c9b:118a:c899? (p200300EA8BCBC500506A6C9B118AC899.dip0.t-ipconnect.de. [2003:ea:8bcb:c500:506a:6c9b:118a:c899]) by smtp.googlemail.com with ESMTPSA id z102sm4610327ede.85.2017.09.29.14.44.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Sep 2017 14:44:21 -0700 (PDT) From: Heiner Kallweit Subject: [PATCH 2/5] firmware: arm_scpi: remove two unneeded devm_kfree's in scpi_remove To: Sudeep Holla References: Message-ID: <16d143b8-b8a9-d456-dd38-84131e3a5bd9@gmail.com> Date: Fri, 29 Sep 2017 23:44:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170929_144445_274767_80C593DB X-CRM114-Status: UNSURE ( 9.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Both memory areas are free'd anyway when the device is destroyed, so we don't have to do it manually. Signed-off-by: Heiner Kallweit --- drivers/firmware/arm_scpi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c index c942761e..d80d11ae 100644 --- a/drivers/firmware/arm_scpi.c +++ b/drivers/firmware/arm_scpi.c @@ -914,8 +914,6 @@ static int scpi_remove(struct platform_device *pdev) kfree(scpi_info->dvfs[i]->opps); kfree(scpi_info->dvfs[i]); } - devm_kfree(dev, scpi_info->channels); - devm_kfree(dev, scpi_info); return 0; }