From patchwork Mon Dec 18 07:06:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lai Peter Jun Ann X-Patchwork-Id: 13496309 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52C99C35274 for ; Mon, 18 Dec 2023 07:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=kQtGj02hp28EoghlTair1pJ9qD4YxTC561OraIDosOk=; b=kTq7UV+eYQKgf8 tl7lAzthnCeXqPe/690bwe6CbgiUKdsfW+2C3DncuSmqQ01Ry0a0ICrA85DWExqVpCURy8NXmhMxf bT77610x9nBKACyL5+XAc1v8XOpTwWPsYDi1GN4amDwd2yDf3+OY3YcJRgy5JHKEW73d89Nxuh2aR V2AuU1HxBoT3+wIcTB9RgOgmRrLDAV9ao5G24avWy77/I0qpzCS4DomslbFFY0FTuaFd1wHuzel6p t5aMQFT4+oE273Enjc3f1w/esR6TXihq0O079A7gYSxmHu4Ipfwk44InvBYo3QrYY7gequWaSjmAP JpDPF3GL71bBFvEnsNAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rF7k4-009JI0-1e; Mon, 18 Dec 2023 07:08:44 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rF7k3-009JHs-0K for linux-arm-kernel@bombadil.infradead.org; Mon, 18 Dec 2023 07:08:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To:References; bh=wSkzG5L8tuK8c31NPJBGB49Eub/aBHZOyHjz8Pli3Kc=; b=niT3833vRcC0fVb58u/pY8+wD4 zqsa6ihLp5XKRLeQIswujb6WdHPqSN2hXO8FP6QSnECwlmX7D9GtbhLDjtXFZHORf14FbDwtLmEKY T2nm0H6eQ97/u21dsbMnwMy6mTpbWjSn/nhUd2LOEldOADyUYK96lO6aWe//psB1IV8OuXw2AtrDw L0+cetFpuclwKj5ZmXngIbDTC2GDU7HPax2/w58MHk9WVTlaJKKucpPaEUQzDbf8cmaYxqZGM5VF9 K7hdaSuu5sE5AM2zRXKJ8qbIlnFoyORV4q50WPfQcjMDLuYL2OI7LdrWPvrrapftxDcJMQ9Wxwx6Z pQxnj8Mw==; Received: from mgamail.intel.com ([198.175.65.13]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rF7iO-00D6BR-2q for linux-arm-kernel@lists.infradead.org; Mon, 18 Dec 2023 07:08:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702883221; x=1734419221; h=from:to:cc:subject:date:message-id; bh=RiZsRpMsjJgcAKI9/RPFJRFk2jM24l/0sJABnqjwbyw=; b=C0NmYUdAmG0Vo2CHhChXI0fp5PflZJw+yh1WVmjrDDr+iN3LpIbm/b9f ga5Tzd03gb41hr9bUFXMOjAjo2cHdSaTIOC1m4gv98ffN29tFZIIGYQCV TvR+hCzrh9XU/GzkDAZq0zf64BooCwngiaSzZXx/fEbdDFCE0uuAPgvxH 6MzbkO7qU7UfaHPcUPJHEV9XM4AJPEMDha+ISAM/qNElw/6SBAqLiGZvM lcHn2s0wKw5L+wfxu4nia+bzkRg747xfu6lq+x9AxpzhxW+/B61dQdnOo daL5rGM3BQ4nTxYfc42VfjUka6pBh0V5hb4sAJOtGY4dQ/oX0g+xN/YsU Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10927"; a="2555119" X-IronPort-AV: E=Sophos;i="6.04,284,1695711600"; d="scan'208";a="2555119" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2023 23:06:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10927"; a="845843049" X-IronPort-AV: E=Sophos;i="6.04,284,1695711600"; d="scan'208";a="845843049" Received: from ssid-ilbpg3.png.intel.com ([10.88.227.111]) by fmsmga004.fm.intel.com with ESMTP; 17 Dec 2023 23:06:45 -0800 From: Lai Peter Jun Ann To: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Song Yoong Siang , Lai Peter Jun Ann Subject: [PATCH net 1/1] net: stmmac: fix incorrect flag check in timestamp interrupt Date: Mon, 18 Dec 2023 15:06:41 +0800 Message-Id: <1702883201-29632-1-git-send-email-jun.ann.lai@intel.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_070702_020311_7FE73A28 X-CRM114-Status: GOOD ( 11.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The driver should continue get the timestamp if STMMAC_FLAG_EXT_SNAPSHOT_EN flag is set. Signed-off-by: Song Yoong Siang Signed-off-by: Lai Peter Jun Ann --- drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c index 540f6a4..f05bd75 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c @@ -237,7 +237,7 @@ static void timestamp_interrupt(struct stmmac_priv *priv) */ ts_status = readl(priv->ioaddr + GMAC_TIMESTAMP_STATUS); - if (priv->plat->flags & STMMAC_FLAG_EXT_SNAPSHOT_EN) + if (!(priv->plat->flags & STMMAC_FLAG_EXT_SNAPSHOT_EN)) return; num_snapshot = (ts_status & GMAC_TIMESTAMP_ATSNS_MASK) >>