| Message ID | 1709017406-12624-1-git-send-email-shengjiu.wang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] arm64: dts: imx8mp-evk: Add HDMI audio sound card support | expand |
Hi, Am Dienstag, 27. Februar 2024, 08:03:25 CET schrieb Shengjiu Wang: > The AUD2HTX is a digital module that provides a bridge between > the Audio Subsystem and the HDMI RTX Subsystem. This > module includes intermediate storage to queue SDMA transactions > prior to being synchronized and passed to the HDMI > RTX Subsystem over the Audio Link. > > AUD2HTX works as the cpu dai in HDMI audio sound card. > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > --- > > changes in v2: > - remove 'status' in sound-hdmi > > arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 11 +++++++++++ > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 10 ++++++++++ Maybe split this patch into two: * adding aud2htx node * enabling board support > 2 files changed, 21 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > index f87fa5a948cc..0fc6c0d21cd6 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > @@ -138,6 +138,13 @@ simple-audio-card,codec { > > }; > > + sound-hdmi { > + compatible = "fsl,imx-audio-hdmi"; > + model = "audio-hdmi"; > + audio-cpu = <&aud2htx>; > + hdmi-out; > + }; > + > reserved-memory { > #address-cells = <2>; > #size-cells = <2>; > @@ -191,6 +198,10 @@ &A53_3 { > cpu-supply = <®_arm>; > }; > > +&aud2htx { > + status = "okay"; > +}; > + > &eqos { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_eqos>; This part looks good: Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 9ab9c057f41e..721ab630d895 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1513,6 +1513,16 @@ micfil: audio-controller@30ca0000 { > status = "disabled"; > }; > > + aud2htx: aud2htx@30cb0000 { > + compatible = "fsl,imx8mp-aud2htx"; > + reg = <0x30cb0000 0x10000>; > + interrupts = <GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_AUD2HTX_IPG>; > + clock-names = "bus"; > + dmas = <&sdma2 26 2 0>; > + dma-names = "tx"; > + status = "disabled"; > + }; My WIP has the same node: Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com> > }; > > sdma3: dma-controller@30e00000 { >
On Tue, Feb 27, 2024 at 3:49 PM Alexander Stein <alexander.stein@ew.tq-group.com> wrote: > > Hi, > > Am Dienstag, 27. Februar 2024, 08:03:25 CET schrieb Shengjiu Wang: > > The AUD2HTX is a digital module that provides a bridge between > > the Audio Subsystem and the HDMI RTX Subsystem. This > > module includes intermediate storage to queue SDMA transactions > > prior to being synchronized and passed to the HDMI > > RTX Subsystem over the Audio Link. > > > > AUD2HTX works as the cpu dai in HDMI audio sound card. > > > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > > --- > > > > changes in v2: > > - remove 'status' in sound-hdmi > > > > arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 11 +++++++++++ > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 10 ++++++++++ > > Maybe split this patch into two: > * adding aud2htx node > * enabling board support ok, will update. Best regards Shengjiu Wang > > > 2 files changed, 21 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > > index f87fa5a948cc..0fc6c0d21cd6 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > > @@ -138,6 +138,13 @@ simple-audio-card,codec { > > > > }; > > > > + sound-hdmi { > > + compatible = "fsl,imx-audio-hdmi"; > > + model = "audio-hdmi"; > > + audio-cpu = <&aud2htx>; > > + hdmi-out; > > + }; > > + > > reserved-memory { > > #address-cells = <2>; > > #size-cells = <2>; > > @@ -191,6 +198,10 @@ &A53_3 { > > cpu-supply = <®_arm>; > > }; > > > > +&aud2htx { > > + status = "okay"; > > +}; > > + > > &eqos { > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_eqos>; > > This part looks good: > Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > index 9ab9c057f41e..721ab630d895 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > @@ -1513,6 +1513,16 @@ micfil: audio-controller@30ca0000 { > > status = "disabled"; > > }; > > > > + aud2htx: aud2htx@30cb0000 { > > + compatible = "fsl,imx8mp-aud2htx"; > > + reg = <0x30cb0000 0x10000>; > > + interrupts = <GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_AUD2HTX_IPG>; > > + clock-names = "bus"; > > + dmas = <&sdma2 26 2 0>; > > + dma-names = "tx"; > > + status = "disabled"; > > + }; > > My WIP has the same node: > Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > }; > > > > sdma3: dma-controller@30e00000 { > > > > > -- > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany > Amtsgericht München, HRB 105018 > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider > http://www.tq-group.com/ > >
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts index f87fa5a948cc..0fc6c0d21cd6 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts @@ -138,6 +138,13 @@ simple-audio-card,codec { }; + sound-hdmi { + compatible = "fsl,imx-audio-hdmi"; + model = "audio-hdmi"; + audio-cpu = <&aud2htx>; + hdmi-out; + }; + reserved-memory { #address-cells = <2>; #size-cells = <2>; @@ -191,6 +198,10 @@ &A53_3 { cpu-supply = <®_arm>; }; +&aud2htx { + status = "okay"; +}; + &eqos { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_eqos>; diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index 9ab9c057f41e..721ab630d895 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -1513,6 +1513,16 @@ micfil: audio-controller@30ca0000 { status = "disabled"; }; + aud2htx: aud2htx@30cb0000 { + compatible = "fsl,imx8mp-aud2htx"; + reg = <0x30cb0000 0x10000>; + interrupts = <GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_AUD2HTX_IPG>; + clock-names = "bus"; + dmas = <&sdma2 26 2 0>; + dma-names = "tx"; + status = "disabled"; + }; }; sdma3: dma-controller@30e00000 {
The AUD2HTX is a digital module that provides a bridge between the Audio Subsystem and the HDMI RTX Subsystem. This module includes intermediate storage to queue SDMA transactions prior to being synchronized and passed to the HDMI RTX Subsystem over the Audio Link. AUD2HTX works as the cpu dai in HDMI audio sound card. Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> --- changes in v2: - remove 'status' in sound-hdmi arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 11 +++++++++++ arch/arm64/boot/dts/freescale/imx8mp.dtsi | 10 ++++++++++ 2 files changed, 21 insertions(+)