diff mbox series

[net-next,v2,4/4] net: axienet: remove unnecessary parentheses

Message ID 1722417367-4113948-5-git-send-email-radhey.shyam.pandey@amd.com (mailing list archive)
State New, archived
Headers show
Series net: axienet: Fix coding style issues | expand

Commit Message

Radhey Shyam Pandey July 31, 2024, 9:16 a.m. UTC 
Remove unnecessary parentheses around 'ndev->mtu
<= XAE_JUMBO_MTU' and 'ndev->mtu > XAE_MTU'. Reported
by checkpatch.

CHECK: Unnecessary parentheses around 'ndev->mtu > XAE_MTU'
+       if ((ndev->mtu > XAE_MTU) &&
+           (ndev->mtu <= XAE_JUMBO_MTU)) {

CHECK: Unnecessary parentheses around 'ndev->mtu <= XAE_JUMBO_MTU'
+       if ((ndev->mtu > XAE_MTU) &&
+           (ndev->mtu <= XAE_JUMBO_MTU)) {

Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
---
Changes for v2:
- Split each coding style change into separate patch.
---
 drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Andrew Lunn July 31, 2024, 12:06 p.m. UTC | #1 
On Wed, Jul 31, 2024 at 02:46:07PM +0530, Radhey Shyam Pandey wrote:
> Remove unnecessary parentheses around 'ndev->mtu
> <= XAE_JUMBO_MTU' and 'ndev->mtu > XAE_MTU'. Reported
> by checkpatch.
> 
> CHECK: Unnecessary parentheses around 'ndev->mtu > XAE_MTU'
> +       if ((ndev->mtu > XAE_MTU) &&
> +           (ndev->mtu <= XAE_JUMBO_MTU)) {
> 
> CHECK: Unnecessary parentheses around 'ndev->mtu <= XAE_JUMBO_MTU'
> +       if ((ndev->mtu > XAE_MTU) &&
> +           (ndev->mtu <= XAE_JUMBO_MTU)) {
> 
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
diff mbox series

Patch

diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index f8381a56eae6..937d02a819d8 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -614,8 +614,7 @@  static int axienet_device_reset(struct net_device *ndev)
 	lp->options |= XAE_OPTION_VLAN;
 	lp->options &= (~XAE_OPTION_JUMBO);
 
-	if ((ndev->mtu > XAE_MTU) &&
-	    (ndev->mtu <= XAE_JUMBO_MTU)) {
+	if (ndev->mtu > XAE_MTU && ndev->mtu <= XAE_JUMBO_MTU) {
 		lp->max_frm_size = ndev->mtu + VLAN_ETH_HLEN +
 					XAE_TRL_SIZE;