From patchwork Wed Nov 29 09:13:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Young X-Patchwork-Id: 13472486 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7EB5C46CA3 for ; Wed, 29 Nov 2023 09:14:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XpW7SEUWuUeGSUJsLAu/keKQWSmTc9puIa7emBPEQgY=; b=yp3uxHHOif834/ 8DtkYAem2hFzn5yfexwe4fjetKwCHaxxA5iEBRsH5XIqPlzcrZRyTb1YK1UPdYNwzJPskEQYy1c2k zy4SBeZld3q5bDM9ApQoCizw7iLHCAVYyFvJUnn8TC3D6sA8nPu9Wxj5JvkRBYsJ1tHS8hA0Zr+Av tyyIIsZZdeVbkHVKOXnXxFbBnP69FGyOfpkmGJkCzb2NGlg5LD8VmtUPNczZN1x72y203iKERVoD3 aewuOz6n3YRHwmmMNsGJWMo/dNqafeTnKBt3acjoEkXBvn0v3dPMpfDiwawWCA2PbH9cUD4DnbhfC n9T+FqXM6eGf6xzQZcUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8Ge8-007abL-11; Wed, 29 Nov 2023 09:14:16 +0000 Received: from gofer.mess.org ([2a02:8011:d000:212::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8Gdz-007aW3-3A; Wed, 29 Nov 2023 09:14:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mess.org; s=2020; t=1701249246; bh=GDt/QGFqEdFRkVDZgETPHCj6Jv9POqOqoTfpWoZLvRY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TWjkWGQGwUVPvlYuBEcwd8lB92At5vuS+GSuK4tUV6j3voS4I+qBYtXxWTz5ftuOD pjDCXBMg6fZs2koxHjUnEtuAk7UUKpp/4oiQE6w1CouaHWphI41pSEc1afmrjqExK1 DEo0VAoArDELccknbNm/KoK/TGYz7OORnrcC0NcVn/3ahwzQ4nnZBuPVRoqw8E3FXj YNdUdvLeLtKlww+YqjxQbgsDRa6M4v7B/aGC2ugyGSIy+FyLxfi5KWwLhCi340Ll3k BFb9xT9dv9HVeO6ihWoARTcbgMoIDBedgqSKyUbsg55MNJK8b3dDUyb4ckjmR7W0cQ yI8zINehSpNRw== Received: by gofer.mess.org (Postfix, from userid 501) id B81C6100100; Wed, 29 Nov 2023 09:14:06 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mess.org; s=2020; t=1701249229; bh=GDt/QGFqEdFRkVDZgETPHCj6Jv9POqOqoTfpWoZLvRY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HZqr3Bk07ZBh1TRRzsBJ3LgIh08ANfvAMRdGG3FuykyEvfE4w7BXktSqJKsP7UMLD kjfzaH7uM0BlNWPQuBXRLKAKfc+Cbzgdj0ywskPQsajoOu6SD0eTaEQe7wnunRxXqw brvA3SUE0eXFRXNBUjt+plaCy+58GmBy0Q9IH8aVNiveAilEtBnAVSoiAkDCxR4s3Q BR75PFAIDjXVMvLnvop57oIlOl7A4780cJeg71BPXSq34BDM2hIzgW3DbhTHcl8Ifk hq2HkyeLxjrpUXeoBc7DtaS31j+iZmJZ8XVLxSz3OxnEOvNivOg2hmp+rebjAfduD9 9KfTRtDJw8cGg== Received: from localhost.localdomain (bigcore-99.local [IPv6:2a02:8011:d000:212:ca7f:54ff:fe51:14d6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by gofer.mess.org (Postfix) with ESMTPSA id 49223100101; Wed, 29 Nov 2023 09:13:49 +0000 (GMT) From: Sean Young To: linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, Ivaylo Dimitrov , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden Cc: Sean Young , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 3/4] pwm: bcm2835: allow pwm driver to be used in atomic context Date: Wed, 29 Nov 2023 09:13:36 +0000 Message-ID: <179dc1ce85702a8b64b43c0e0df656b0c5e3ce30.1701248996.git.sean@mess.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_011408_168557_9031956F X-CRM114-Status: GOOD ( 16.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org clk_get_rate() may do a mutex lock. Fetch the clock rate once, and prevent rate changes using clk_rate_exclusive_get(). Signed-off-by: Sean Young Reviewed-by: Florian Fainelli --- drivers/pwm/pwm-bcm2835.c | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/pwm/pwm-bcm2835.c b/drivers/pwm/pwm-bcm2835.c index 9777babd5b95..52748194a3da 100644 --- a/drivers/pwm/pwm-bcm2835.c +++ b/drivers/pwm/pwm-bcm2835.c @@ -28,6 +28,7 @@ struct bcm2835_pwm { struct device *dev; void __iomem *base; struct clk *clk; + unsigned long rate; }; static inline struct bcm2835_pwm *to_bcm2835_pwm(struct pwm_chip *chip) @@ -63,17 +64,11 @@ static int bcm2835_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, { struct bcm2835_pwm *pc = to_bcm2835_pwm(chip); - unsigned long rate = clk_get_rate(pc->clk); unsigned long long period_cycles; u64 max_period; u32 val; - if (!rate) { - dev_err(pc->dev, "failed to get clock rate\n"); - return -EINVAL; - } - /* * period_cycles must be a 32 bit value, so period * rate / NSEC_PER_SEC * must be <= U32_MAX. As U32_MAX * NSEC_PER_SEC < U64_MAX the @@ -88,13 +83,13 @@ static int bcm2835_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, * <=> period < ((U32_MAX * NSEC_PER_SEC + NSEC_PER_SEC/2) / rate * <=> period <= ceil((U32_MAX * NSEC_PER_SEC + NSEC_PER_SEC/2) / rate) - 1 */ - max_period = DIV_ROUND_UP_ULL((u64)U32_MAX * NSEC_PER_SEC + NSEC_PER_SEC / 2, rate) - 1; + max_period = DIV_ROUND_UP_ULL((u64)U32_MAX * NSEC_PER_SEC + NSEC_PER_SEC / 2, pc->rate) - 1; if (state->period > max_period) return -EINVAL; /* set period */ - period_cycles = DIV_ROUND_CLOSEST_ULL(state->period * rate, NSEC_PER_SEC); + period_cycles = DIV_ROUND_CLOSEST_ULL(state->period * pc->rate, NSEC_PER_SEC); /* don't accept a period that is too small */ if (period_cycles < PERIOD_MIN) @@ -103,7 +98,7 @@ static int bcm2835_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, writel(period_cycles, pc->base + PERIOD(pwm->hwpwm)); /* set duty cycle */ - val = DIV_ROUND_CLOSEST_ULL(state->duty_cycle * rate, NSEC_PER_SEC); + val = DIV_ROUND_CLOSEST_ULL(state->duty_cycle * pc->rate, NSEC_PER_SEC); writel(val, pc->base + DUTY(pwm->hwpwm)); /* set polarity */ @@ -151,14 +146,29 @@ static int bcm2835_pwm_probe(struct platform_device *pdev) return dev_err_probe(&pdev->dev, PTR_ERR(pc->clk), "clock not found\n"); + ret = clk_rate_exclusive_get(pc->clk); + if (ret) + return dev_err_probe(&pdev->dev, ret, + "fail to get exclusive rate\n"); + + pc->rate = clk_get_rate(pc->clk); + if (!pc->rate) { + clk_rate_exclusive_put(pc->clk); + return dev_err_probe(&pdev->dev, -EINVAL, + "failed to get clock rate\n"); + } + pc->chip.dev = &pdev->dev; pc->chip.ops = &bcm2835_pwm_ops; + pc->chip.atomic = true; pc->chip.npwm = 2; ret = devm_pwmchip_add(&pdev->dev, &pc->chip); - if (ret < 0) + if (ret < 0) { + clk_rate_exclusive_put(pc->clk); return dev_err_probe(&pdev->dev, ret, "failed to add pwmchip\n"); + } return 0; } @@ -167,6 +177,7 @@ static int bcm2835_pwm_suspend(struct device *dev) { struct bcm2835_pwm *pc = dev_get_drvdata(dev); + clk_rate_exclusive_put(pc->clk); clk_disable_unprepare(pc->clk); return 0;