From patchwork Wed Jun 12 11:14:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 10989489 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 50B8F6C5 for ; Wed, 12 Jun 2019 11:16:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C1B91FF87 for ; Wed, 12 Jun 2019 11:16:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2FF2E28A2E; Wed, 12 Jun 2019 11:16:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B013A28A2D for ; Wed, 12 Jun 2019 11:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=339CYgs/GB54ZA5noSRLmi/hWSGKOf2TxuEIf7ODFmY=; b=qnqcKcxWlDoVJVj6fnwW2egFFr KpsZP/iFBKTLO3flN32w46uSVWUZpsvoJMoRMsUrZpuYVHpPfNIICv+9/zQqiNC3qIFIlvfvgjt8J xAdV0rSkNeLcirCLHcZuzroTDilwiFW7Oyz8MGyEKxse6AOUgBQ74JYcPWkzDQtM3ppymPpcTEoxQ tEarbYXHDGmnHb0B99h5xQY4fGY53wlvdq8Z5gyv1ySSLPR7EVXbI2clMEpYWYaZLdPCXBY4HOAog WD0eeMc2F22VHspph1sbOBNgh/bb/sWCHPZFv/5TYb41v3E8nyDh/EIpXkRbpjW23K5Q3l0/SAog5 wCGYl6Ig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hb1FB-0000mP-2S; Wed, 12 Jun 2019 11:16:41 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hb1DY-0006Fg-Bg for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2019 11:15:02 +0000 Received: by mail-wm1-x342.google.com with SMTP id a15so6118180wmj.5 for ; Wed, 12 Jun 2019 04:14:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=N7TfMirow0WLkJ8Qk5sTGDNuiXjkVvo5PhKfS+WN4/0=; b=TvHkcos3aVvBmtDnRVLiF8pREYuprtIOehZYrLYdAyjZP7EdbPz6anRT6UL2bn+1lt iRSNcVbOmYQ+kkQ3JbVs1+N1QXgzSkLX7YOg4L2t2XY70f8q+rjIVRsJ4twJwhJN5UVZ 5vJXv8Lim0Z9xob8xQk0ZvGfB+Z70kXkXVtj9Vo9sPNZX6nj6jRDgEYn1CZRGWviaBdS 8d2kZlRPWm/+iACF30dR/3uZm/5FVD9NxZ0mvNShAZQiO33Rxhr5EDslpWhYAWS2n20q sZ86aP63QHnIW66uQRUQxsSNaaLrpUhja+T3uqyEQLfK6EbRGrP9SJ6Yvc6TpIiuxChN 7asQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:in-reply-to:references; bh=N7TfMirow0WLkJ8Qk5sTGDNuiXjkVvo5PhKfS+WN4/0=; b=pMiIYfQ296067pumwetXYVbAbEOQ1Lb/u0ReP9ms3sdyLaqd6B9+d9sdO520QfwQ2K vtkP77Djix9r1xOTZiHRoSFX+QbfFUyYlfycL46vXvGkdIWofncGLqAjjjkcycaRzJ2E se0vAYuPgUsQGfhmWvaYf7JCBHZQNgky5h0BIb06lIW3nPAMf+u87iBSAwj76k/qIPjF AmRboH3RfT1kNAW/L0PrugwJ9jS6Rs8yRYDlM6wlTaSgdf+Vg3SCB4r2m6OV11wJgbQx BMGSvtVKzpv1852BPvg4IEP44y2kjtX2lqovV9By1GBQWdJyqQH2wjcPI5PI1yJY2vXY bh5A== X-Gm-Message-State: APjAAAXiqT29rTiabRltw9xaj/d9TT1x6nykVKQaI75xNX6sl/XjABfZ Hlds9+9H5e4Jb6VtR8fYw0jamg== X-Google-Smtp-Source: APXvYqxDqteBduXIGovJOsGxQCU7BEXqUQmBQgzI25tvhIXaofsgXxbwQoEvBU7rTYV1bD0qZFpatw== X-Received: by 2002:a1c:1b81:: with SMTP id b123mr21041986wmb.144.1560338098580; Wed, 12 Jun 2019 04:14:58 -0700 (PDT) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id g19sm6514083wmg.10.2019.06.12.04.14.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Jun 2019 04:14:58 -0700 (PDT) From: Michal Simek To: johan@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com Subject: [PATCH v2 6/6] serial: uartps: Remove useless return from cdns_uart_poll_put_char Date: Wed, 12 Jun 2019 13:14:43 +0200 Message-Id: <19a9f67770e1896dde57d94b093273b503610eef.1560338079.git.michal.simek@xilinx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190612_041500_582413_99974FF0 X-CRM114-Status: GOOD ( 10.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nava kishore Manne , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Jiri Slaby MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Nava kishore Manne There is no reason to call return at the end of function which should return void. The patch is also remove one checkpatch warning: WARNING: void function return statements are not generally useful + return; +} Fixes: 6ee04c6c5488 ("tty: xuartps: Add polled mode support for xuartps") Signed-off-by: Nava kishore Manne Signed-off-by: Michal Simek --- Changes in v2: - Split patch from v1 - Add Fixes tag drivers/tty/serial/xilinx_uartps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index d4c1ae2ffca6..bcef254fa03c 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1074,8 +1074,6 @@ static void cdns_uart_poll_put_char(struct uart_port *port, unsigned char c) cpu_relax(); spin_unlock_irqrestore(&port->lock, flags); - - return; } #endif