| Message ID | 1c422b4c501ec329802a5d00f664821d3b58e11d.1501509526.git.horms+renesas@verge.net.au (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/31/2017 06:03 PM, Simon Horman wrote: > From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > This patch adds the "companion" property in the EHCI ch0, ch1 and > ch2 nodes to wait for the usb companion controller startup at resume. > > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > [remove ch3 node and revise the commit log] > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > index d73d986039c8..7246e689b619 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > @@ -1583,6 +1583,7 @@ > clocks = <&cpg CPG_MOD 703>; > phys = <&usb2_phy0>; > phy-names = "usb"; > + companion= <&ohci0>; > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > resets = <&cpg 703>; > status = "disabled"; > @@ -1595,6 +1596,7 @@ > clocks = <&cpg CPG_MOD 702>; > phys = <&usb2_phy1>; > phy-names = "usb"; > + companion= <&ohci1>; > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > resets = <&cpg 702>; > status = "disabled"; > @@ -1607,6 +1609,7 @@ > clocks = <&cpg CPG_MOD 701>; > phys = <&usb2_phy2>; > phy-names = "usb"; > + companion= <&ohci2>; > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > resets = <&cpg 701>; > status = "disabled"; Looks like a space before = is missing in all 3 cases. MBR, Sergei
On Mon, Jul 31, 2017 at 07:40:23PM +0300, Sergei Shtylyov wrote: > On 07/31/2017 06:03 PM, Simon Horman wrote: > > >From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > > >This patch adds the "companion" property in the EHCI ch0, ch1 and > >ch2 nodes to wait for the usb companion controller startup at resume. > > > >Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > >Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > >[remove ch3 node and revise the commit log] > >Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > >Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >--- > > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 3 +++ > > 1 file changed, 3 insertions(+) > > > >diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > >index d73d986039c8..7246e689b619 100644 > >--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > >+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > >@@ -1583,6 +1583,7 @@ > > clocks = <&cpg CPG_MOD 703>; > > phys = <&usb2_phy0>; > > phy-names = "usb"; > >+ companion= <&ohci0>; > > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > > resets = <&cpg 703>; > > status = "disabled"; > >@@ -1595,6 +1596,7 @@ > > clocks = <&cpg CPG_MOD 702>; > > phys = <&usb2_phy1>; > > phy-names = "usb"; > >+ companion= <&ohci1>; > > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > > resets = <&cpg 702>; > > status = "disabled"; > >@@ -1607,6 +1609,7 @@ > > clocks = <&cpg CPG_MOD 701>; > > phys = <&usb2_phy2>; > > phy-names = "usb"; > >+ companion= <&ohci2>; > > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > > resets = <&cpg 701>; > > status = "disabled"; > > Looks like a space before = is missing in all 3 cases. Thanks. I'll post a follow-up patch for that. I don't think it warrants respinning this pull request at this point.
On Wed, Aug 02, 2017 at 02:20:59PM +0200, Simon Horman wrote: > On Mon, Jul 31, 2017 at 07:40:23PM +0300, Sergei Shtylyov wrote: > > On 07/31/2017 06:03 PM, Simon Horman wrote: > > > > >From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > > > > >This patch adds the "companion" property in the EHCI ch0, ch1 and > > >ch2 nodes to wait for the usb companion controller startup at resume. > > > > > >Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > > >Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > >[remove ch3 node and revise the commit log] > > >Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > > >Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > >--- > > > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > >diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > >index d73d986039c8..7246e689b619 100644 > > >--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > >+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > >@@ -1583,6 +1583,7 @@ > > > clocks = <&cpg CPG_MOD 703>; > > > phys = <&usb2_phy0>; > > > phy-names = "usb"; > > >+ companion= <&ohci0>; > > > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > > > resets = <&cpg 703>; > > > status = "disabled"; > > >@@ -1595,6 +1596,7 @@ > > > clocks = <&cpg CPG_MOD 702>; > > > phys = <&usb2_phy1>; > > > phy-names = "usb"; > > >+ companion= <&ohci1>; > > > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > > > resets = <&cpg 702>; > > > status = "disabled"; > > >@@ -1607,6 +1609,7 @@ > > > clocks = <&cpg CPG_MOD 701>; > > > phys = <&usb2_phy2>; > > > phy-names = "usb"; > > >+ companion= <&ohci2>; > > > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > > > resets = <&cpg 701>; > > > status = "disabled"; > > > > Looks like a space before = is missing in all 3 cases. > > Thanks. > > I'll post a follow-up patch for that. I don't think it warrants respinning > this pull request at this point. Follow-up sent as [PATCH] arm64: dts: renesas: r8a7795: correct whitespace of companion property
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index d73d986039c8..7246e689b619 100644 --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi @@ -1583,6 +1583,7 @@ clocks = <&cpg CPG_MOD 703>; phys = <&usb2_phy0>; phy-names = "usb"; + companion= <&ohci0>; power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; resets = <&cpg 703>; status = "disabled"; @@ -1595,6 +1596,7 @@ clocks = <&cpg CPG_MOD 702>; phys = <&usb2_phy1>; phy-names = "usb"; + companion= <&ohci1>; power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; resets = <&cpg 702>; status = "disabled"; @@ -1607,6 +1609,7 @@ clocks = <&cpg CPG_MOD 701>; phys = <&usb2_phy2>; phy-names = "usb"; + companion= <&ohci2>; power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; resets = <&cpg 701>; status = "disabled";