| Message ID | 1e148d6cd4486b31b5e7f3824cf6bccf536b74c0.1713457260.git.dsimic@manjaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: arm: rockchip: Correct the descriptions for Radxa boards | expand |
Hi Dragan, Am Donnerstag, 18. April 2024, 18:26:19 CEST schrieb Dragan Simic: > Correct the descriptions of a few Radxa boards, according to the up-to-date > documentation from Radxa and the detailed explanation from Naoki. [1] To sum > it up, the short naming, as specified by Radxa, is preferred. > > [1] https://lore.kernel.org/linux-rockchip/B26C732A4DCEA9B3+282b8775-601b-4d4a-a513-4924b7940076@radxa.com/ > > Suggested-by: FUKAUMI Naoki <naoki@radxa.com> > Signed-off-by: Dragan Simic <dsimic@manjaro.org> > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index fcf7316ecd74..ae58e25c29ec 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -767,22 +767,22 @@ properties: > - const: radxa,rockpis > - const: rockchip,rk3308 > > - - description: Radxa Rock2 Square > + - description: Radxa Rock 2 Square I may be just blind, but what changed here? Heiko
On Thu, Apr 18, 2024 at 06:59:42PM +0200, Heiko Stübner wrote: > Hi Dragan, > > Am Donnerstag, 18. April 2024, 18:26:19 CEST schrieb Dragan Simic: > > Correct the descriptions of a few Radxa boards, according to the up-to-date > > documentation from Radxa and the detailed explanation from Naoki. [1] To sum > > it up, the short naming, as specified by Radxa, is preferred. > > > > [1] https://lore.kernel.org/linux-rockchip/B26C732A4DCEA9B3+282b8775-601b-4d4a-a513-4924b7940076@radxa.com/ > > > > Suggested-by: FUKAUMI Naoki <naoki@radxa.com> > > Signed-off-by: Dragan Simic <dsimic@manjaro.org> > > --- > > Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > index fcf7316ecd74..ae58e25c29ec 100644 > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > @@ -767,22 +767,22 @@ properties: > > - const: radxa,rockpis > > - const: rockchip,rk3308 > > > > - - description: Radxa Rock2 Square > > + - description: Radxa Rock 2 Square > > I may be just blind, but what changed here? There's now a space before the 2.
Am Donnerstag, 18. April 2024, 19:04:44 CEST schrieb Conor Dooley: > On Thu, Apr 18, 2024 at 06:59:42PM +0200, Heiko Stübner wrote: > > Hi Dragan, > > > > Am Donnerstag, 18. April 2024, 18:26:19 CEST schrieb Dragan Simic: > > > Correct the descriptions of a few Radxa boards, according to the up-to-date > > > documentation from Radxa and the detailed explanation from Naoki. [1] To sum > > > it up, the short naming, as specified by Radxa, is preferred. > > > > > > [1] https://lore.kernel.org/linux-rockchip/B26C732A4DCEA9B3+282b8775-601b-4d4a-a513-4924b7940076@radxa.com/ > > > > > > Suggested-by: FUKAUMI Naoki <naoki@radxa.com> > > > Signed-off-by: Dragan Simic <dsimic@manjaro.org> > > > --- > > > Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > index fcf7316ecd74..ae58e25c29ec 100644 > > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > @@ -767,22 +767,22 @@ properties: > > > - const: radxa,rockpis > > > - const: rockchip,rk3308 > > > > > > - - description: Radxa Rock2 Square > > > + - description: Radxa Rock 2 Square > > > > I may be just blind, but what changed here? > > There's now a space before the 2. ah, now I see it too :-)
On 2024-04-18 19:04, Conor Dooley wrote: > On Thu, Apr 18, 2024 at 06:59:42PM +0200, Heiko Stübner wrote: >> Am Donnerstag, 18. April 2024, 18:26:19 CEST schrieb Dragan Simic: >> > Correct the descriptions of a few Radxa boards, according to the up-to-date >> > documentation from Radxa and the detailed explanation from Naoki. [1] To sum >> > it up, the short naming, as specified by Radxa, is preferred. >> > >> > [1] https://lore.kernel.org/linux-rockchip/B26C732A4DCEA9B3+282b8775-601b-4d4a-a513-4924b7940076@radxa.com/ >> > >> > Suggested-by: FUKAUMI Naoki <naoki@radxa.com> >> > Signed-off-by: Dragan Simic <dsimic@manjaro.org> >> > --- >> > Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++---- >> > 1 file changed, 4 insertions(+), 4 deletions(-) >> > >> > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml >> > index fcf7316ecd74..ae58e25c29ec 100644 >> > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml >> > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml >> > @@ -767,22 +767,22 @@ properties: >> > - const: radxa,rockpis >> > - const: rockchip,rk3308 >> > >> > - - description: Radxa Rock2 Square >> > + - description: Radxa Rock 2 Square >> >> I may be just blind, but what changed here? > > There's now a space before the 2. Exactly. That's part of the Radxa's naming convention, which may be seen as somewhat similar to the general rule of spacing out values and their associated units, e.g. "2 MB" is in general preferred over "2MB" in nearly any kind of a formally correct document. As a side note, there's even so-called "half space" as a typographical convention for spacing out the values and the associated units. That makes formatted text with such spacing a bit nicer. :)
On Thu, Apr 18, 2024 at 07:12:35PM +0200, Dragan Simic wrote: > On 2024-04-18 19:04, Conor Dooley wrote: > > On Thu, Apr 18, 2024 at 06:59:42PM +0200, Heiko Stübner wrote: > > > Am Donnerstag, 18. April 2024, 18:26:19 CEST schrieb Dragan Simic: > > > > Correct the descriptions of a few Radxa boards, according to the up-to-date > > > > documentation from Radxa and the detailed explanation from Naoki. [1] To sum > > > > it up, the short naming, as specified by Radxa, is preferred. > > > > > > > > [1] https://lore.kernel.org/linux-rockchip/B26C732A4DCEA9B3+282b8775-601b-4d4a-a513-4924b7940076@radxa.com/ > > > > > > > > Suggested-by: FUKAUMI Naoki <naoki@radxa.com> > > > > Signed-off-by: Dragan Simic <dsimic@manjaro.org> > > > > --- > > > > Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++---- > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > > index fcf7316ecd74..ae58e25c29ec 100644 > > > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > > @@ -767,22 +767,22 @@ properties: > > > > - const: radxa,rockpis > > > > - const: rockchip,rk3308 > > > > > > > > - - description: Radxa Rock2 Square > > > > + - description: Radxa Rock 2 Square > > > > > > I may be just blind, but what changed here? > > > > There's now a space before the 2. > > Exactly. That's part of the Radxa's naming convention, which may be > seen as somewhat similar to the general rule of spacing out values and > their associated units, e.g. "2 MB" is in general preferred over "2MB" > in nearly any kind of a formally correct document. > As a side note, there's even so-called "half space" as a typographical > convention for spacing out the values and the associated units. That > makes formatted text with such spacing a bit nicer. :) Let's not introduce half spaces into the bindings though :)
On 2024-04-19 16:09, Conor Dooley wrote: > On Thu, Apr 18, 2024 at 07:12:35PM +0200, Dragan Simic wrote: >> On 2024-04-18 19:04, Conor Dooley wrote: >> > On Thu, Apr 18, 2024 at 06:59:42PM +0200, Heiko Stübner wrote: >> > > Am Donnerstag, 18. April 2024, 18:26:19 CEST schrieb Dragan Simic: >> > > > Correct the descriptions of a few Radxa boards, according to the up-to-date >> > > > documentation from Radxa and the detailed explanation from Naoki. [1] To sum >> > > > it up, the short naming, as specified by Radxa, is preferred. >> > > > >> > > > [1] https://lore.kernel.org/linux-rockchip/B26C732A4DCEA9B3+282b8775-601b-4d4a-a513-4924b7940076@radxa.com/ >> > > > >> > > > Suggested-by: FUKAUMI Naoki <naoki@radxa.com> >> > > > Signed-off-by: Dragan Simic <dsimic@manjaro.org> >> > > > --- >> > > > Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++---- >> > > > 1 file changed, 4 insertions(+), 4 deletions(-) >> > > > >> > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml >> > > > index fcf7316ecd74..ae58e25c29ec 100644 >> > > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml >> > > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml >> > > > @@ -767,22 +767,22 @@ properties: >> > > > - const: radxa,rockpis >> > > > - const: rockchip,rk3308 >> > > > >> > > > - - description: Radxa Rock2 Square >> > > > + - description: Radxa Rock 2 Square >> > > >> > > I may be just blind, but what changed here? >> > >> > There's now a space before the 2. >> >> Exactly. That's part of the Radxa's naming convention, which may be >> seen as somewhat similar to the general rule of spacing out values and >> their associated units, e.g. "2 MB" is in general preferred over "2MB" >> in nearly any kind of a formally correct document. > >> As a side note, there's even so-called "half space" as a typographical >> convention for spacing out the values and the associated units. That >> makes formatted text with such spacing a bit nicer. :) > > Let's not introduce half spaces into the bindings though :) Of course. :)
On Thu, 18 Apr 2024 18:26:19 +0200, Dragan Simic wrote: > Correct the descriptions of a few Radxa boards, according to the up-to-date > documentation from Radxa and the detailed explanation from Naoki. [1] To sum > it up, the short naming, as specified by Radxa, is preferred. > > [1] https://lore.kernel.org/linux-rockchip/B26C732A4DCEA9B3+282b8775-601b-4d4a-a513-4924b7940076@radxa.com/ > > Suggested-by: FUKAUMI Naoki <naoki@radxa.com> > Signed-off-by: Dragan Simic <dsimic@manjaro.org> > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Acked-by: Rob Herring (Arm) <robh@kernel.org>
On 2024-04-22 16:32, Rob Herring wrote: > On Thu, 18 Apr 2024 18:26:19 +0200, Dragan Simic wrote: >> Correct the descriptions of a few Radxa boards, according to the >> up-to-date >> documentation from Radxa and the detailed explanation from Naoki. [1] >> To sum >> it up, the short naming, as specified by Radxa, is preferred. >> >> [1] >> https://lore.kernel.org/linux-rockchip/B26C732A4DCEA9B3+282b8775-601b-4d4a-a513-4924b7940076@radxa.com/ >> >> Suggested-by: FUKAUMI Naoki <naoki@radxa.com> >> Signed-off-by: Dragan Simic <dsimic@manjaro.org> >> --- >> Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) > > Acked-by: Rob Herring (Arm) <robh@kernel.org> Thanks!
On Thu, 18 Apr 2024 18:26:19 +0200, Dragan Simic wrote: > Correct the descriptions of a few Radxa boards, according to the up-to-date > documentation from Radxa and the detailed explanation from Naoki. [1] To sum > it up, the short naming, as specified by Radxa, is preferred. > > [1] https://lore.kernel.org/linux-rockchip/B26C732A4DCEA9B3+282b8775-601b-4d4a-a513-4924b7940076@radxa.com/ > > > [...] Applied, thanks! [1/2] dt-bindings: arm: rockchip: Correct the descriptions for Radxa boards commit: d78084cdb5a959a5759efed9b3bc3182d005073c [2/2] arm64: dts: rockchip: Correct the model names for Radxa ROCK 5 boards commit: 45e831033f7a00a14f64afa1e34c476a9ff0f9f0 Best regards,
On 2024-04-23 17:15, Heiko Stuebner wrote: > On Thu, 18 Apr 2024 18:26:19 +0200, Dragan Simic wrote: >> Correct the descriptions of a few Radxa boards, according to the >> up-to-date >> documentation from Radxa and the detailed explanation from Naoki. [1] >> To sum >> it up, the short naming, as specified by Radxa, is preferred. >> >> [1] >> https://lore.kernel.org/linux-rockchip/B26C732A4DCEA9B3+282b8775-601b-4d4a-a513-4924b7940076@radxa.com/ >> >> >> [...] > > Applied, thanks! > > [1/2] dt-bindings: arm: rockchip: Correct the descriptions for Radxa > boards > commit: d78084cdb5a959a5759efed9b3bc3182d005073c > [2/2] arm64: dts: rockchip: Correct the model names for Radxa ROCK 5 > boards > commit: 45e831033f7a00a14f64afa1e34c476a9ff0f9f0 Thanks!
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index fcf7316ecd74..ae58e25c29ec 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -705,7 +705,7 @@ properties: - const: qnap,ts433 - const: rockchip,rk3568 - - description: Radxa Compute Module 3(CM3) + - description: Radxa Compute Module 3 (CM3) items: - enum: - radxa,cm3-io @@ -767,22 +767,22 @@ properties: - const: radxa,rockpis - const: rockchip,rk3308 - - description: Radxa Rock2 Square + - description: Radxa Rock 2 Square items: - const: radxa,rock2-square - const: rockchip,rk3288 - description: Radxa ROCK3 Model A items: - const: radxa,rock3a - const: rockchip,rk3568 - - description: Radxa ROCK 5 Model A + - description: Radxa ROCK 5A items: - const: radxa,rock-5a - const: rockchip,rk3588s - - description: Radxa ROCK 5 Model B + - description: Radxa ROCK 5B items: - const: radxa,rock-5b - const: rockchip,rk3588
Correct the descriptions of a few Radxa boards, according to the up-to-date documentation from Radxa and the detailed explanation from Naoki. [1] To sum it up, the short naming, as specified by Radxa, is preferred. [1] https://lore.kernel.org/linux-rockchip/B26C732A4DCEA9B3+282b8775-601b-4d4a-a513-4924b7940076@radxa.com/ Suggested-by: FUKAUMI Naoki <naoki@radxa.com> Signed-off-by: Dragan Simic <dsimic@manjaro.org> --- Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)