From patchwork Wed Mar 8 15:00:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sekhar Nori X-Patchwork-Id: 9611397 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 267AD6046A for ; Wed, 8 Mar 2017 15:03:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E1FEB2857B for ; Wed, 8 Mar 2017 15:03:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D4ED2285C5; Wed, 8 Mar 2017 15:03:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 846322857B for ; Wed, 8 Mar 2017 15:03:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gY9+FJHaBPbpiUUXua1+iNI6iYJkqDH9wqXrLlwYwsg=; b=uG/OnlpDE/pu5y TA2/0M22R32tTopDuGGO7uql0AaMu4hLz5q1c3RxbwVWllkuZ4nhX0z7krpa9M3MADtoAx3Fv+kOK gTeAN8xX89KZsL2ny3eg3gw3l+yUcb1D8hYenLafTd9D8SdNU1HbuuVzG1aHWrOrGryej0oPb5hox JORyW9OvFqK9ZW7g9LhWLkc5xxotK1GOTYW0+Va8K+y3B4QP5z0INLCOmfFoulxdw1HwVvrmTvh0Q NM38CflHi7+vLDyrnfSQtnE00cR2/kobVXMGlbFJ0UWby7jwW+2w0ZJCLcGkTIxX1UwKR7KhdLVOF +QCN2MwxHNRn6hGcKI9Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cld7l-0005Ik-Sx; Wed, 08 Mar 2017 15:03:33 +0000 Received: from fllnx209.ext.ti.com ([198.47.19.16]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cld7H-00054n-Ou for linux-arm-kernel@lists.infradead.org; Wed, 08 Mar 2017 15:03:10 +0000 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id v28F1BjQ025793; Wed, 8 Mar 2017 09:01:11 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1488985271; bh=hNMlwuIkexond+HVADSCuFDjkdvPBeQ+X1qnYZ0svZk=; h=Subject:To:References:CC:From:Date:In-Reply-To; b=u82GC3UCm6T2Ghg3D8kI07Xgk9rrgLO0LJLzDiT3Kg5hpXrRcZ8oiJsNrRdFCgVGj bNF53jiGinQpERc7n3GcwuU09J+N5pLI11y+Zq5CqKPSkiSnAb4VlG0C+po133CSWi PN5rKbQz76AkO34GISdwOXpXKSS35TPP0iY9Wsak= Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v28F16dF021875; Wed, 8 Mar 2017 09:01:06 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.294.0; Wed, 8 Mar 2017 09:01:05 -0600 Received: from [172.24.190.171] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id v28F0wsQ005765; Wed, 8 Mar 2017 09:01:00 -0600 Subject: Re: [RESEND PATCH] arm: assabet_defconfig: disable IDE subsystem To: Bartlomiej Zolnierkiewicz References: <1467991490-24895-1-git-send-email-b.zolnierkie@samsung.com> <8ea5971a-338d-e8b9-6be8-8fe2658fc04d@ti.com> <1709119.SQyio4Ct6n@amdc3058> From: Sekhar Nori Message-ID: <1fd840c5-b0bb-726b-6357-669977c4ae5f@ti.com> Date: Wed, 8 Mar 2017 20:30:58 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1709119.SQyio4Ct6n@amdc3058> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170308_070304_551634_ED649550 X-CRM114-Status: GOOD ( 19.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Russell King , Arnd Bergmann , Dmitry Eremin-Solenikov , Kevin Hilman , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Olof Johansson , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Tuesday 07 March 2017 11:21 PM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Monday, December 12, 2016 07:24:47 PM Sekhar Nori wrote: >> Hi Bartlomiej, >> >> On Monday 12 December 2016 06:15 PM, Bartlomiej Zolnierkiewicz wrote: >>> >>> Hi, >>> >>> On Monday, July 18, 2016 08:15:08 PM Sekhar Nori wrote: >>>> On Friday 15 July 2016 08:45 PM, Kevin Hilman wrote: >>>>> Arnd Bergmann writes: >>>>> >>>>>> On Wednesday, July 13, 2016 12:59:23 PM CEST Bartlomiej Zolnierkiewicz wrote: >>>>>>> >>>>>>> On Friday, July 08, 2016 10:23:48 PM Arnd Bergmann wrote: >>>>>>>> On Friday, July 8, 2016 5:24:41 PM CEST Bartlomiej Zolnierkiewicz wrote: >>>>>>>>> This patch disables deprecated IDE subsystem in assabet_defconfig >>>>>>>>> (no IDE host drivers are selected in this config so there is no >>>>>>>>> valid reason to enable IDE subsystem itself). >>>>>>>>> >>>>>>>>> Cc: Dmitry Eremin-Solenikov >>>>>>>>> Signed-off-by: Bartlomiej Zolnierkiewicz >>>>>>>> >>>>>>>> I think the series makes a lot of sense. I have checked your assertions >>>>>>>> in the changelogs and found no flaws in your logic, so I think we should >>>>>>>> take them all through arm-soc unless there are other concerns. >>>>>>> >>>>>>> Thank you. >>>>>>> >>>>>>> Should I resend everything or just patches that were not reposted yet >>>>>>> (the ones that were marked as RFT initially and got no feedback)? >>>>>> >>>>>> I'd be fine with just getting a pull request with all the patches that >>>>>> had no negative feedback and that were not already applied (if any). >>>>>> >>>>>>>> Do you have a list of ARM defconfigs that keep using CONFIG_IDE and >>>>>>>> how you determined that they need it? >>>>>>> >>>>>>> The only such defconfig is davinci_all_defconfig which uses >>>>>>> palm_bk3710 host driver (CONFIG_BLK_DEV_PALMCHIP_BK3710). >>>>>>> >>>>>>>> I know that ARCH_RPC/ARCH_ACORN has a couple of special drivers that >>>>>>>> have no libata replacement, are there any others like that, or are >>>>>>>> they all platforms that should in theory work with libata but need >>>>>>>> testing? >>>>>>> >>>>>>> All platforms except ARCH_ACORN, ARCH_DAVINCI & ARCH_RPC should work >>>>>>> with libata. >>>>>> >>>>>> Adding Sekhar and Kevin for DaVinci: At first sight, palm_bk3710 looks >>>>>> fairly straightforward (meaning someone has to do a few day's work) >>>>>> to convert into a libata driver. >>>>>> >>>>>> As this is on on-chip controller that is part of a dm644x and dm646x, >>>>>> it should also not be hard to test (as long as someone can find >>>>>> a hard drive to plug in). >>>>> >>>>> I have a hard drive, but don't have any dm64xx hardware anymore to test >>>>> this. My last working dm644x board died last year. >>>> >>>> I have a working DM6446 EVM. I was able to connect a hard drive to it >>>> and do some basic tests with v4.6 kernel. >>>> >>>> I will look into converting the driver to libata. Might take some time >>>> because this is unfamiliar territory for me. >>> >>> Do you need some help with it? >>> >>> I can provide you with draft driver patch if you want. >> >> A draft driver patch will really help. I can test/debug. Otherwise, not >> sure when I will really be able to get to this. > > It took a while to get to it but here is the draft driver patch > against v4.11-rc1. Please test. I tested this on DM6446 EVM. I was able to mount existing partitions on the hard disk and see that the directory listing looks good[1]. I will do more tests (including comparing performance with old driver) tomorrow. I did not have to do much to get it work[2]. Great job! Thanks! I did see a warning reported during the build[3]. Regards, Sekhar [1] http://pastebin.ubuntu.com/24139206/ [2] The only patch I had to apply is (similar change required in couple of other places too): [3] drivers/ata/pata_bk3710.c: In function 'pata_bk3710_set_piomode': drivers/ata/pata_bk3710.c:223:5: warning: 'cycle_time' may be used uninitialized in this function [-Wmaybe-uninitialized] if (!cycle_time) ^ diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c index 023480b75244..60a1f23890cd 100644 --- a/arch/arm/mach-davinci/board-dm644x-evm.c +++ b/arch/arm/mach-davinci/board-dm644x-evm.c @@ -744,7 +744,7 @@ static int davinci_phy_fixup(struct phy_device *phydev) return 0; } -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) #define HAS_NOR IS_ENABLED(CONFIG_MTD_PHYSMAP)