From patchwork Thu Jun 9 20:41:13 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mika Westerberg X-Patchwork-Id: 866882 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p59Khqvi030515 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 9 Jun 2011 20:44:13 GMT Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QUm4u-0004jE-Aq; Thu, 09 Jun 2011 20:43:44 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QUm4t-0005ic-TX; Thu, 09 Jun 2011 20:43:43 +0000 Received: from mail-ey0-f177.google.com ([209.85.215.177]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QUm4r-0005iI-4z for linux-arm-kernel@lists.infradead.org; Thu, 09 Jun 2011 20:43:42 +0000 Received: by eyh6 with SMTP id 6so846104eyh.36 for ; Thu, 09 Jun 2011 13:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=t96V2ROWibsjUFn4qXmrBDqGpf9MP5Gp/te6V7DVhFI=; b=TzrvvoomKQm6GMgXV7AtCii3XBINQ/rNfIPXjlT4mgIsSsukap++3Oa+bYVpuqQj3B lq2BTQtKZxXmqKg9ttbp9WPHQ7iLzZ6R8n1Ze5VbE6ClanXk/QU/aokJ9HyvAX5HlHRB eWb2yrM+TPepho/KILXcGtNi+ylSIt6DfYfts= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=wgKW0/GfUdCnF+8P02Sqd4NTLu3n7gdRqFCqrLX8Ipa1lIjV2eeGR2YcOYJGXWBlj3 9Z2WuV8rXLYBOm4Q/GjaPE9NvmD/HMtifhPVAE58R4HAQKxo3c3gn1A2qdJzLxghYlrF zXzThLhgG8/+n4iNCrJ+9XZfIj/EazW35zKjk= Received: by 10.213.32.4 with SMTP id a4mr1129288ebd.40.1307652219104; Thu, 09 Jun 2011 13:43:39 -0700 (PDT) Received: from acer (a88-115-37-157.elisa-laajakaista.fi [88.115.37.157]) by mx.google.com with ESMTPS id x3sm1773502eef.3.2011.06.09.13.43.37 (version=SSLv3 cipher=OTHER); Thu, 09 Jun 2011 13:43:38 -0700 (PDT) Date: Thu, 9 Jun 2011 23:41:13 +0300 From: Mika Westerberg To: H Hartley Sweeten Subject: Re: [PATCH v2 1/5] ep93xx: set DMA masks for the ep93xx_eth Message-ID: <20110609204113.GE2857@acer> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110609_164341_557476_8B9B5B90 X-CRM114-Status: GOOD ( 23.19 ) X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.215.177 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is freemail (mika.westerberg[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 RFC_ABUSE_POST Both abuse and postmaster missing on sender domain Cc: "netdev@vger.kernel.org" , "ryan@bluewatersys.com" , "kernel@wantstofly.org" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Thu, 09 Jun 2011 20:44:13 +0000 (UTC) On Thu, Jun 09, 2011 at 03:27:11PM -0500, H Hartley Sweeten wrote: > On Thursday, June 02, 2011 12:00 PM, Mika Westerberg wrote: > > > > As the driver is now passing platform device to the DMA mapping functions, > > we should give it valid DMA masks. > > > > Signed-off-by: Mika Westerberg > > Acked-by: Russell King > > Since you made this patch the first in the series the commit message is not > quite right. Other than that: > > Acked-by: H Hartley Sweeten Ah, right. I forgot to change the commit message. How about following? From: Mika Westerberg Subject: [PATCH 1/5] ep93xx: set DMA masks for the ep93xx_eth Since the driver uses the DMA API, we should pass it valid DMA masks. Signed-off-by: Mika Westerberg Acked-by: Russell King Acked-by: H Hartley Sweeten --- arch/arm/mach-ep93xx/core.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c index 8207954..1d4b65f 100644 --- a/arch/arm/mach-ep93xx/core.c +++ b/arch/arm/mach-ep93xx/core.c @@ -402,11 +402,15 @@ static struct resource ep93xx_eth_resource[] = { } }; +static u64 ep93xx_eth_dma_mask = DMA_BIT_MASK(32); + static struct platform_device ep93xx_eth_device = { .name = "ep93xx-eth", .id = -1, .dev = { - .platform_data = &ep93xx_eth_data, + .platform_data = &ep93xx_eth_data, + .coherent_dma_mask = DMA_BIT_MASK(32), + .dma_mask = &ep93xx_eth_dma_mask, }, .num_resources = ARRAY_SIZE(ep93xx_eth_resource), .resource = ep93xx_eth_resource,