diff mbox

[2/2] arm: mach-bcmring: fix build error in dma.c

Message ID 20110823112128.GA2825@maxin (mailing list archive)
State New, archived
Headers show

Commit Message

Maxin John Aug. 23, 2011, 11:21 a.m. UTC
CC      arch/arm/mach-bcmring/dma.o
arch/arm/mach-bcmring/dma.c: In function 'dma_request_channel_dbg':
arch/arm/mach-bcmring/dma.c:1022: error: 'TASK_INTERRUPTIBLE'
undeclared (first use in this function)
arch/arm/mach-bcmring/dma.c:1022: error: (Each undeclared identifier
is reported only once
arch/arm/mach-bcmring/dma.c:1022: error: for each function it appears
in.)
arch/arm/mach-bcmring/dma.c:1024: error: implicit declaration of
function 'schedule'
arch/arm/mach-bcmring/dma.c:1027: error: implicit declaration of
function 'signal_pending'
arch/arm/mach-bcmring/dma.c: In function 'dma_free_channel':
arch/arm/mach-bcmring/dma.c:1092: error: 'TASK_INTERRUPTIBLE'
undeclared (first use in this function)
arch/arm/mach-bcmring/dma.c: In function 'dma_map_add_region':
arch/arm/mach-bcmring/dma.c:1946: error: dereferencing pointer to
incomplete type
arch/arm/mach-bcmring/dma.c:1948: error: dereferencing pointer to
incomplete type
arch/arm/mach-bcmring/dma.c:1955: error: dereferencing pointer to
incomplete type
make[1]: *** [arch/arm/mach-bcmring/dma.o] Error 1
make: *** [arch/arm/mach-bcmring] Error 2

Signed-off-by: Maxin B. John <maxin.john@gmail.com>
---

Comments

JD (Jiandong) Zheng Aug. 23, 2011, 4:44 p.m. UTC | #1
On 8/23/2011 4:21 AM, Maxin B John wrote:
>   CC      arch/arm/mach-bcmring/dma.o
> arch/arm/mach-bcmring/dma.c: In function 'dma_request_channel_dbg':
> arch/arm/mach-bcmring/dma.c:1022: error: 'TASK_INTERRUPTIBLE'
> undeclared (first use in this function)
> arch/arm/mach-bcmring/dma.c:1022: error: (Each undeclared identifier
> is reported only once
> arch/arm/mach-bcmring/dma.c:1022: error: for each function it appears
> in.)
> arch/arm/mach-bcmring/dma.c:1024: error: implicit declaration of
> function 'schedule'
> arch/arm/mach-bcmring/dma.c:1027: error: implicit declaration of
> function 'signal_pending'
> arch/arm/mach-bcmring/dma.c: In function 'dma_free_channel':
> arch/arm/mach-bcmring/dma.c:1092: error: 'TASK_INTERRUPTIBLE'
> undeclared (first use in this function)
> arch/arm/mach-bcmring/dma.c: In function 'dma_map_add_region':
> arch/arm/mach-bcmring/dma.c:1946: error: dereferencing pointer to
> incomplete type
> arch/arm/mach-bcmring/dma.c:1948: error: dereferencing pointer to
> incomplete type
> arch/arm/mach-bcmring/dma.c:1955: error: dereferencing pointer to
> incomplete type
> make[1]: *** [arch/arm/mach-bcmring/dma.o] Error 1
> make: *** [arch/arm/mach-bcmring] Error 2
>
> Signed-off-by: Maxin B. John<maxin.john@gmail.com>
> ---
> diff --git a/arch/arm/mach-bcmring/dma.c b/arch/arm/mach-bcmring/dma.c
> index 0ca0005..12d1504 100644
> --- a/arch/arm/mach-bcmring/dma.c
> +++ b/arch/arm/mach-bcmring/dma.c
> @@ -35,6 +35,7 @@
>   #include<linux/mm.h>
>   #include<linux/pfn.h>
>   #include<linux/atomic.h>
> +#include<linux/sched.h>
>   #include<mach/dma.h>
>
>   /* I don't quite understand why dc4 fails when this is set to 1 and DMA is enabled */
>
Signed-off-by: Jiandong Zheng <jdzheng@broadcom.com>

I have same fix submitted on May 12, which was supposed to be applied 
soon but seems it wasn't.
Maxin John Aug. 24, 2011, 6:28 a.m. UTC | #2
On Tue, Aug 23, 2011 at 7:44 PM, Jiandong Zheng <jdzheng@broadcom.com> wrote:
> On 8/23/2011 4:21 AM, Maxin B John wrote:
>>
>>  CC      arch/arm/mach-bcmring/dma.o
>>
> Signed-off-by: Jiandong Zheng <jdzheng@broadcom.com>
>
> I have same fix submitted on May 12, which was supposed to be applied soon
> but seems it wasn't.

Oh.. I wasn't aware of that. Please feel free to ignore this one and
go ahead with your patch.

Regards,
Maxin
JD (Jiandong) Zheng Aug. 24, 2011, 5:22 p.m. UTC | #3
On 8/23/2011 11:28 PM, Maxin B John wrote:
> On Tue, Aug 23, 2011 at 7:44 PM, Jiandong Zheng<jdzheng@broadcom.com>  wrote:
>> On 8/23/2011 4:21 AM, Maxin B John wrote:
>>>
>>>   CC      arch/arm/mach-bcmring/dma.o
>>>
>> Signed-off-by: Jiandong Zheng<jdzheng@broadcom.com>
>>
>> I have same fix submitted on May 12, which was supposed to be applied soon
>> but seems it wasn't.
>
> Oh.. I wasn't aware of that. Please feel free to ignore this one and
> go ahead with your patch.
>
> Regards,
> Maxin
>
Seems the previous patch was lost. Let us just go ahead with this one in 
order to get it fixed sooner.
diff mbox

Patch

diff --git a/arch/arm/mach-bcmring/dma.c b/arch/arm/mach-bcmring/dma.c
index 0ca0005..12d1504 100644
--- a/arch/arm/mach-bcmring/dma.c
+++ b/arch/arm/mach-bcmring/dma.c
@@ -35,6 +35,7 @@ 
 #include <linux/mm.h>
 #include <linux/pfn.h>
 #include <linux/atomic.h>
+#include <linux/sched.h>
 #include <mach/dma.h>
 
 /* I don't quite understand why dc4 fails when this is set to 1 and DMA is enabled */