From patchwork Fri Jul 13 14:00:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 1195811 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 4D55F3FD48 for ; Fri, 13 Jul 2012 14:06:55 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SpgRg-0005uz-HO; Fri, 13 Jul 2012 14:02:12 +0000 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SpgQv-0005kU-2p for linux-arm-kernel@lists.infradead.org; Fri, 13 Jul 2012 14:01:25 +0000 Received: from mudshark.cambridge.arm.com (mudshark.cambridge.arm.com [10.1.79.58]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id q6DE0MOK020139; Fri, 13 Jul 2012 15:00:22 +0100 (BST) Date: Fri, 13 Jul 2012 15:00:21 +0100 From: Will Deacon To: Jon Hunter Subject: Re: [PATCH V2 08/10] ARM: OMAP4: Prevent EMU power domain transitioning to OFF when in-use Message-ID: <20120713140021.GS18079@mudshark.cambridge.arm.com> References: <1339104132-26885-1-git-send-email-jon-hunter@ti.com> <1339104132-26885-9-git-send-email-jon-hunter@ti.com> <500028B3.1040309@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <500028B3.1040309@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Note: CRM114 invocation failed X-Spam-Score: -6.9 (------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-6.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [217.140.96.50 listed in list.dnswl.org] -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Kevin Hilman , Paul Walmsley , Benoit Cousson , Ming Lei , linux-omap , linux-arm X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Jon, [cutting out realms of context!] On Fri, Jul 13, 2012 at 02:54:59PM +0100, Jon Hunter wrote: > Another proposal I also thought of is re-working the flags to describe > the HW mode to be used when turning on the CLKDM, when the CLKDM is > active and when the CLKDM is shut down. So instead of saying what modes > the CLKDM supports, specify what modes should be used for pre-ON (i.e. > turn ON), ON and OFF. Right now software is trying to decide for us by > what is available (which is ideal) but makes working around such nuances > a little more painful. > > By the way, I did do some testing on OMAP3, but I don't recall now > whether I was having such problems with OMAP3. I need to go back and > test perf again on OMAP3 to see if such a flag is needed. If you do test on OMAP3, please kill the OMAP3_EMU option as I think this has the effect of keeping the EMU power domain up via the etm code (look at etb_probe). Will ---8<--- diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index a91009c..d02054c 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1139,8 +1139,7 @@ config XSCALE_PMU default y config CPU_HAS_PMU - depends on (CPU_V6 || CPU_V6K || CPU_V7 || XSCALE_PMU) && \ - (!ARCH_OMAP3 || OMAP3_EMU) + depends on (CPU_V6 || CPU_V6K || CPU_V7 || XSCALE_PMU) default y bool