From patchwork Wed Aug 8 17:26:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 1297331 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 9BA9E3FCFC for ; Wed, 8 Aug 2012 19:17:49 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SzBiQ-0000lg-Ur; Wed, 08 Aug 2012 19:14:47 +0000 Received: from moutng.kundenserver.de ([212.227.126.186]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SzBi9-0000kU-Bv for linux-arm-kernel@lists.infradead.org; Wed, 08 Aug 2012 19:14:31 +0000 Received: from klappe2.localnet (HSI-KBW-149-172-5-253.hsi13.kabel-badenwuerttemberg.de [149.172.5.253]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0MELXc-1SwvbC1xge-00FSgg; Wed, 08 Aug 2012 21:14:23 +0200 From: Arnd Bergmann To: Takashi Iwai Subject: Re: [PATCH 11/11] pm/drivers: fix use of SIMPLE_DEV_PM_OPS Date: Wed, 8 Aug 2012 17:26:21 +0000 User-Agent: KMail/1.12.2 (Linux/3.5.0; KDE/4.3.2; x86_64; ; ) References: <1344437248-20560-1-git-send-email-arnd@arndb.de> <201208081622.29777.arnd@arndb.de> In-Reply-To: MIME-Version: 1.0 Message-Id: <201208081726.21878.arnd@arndb.de> X-Provags-ID: V02:K0:sGpDBc4Dk1sBPsrslX3ZIy5nFSlvytaPeuJbD+NiD3e xypF+3C71sssrQa9CIIE1JJP37gD4xqAgQqch55KoVgvTVOtmp xIhV2yvaKDn+Ao4Due6f3oFTrvqt9grltpXxDk35LPm45AlcYF yvtccFgZMmHG1g9pF9Ikym3yTAzsWGXWhcv53rU5S7omrHy+l3 TrEnnYhnwjQX/AZzCm+K1k7NBNL3BjLarV6WLZmZVhLqsyklsB DnIsYyUuxQIf78juqEe/DpDPs1KH34YUfENC+UVPrBImrvfXsR Zl22uRpGVtn43XDLLJtvjvLPGetk3mTXChiC8ei5F4SwyaCM1M 86MD68ZqwlRuQjHeQTfg= X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.186 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Herbert Xu , Stephen Warren , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , arm@kernel.org, Laxman Dewangan , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Wednesday 08 August 2012, Takashi Iwai wrote: > At Wed, 8 Aug 2012 16:22:29 +0000, > Arnd Bergmann wrote: > > > Laxman already posted a patch for this, which I'm hoping will make it > > > into 3.6, through the I2C tree. > > > > > > http://www.spinics.net/lists/linux-i2c/msg09359.html > > > > Ok, dropping this one then. > > I'm going to fix the similar errors in sound tree tomorrow, too. > Ok. this leaves the omap-rng driver, and my patch comes down to the below. Thanks! Arnd 8<---- From d83e9e0e5c0e41a0ee2ba6293c8be21e54988f99 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Sat, 4 Aug 2012 07:11:34 +0000 Subject: [PATCH] omap-rng: fix use of SIMPLE_DEV_PM_OPS omap_rng_suspend and omap_rng_resume are unused if CONFIG_PM is enabled but CONFIG_PM_SLEEP is disabled. I found this while building all defconfig files on ARM. It's not clear to me if this is the right solution, but at least it makes the code consistent again. Without this patch, building omap1_defconfig results in: drivers/char/hw_random/omap-rng.c:165:12: warning: 'omap_rng_suspend' defined but not used [-Wunused-function] drivers/char/hw_random/omap-rng.c:171:12: warning: 'omap_rng_resume' defined but not used [-Wunused-function] Signed-off-by: Arnd Bergmann Cc: Rafael J. Wysocki Cc: Herbert Xu diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c index d706bd0e..4fbdceb 100644 --- a/drivers/char/hw_random/omap-rng.c +++ b/drivers/char/hw_random/omap-rng.c @@ -160,7 +160,7 @@ static int __exit omap_rng_remove(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM +#ifdef CONFIG_PM_SLEEP static int omap_rng_suspend(struct device *dev) {