From patchwork Tue Aug 28 23:09:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaro Koskinen X-Patchwork-Id: 1383071 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id B68D53FC85 for ; Tue, 28 Aug 2012 23:16:09 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T6Uv4-00053Q-Nt; Tue, 28 Aug 2012 23:10:02 +0000 Received: from casper.infradead.org ([2001:770:15f::2]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1T6Uv1-000531-Da for linux-arm-kernel@merlin.infradead.org; Tue, 28 Aug 2012 23:09:59 +0000 Received: from filtteri2.pp.htv.fi ([213.243.153.185]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T6Uuz-0005dC-1b for linux-arm-kernel@lists.infradead.org; Tue, 28 Aug 2012 23:09:58 +0000 Received: from localhost (localhost [127.0.0.1]) by filtteri2.pp.htv.fi (Postfix) with ESMTP id A433A19B6D8; Wed, 29 Aug 2012 02:09:42 +0300 (EEST) X-Virus-Scanned: Debian amavisd-new at pp.htv.fi Received: from smtp6.welho.com ([213.243.153.40]) by localhost (filtteri2.pp.htv.fi [213.243.153.185]) (amavisd-new, port 10024) with ESMTP id SDEv5+AZHXag; Wed, 29 Aug 2012 02:09:42 +0300 (EEST) Received: from harshnoise (212-149-209-232.bb.dnainternet.fi [212.149.209.232]) by smtp6.welho.com (Postfix) with SMTP id 4B98C5BC003; Wed, 29 Aug 2012 02:09:41 +0300 (EEST) Received: by harshnoise (sSMTP sendmail emulation); Wed, 29 Aug 2012 02:09:17 +0300 Date: Wed, 29 Aug 2012 02:09:17 +0300 From: Aaro Koskinen To: "Shilimkar, Santosh" Subject: Re: [PATCH] arm: omap: ratelimit omap_l3_smx error log spam Message-ID: <20120828230917.GD783@harshnoise.musicnaut.iki.fi> References: <1346101403-5882-1-git-send-email-aaro.koskinen@iki.fi> <20120827220254.GA783@harshnoise.musicnaut.iki.fi> <20120827232613.GB783@harshnoise.musicnaut.iki.fi> <20120828122042.GC783@harshnoise.musicnaut.iki.fi> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20120829_000957_209180_84EE77AA X-CRM114-Status: GOOD ( 13.89 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: tony@atomide.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi, On Tue, Aug 28, 2012 at 07:19:38AM -0700, Shilimkar, Santosh wrote: > Or the PPA has resized the secure area of 16K. As you have seen the issue > on one OMAP3 device, it makes sense to takeout that 16K from the public > SRAM map. > > Can you send the patch with fixed base address fir PUB SRAM ? Maybe I'm missing something, but I tried the following and now something else got broken: save_secure_sram() returns 0000ff02 (and it hangs there). diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c index 766181c..242ea5b 100644 --- a/arch/arm/plat-omap/sram.c +++ b/arch/arm/plat-omap/sram.c @@ -38,7 +38,7 @@ #define OMAP1_SRAM_PA 0x20000000 #define OMAP2_SRAM_PUB_PA (OMAP2_SRAM_PA + 0xf800) -#define OMAP3_SRAM_PUB_PA (OMAP3_SRAM_PA + 0x8000) +#define OMAP3_SRAM_PUB_PA (OMAP3_SRAM_PA + 0xc000) #ifdef CONFIG_OMAP4_ERRATA_I688 #define OMAP4_SRAM_PUB_PA OMAP4_SRAM_PA #else @@ -112,9 +112,9 @@ static void __init omap_detect_sram(void) omap_sram_start = OMAP3_SRAM_PUB_PA; if ((omap_type() == OMAP2_DEVICE_TYPE_EMU) || (omap_type() == OMAP2_DEVICE_TYPE_SEC)) { - omap_sram_size = 0x7000; /* 28K */ + omap_sram_size = 0x3000; /* 12K */ } else { - omap_sram_size = 0x8000; /* 32K */ + omap_sram_size = SZ_16K; /* 16K */ } } else if (cpu_is_omap44xx()) { omap_sram_start = OMAP4_SRAM_PUB_PA;