From patchwork Mon Sep 17 14:11:19 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olof Johansson X-Patchwork-Id: 1467611 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 1593DDF2D8 for ; Mon, 17 Sep 2012 14:14:50 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TDc35-00059k-FV; Mon, 17 Sep 2012 14:11:44 +0000 Received: from mail-pb0-f49.google.com ([209.85.160.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TDc2l-00054e-Ow for linux-arm-kernel@lists.infradead.org; Mon, 17 Sep 2012 14:11:25 +0000 Received: by pbbrq8 with SMTP id rq8so9920658pbb.36 for ; Mon, 17 Sep 2012 07:11:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent :x-gm-message-state; bh=3XG8jx2LPivfgs1ScszpBgL4Rj/dGMy4xyl3QlRStgY=; b=gg4miUMQlLTWmoFecPl3ZKNaPpSyt7pEN7ZBYIOkyy1B+i87wrv4vGUxtFFmR3rdyL pRwxkBINRfaoPW3lPt9IgwRVR5IasKhK35dWHwScYVqU55S85NgcaLaYGRzCh1KKS01P tBuBCMx+QoNaNfa4MilCEGt+vQD4PGzB9sNOKzBz5dtYLpsG0q0OgEMCyhAGwHnZNXwp MLShDG2pWpcq2o7TYA6zzeXKeJ0x4jVwrKUrgPn5BRzTzv2Ra0dKWkqQiHqCfg7GwKnw HpJk7TR1ySkGp4jQqdtBf6oBwBHvXT6A7/d2ZBItu/hIQj5JquwK4wqyQkAoYkt2ZgR6 esKA== Received: by 10.68.232.194 with SMTP id tq2mr22783322pbc.111.1347891082238; Mon, 17 Sep 2012 07:11:22 -0700 (PDT) Received: from localhost ([2001:470:1f05:1640:7910:dfa3:3d6b:fc1c]) by mx.google.com with ESMTPS id qb2sm7017480pbb.15.2012.09.17.07.11.19 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 17 Sep 2012 07:11:21 -0700 (PDT) Date: Mon, 17 Sep 2012 07:11:19 -0700 From: Olof Johansson To: Stephen Rothwell Subject: Re: linux-next: build failure after merge of the final tree (arm-soc tree related) Message-ID: <20120917141119.GA18715@quad.lixom.net> References: <20120917212615.91bc134d237dcd5968f9f549@canb.auug.org.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120917212615.91bc134d237dcd5968f9f549@canb.auug.org.au> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQnAdsSpEPUXE1KagNaIepN1kCg67/v5JuZsM0Af5TZj0F+pfKIz6nsdeT4GUzYcbRvY6fto X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.160.49 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Samuel Ortiz , Arnd Bergmann , Tony Lindgren , linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi, On Mon, Sep 17, 2012 at 09:26:15PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/mfd/twl-core.c:49:22: fatal error: plat/cpu.h: No such file or directory > > Caused by commit 7d7e1eba7e92 ("ARM: OMAP2+: Prepare for irqs.h removal"). > > I have added the following patch to restrict this driver to ARM until it > is fixed: > > From: Stephen Rothwell > Date: Mon, 17 Sep 2012 21:18:21 +1000 > Subject: [PATCH] ARM: retrict TWL4030_CORE to ARM while it is broken > > Signed-off-by: Stephen Rothwell > --- > drivers/mfd/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index df850c4..af5e5b7 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -257,6 +257,7 @@ config MENELAUS > config TWL4030_CORE > bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support" > depends on I2C=y && GENERIC_HARDIRQS > + depends on ARM > select IRQ_DOMAIN > help > Say yes here if you have TWL4030 / TWL6030 family chip on your board. Gack. This will break on non-OMAP ARM platforms now too, so it needs to be depends on ARCH_OMAP instead of ARM. Tony, can I get an Acked-by so I can apply this to next/cleanup? Sam, if you prefer to apply it yourself, let me know. -Olof From 571a231c7f38b720001e1c7c3d5fb08fe265d03b Mon Sep 17 00:00:00 2001 From: Olof Johansson Date: Mon, 17 Sep 2012 07:05:04 -0700 Subject: [PATCH] MFD: make TWL4030_CORE depend on ARCH_OMAP It uses OMAP-only header files, and since it's an OMAP companion chip it doesn't really make sense to enable on other platforms. Signed-off-by: Olof Johansson --- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index b1a1462..d48083b 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -256,7 +256,7 @@ config MENELAUS config TWL4030_CORE bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support" - depends on I2C=y && GENERIC_HARDIRQS + depends on I2C=y && GENERIC_HARDIRQS && ARCH_OMAP select IRQ_DOMAIN help Say yes here if you have TWL4030 / TWL6030 family chip on your board.