From patchwork Wed Sep 19 19:09:52 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1480221 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 6B45D3FE79 for ; Wed, 19 Sep 2012 19:12:19 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TEPeu-0005w4-Sq; Wed, 19 Sep 2012 19:10:04 +0000 Received: from mail-ey0-f177.google.com ([209.85.215.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TEPeo-0005vm-Th for linux-arm-kernel@lists.infradead.org; Wed, 19 Sep 2012 19:09:59 +0000 Received: by eaai12 with SMTP id i12so422638eaa.36 for ; Wed, 19 Sep 2012 12:09:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=av0sakctiOtokrosWXLg3Km+fOUNY0V8u8suXRBeOOE=; b=IOL6VIReEEWR54aIlKnLgqSlTonomhd43vaucJB6sb9zDVFgT0dkaCf25heaWzmRrI YkYDTcP3DQKVe+6RWZS0SIQbRWqJXR++4V3IOZjJbdr+9QVstBTIOyxF65hsDjl6iy9H 0kucuo2xfmvXexkIJclydFwKpNXARW2gd9p771AVVSnqPwqqIF/5gVP8Cs6NOAQThlbd DUIHNlCsKRmZFNT9y0SwboLTkMMt6lS8bJZ5S1B+GFkVJBYK96xIPr7b45DOxMcB1mI6 GrFpoAQxuL4vcfCxWGqksn270csPlywDY4F61k9dxeH19AWZb+cjb/qTeEUkf5O1l5n9 aoJQ== Received: by 10.14.178.6 with SMTP id e6mr4162588eem.36.1348081796322; Wed, 19 Sep 2012 12:09:56 -0700 (PDT) Received: from gmail.com (ANantes-556-1-193-68.w109-211.abo.wanadoo.fr. [109.211.105.68]) by mx.google.com with ESMTPS id i41sm9528536eem.7.2012.09.19.12.09.54 (version=SSLv3 cipher=OTHER); Wed, 19 Sep 2012 12:09:55 -0700 (PDT) Date: Wed, 19 Sep 2012 21:09:52 +0200 From: Lee Jones To: Samuel Ortiz Subject: Re: [rtc-linux] [PATCH 1/1] drivers/rtc/rtc-ab8500.c: Revoke Device Tree enablement Message-ID: <20120919190952.GB2753@gmail.com> References: <1344527828-6283-1-git-send-email-lee.jones@linaro.org> <1344527828-6283-3-git-send-email-lee.jones@linaro.org> <20120831110818.GA5962@gmail.com> <20120919160302.GN28670@sortiz-mobl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120919160302.GN28670@sortiz-mobl> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.215.177 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ljkenny[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Alessandro Zummo , linus.walleij@stericsson.com, rtc-linux@googlegroups.com, Linus Walleij , linux-kernel@vger.kernel.org, arnd@arndb.de, STEricsson_nomadik_linux@list.st.com, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org > > > Sam: do you agree? > I'd love to see the patch first :) > Could you please bounce it to me ? I'll help. :) Author: Lee Jones Date: Thu Aug 9 13:28:19 2012 +0100 drivers/rtc/rtc-ab8500.c: Revoke Device Tree enablement All AB8500 devices are now registered via MFD core, so Device Tree capability is no longer required for probing. Here we pull the DT match table to ensure we're no longer probed during Device Tree start-up. CC: Alessandro Zummo CC: rtc-linux@googlegroups.com Acked-by: Linus Walleij Signed-off-by: Lee Jones diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c index bf3c2f6..2e5970f 100644 --- a/drivers/rtc/rtc-ab8500.c +++ b/drivers/rtc/rtc-ab8500.c @@ -462,16 +462,10 @@ static int __devexit ab8500_rtc_remove(struct platform_device *pdev) return 0; } -static const struct of_device_id ab8500_rtc_match[] = { - { .compatible = "stericsson,ab8500-rtc", }, - {} -}; - static struct platform_driver ab8500_rtc_driver = { .driver = { .name = "ab8500-rtc", .owner = THIS_MODULE, - .of_match_table = ab8500_rtc_match, }, .probe = ab8500_rtc_probe, .remove = __devexit_p(ab8500_rtc_remove),