From patchwork Fri Sep 28 20:13:34 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 1523361 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id E49153FE80 for ; Fri, 28 Sep 2012 20:15:25 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1THgwW-0007Pl-JQ; Fri, 28 Sep 2012 20:13:48 +0000 Received: from moutng.kundenserver.de ([212.227.126.187]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1THgwS-0007PX-CK for linux-arm-kernel@lists.infradead.org; Fri, 28 Sep 2012 20:13:45 +0000 Received: from klappe2.localnet (HSI-KBW-149-172-5-253.hsi13.kabel-badenwuerttemberg.de [149.172.5.253]) by mrelayeu.kundenserver.de (node=mreu3) with ESMTP (Nemesis) id 0MVnY3-1Swe4e1Lwd-00Z1tU; Fri, 28 Sep 2012 22:13:35 +0200 From: Arnd Bergmann To: Alessandro Rubini Subject: Re: [PATCH 13/24] ARM: nomadik: use __iomem pointers for MMIO Date: Fri, 28 Sep 2012 20:13:34 +0000 User-Agent: KMail/1.12.2 (Linux/3.5.0; KDE/4.3.2; x86_64; ; ) References: <1347658492-11608-14-git-send-email-arnd@arndb.de> <1347658492-11608-1-git-send-email-arnd@arndb.de> <20120915113356.GA31284@mail.gnudd.com> In-Reply-To: <20120915113356.GA31284@mail.gnudd.com> MIME-Version: 1.0 Message-Id: <201209282013.34638.arnd@arndb.de> X-Provags-ID: V02:K0:ujdaiWU+PKWdyi4IK8ZM1U21ZiO8Z5k2wwKhArTi0Mu 4GINIwCyqGJ1g7e/jpg31dJSv4DKjTESquA6kspVjKhQ14J1Tk zdYzIiYenwTGy0yZtnVUoKiMMqzsaLn7sl21GcCBYlaP3o4Zh7 4f9nk30V4WpwlruZzXgRQMeesN4JZiNd7zy4XfOiCVYLnBzeW0 OXWy6yrvZa2H7AKKgLHEZ9bV/irUa8ewxTSbBRBKEBMhF05tm6 KHjjx6XMSxlVtmRT4VJYXo4oHFNMnlSgcxOy0IFrn5UOXlqKQF 6sPwWvoWhl2RF1goetLqpV/efGSR2GlZ/Sqx1SS05Mq6B7KA/u F5wYWsOB2QaV0QwJrsS4= X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.187 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: nico@linaro.org, linus.walleij@linaro.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, rmk+kernel@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Saturday 15 September 2012, Alessandro Rubini wrote: > > - .options = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING \ > > - | NAND_NO_READRDY, > > + .options = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING, > > This is not clear to me, and it looks unrelated. But I admit I haven't > studied what happened to NAND_NO_READRDY lately. > > If this hunk is desired and not just something else > that slipped in, then > > Acked-by: Alessandro Rubini I've added the patch below to the next/fixes-non-critical branch now, to avoid the build error in linux-next. Arnd From 06f8ab806e9e180966e812f6e47a0735bba638d8 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Sun, 23 Sep 2012 22:57:22 +0000 Subject: [PATCH] ARM: nomadik: remove NAND_NO_READRDY use The nhk8815 board files uses NAND_NO_READRDY in its platform data, but this macro is getting removed because it was not being used anywhere. Without this patch, building nhk8815_defconfig results in: arch/arm/mach-nomadik/board-nhk8815.c:118:6: error: 'NAND_NO_READRDY' undeclared here (not in a function) Signed-off-by: Arnd Bergmann Cc: Alessandro Rubini Cc: Linus Walleij diff --git a/arch/arm/mach-nomadik/board-nhk8815.c b/arch/arm/mach-nomadik/board-nhk8815.c index 381c080..92a0026 100644 --- a/arch/arm/mach-nomadik/board-nhk8815.c +++ b/arch/arm/mach-nomadik/board-nhk8815.c @@ -112,8 +112,7 @@ static struct mtd_partition nhk8815_partitions[] = { static struct nomadik_nand_platform_data nhk8815_nand_data = { .parts = nhk8815_partitions, .nparts = ARRAY_SIZE(nhk8815_partitions), - .options = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING \ - | NAND_NO_READRDY, + .options = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING, .init = nhk8815_nand_init, };