From patchwork Thu Oct 18 15:47:31 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Domenico Andreoli X-Patchwork-Id: 1611701 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 081D0DFB34 for ; Thu, 18 Oct 2012 15:50:31 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TOsK2-0007K7-Rp; Thu, 18 Oct 2012 15:47:46 +0000 Received: from mail-ee0-f49.google.com ([74.125.83.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TOsJz-0007Jt-UI for linux-arm-kernel@lists.infradead.org; Thu, 18 Oct 2012 15:47:44 +0000 Received: by mail-ee0-f49.google.com with SMTP id c1so4565368eek.36 for ; Thu, 18 Oct 2012 08:47:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-type:content-disposition :in-reply-to; bh=5oi3DMnn15SJ9WXHEbTY2wWUAL+YrFHZVSlDz9+4hR0=; b=AANaFmCJxfRBdM1e9HAn2AVW+FU1CjWKiL/P7u4ovDLZnyXx0wfUwWFTilO3ZBLal0 7B96i2JgSHpQld/k/dRaDeXlUPLJ/44hN1ATFt6nOluHQEd5sTRnW1iO1XyuLGfyB67k fGnrAKxTX6vaALwc+qdgyMzgXCI8s5LNq9OC7H14pG3gbGjhbT5/k8bi96egcnRZv87x wyLNUQ4e7/+KFWngBc1lkcwai/V/G5bFTSKRBW2/47b2LvMmFQ3J6gDlz/pjAQ8vXbzv zyKrT7V+030Q2lDN0x4Yp+7ww88aDVphFtO8qWLKOoUCTJ2KoTHbaF2oAt+g1M1xpUo7 9k7w== Received: by 10.14.220.71 with SMTP id n47mr32110381eep.26.1350575260951; Thu, 18 Oct 2012 08:47:40 -0700 (PDT) Received: from glitch (178-85-163-250.dynamic.upc.nl. [178.85.163.250]) by mx.google.com with ESMTPS id v3sm40418250een.1.2012.10.18.08.47.33 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 18 Oct 2012 08:47:38 -0700 (PDT) Received: by glitch (Postfix, from userid 1000) id 066973C0165; Thu, 18 Oct 2012 17:47:31 +0200 (CEST) Date: Thu, 18 Oct 2012 17:47:31 +0200 From: Domenico Andreoli To: Arnd Bergmann Subject: Re: [PATCH v2 1/5] ARM: bcm476x: Add platform infrastructure Message-ID: <20121018154731.GA9344@glitch> Mail-Followup-To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Domenico Andreoli , Olof Johansson References: <20121014221450.866288977@gmail.com> <20121014223023.611069832@gmail.com> <201210181348.02110.arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201210181348.02110.arnd@arndb.de> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [74.125.83.49 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (cavokz[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Domenico Andreoli , Olof Johansson , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Thu, Oct 18, 2012 at 01:48:01PM +0000, Arnd Bergmann wrote: > On Sunday 14 October 2012, Domenico Andreoli wrote: > > From: Domenico Andreoli > > > > Platform infrastructure for the Broadcom BCM476x ARMv6 SoCs. > > Hi Domenico, Hi Arnd, > All your patches look good to me now, except for one thing throughout > the bindings: > > > Index: b/Documentation/devicetree/bindings/arm/bcm476x.txt > > =================================================================== > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/bcm476x.txt > > @@ -0,0 +1,15 @@ > > +Broadcom BCM4760 and BCM4761 SoCs device tree bindings > > +------------------------------------------------------ > > + > > +Boards with the BCM4760 SoC shall have the following properties: > > + > > +Required root node property: > > + > > +compatible = "brcm,bcm4760"; > > + > > + > > +Boards with the BCM4761 SoC shall have the following properties: > > + > > +Required root node property: > > + > > +compatible = "brcm,bcm4761"; > > I probably wasn't clear enough with my request to have specific > chip identifiers in the device tree "compatible" nodes. The idea > generally is that for completely identical hardware blocks, you > just need to put the first known variant into the driver, e.g. > "brcm,bcm4760-system-timer", and in case of a later chip that > is compatible with it, you list both "brcm,bcm4760-system-timer" > and "brcm,bcm4761-system-timer" in the compatible property of the > device tree. The way you did it is also correct and works, but > is a bit less common. > > How do you want to merge your patches? The preferred way from > our side is to get a pull request from you sent to arm@kernel.org > with Cc to the linux-arm-kernel mailing list, but we can also > pick up the patches separately if necessary. so the above becomes: and the dt_mach in the board file is left only with "brcm,bcm4760" until required otherwise. The same applies to drivers. Does the order matter? > For the patches that go into different directories like the clk > and the clocksource drivers, please Cc the respective subsystem > maintainers and ask them for an Ack. It certainly makes sense > for a new platform port to get merged through the arm-soc tree, > but any future improvements should normally just go through the > subsystem trees. I'd prefer patches but only because I've not any public git repository. If the git pull is much more preferred, I surely can manage it. Thanks, Domenico Index: b/Documentation/devicetree/bindings/arm/bcm476x.txt =================================================================== --- /dev/null +++ b/Documentation/devicetree/bindings/arm/bcm476x.txt @@ -0,0 +1,15 @@ +Broadcom BCM4760 and BCM4761 SoCs device tree bindings +------------------------------------------------------ + +Boards with the BCM4760 SoC shall have the following properties: + +Required root node property: + +compatible = "brcm,bcm4760"; + + +Boards with the BCM4761 SoC shall have the following properties: + +Required root node property: + +compatible = "brcm,bcm4760", "brcm,bcm4761";