From patchwork Fri Oct 26 22:36:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 1654261 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id EB730DF2F6 for ; Fri, 26 Oct 2012 22:39:19 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TRsWW-0005HJ-35; Fri, 26 Oct 2012 22:37:04 +0000 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TRsWR-0005H5-DH for linux-arm-kernel@lists.infradead.org; Fri, 26 Oct 2012 22:37:01 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 9ED1BF084D; Sat, 27 Oct 2012 00:36:53 +0200 (CEST) Date: Sat, 27 Oct 2012 00:36:54 +0200 From: Pavel Machek To: Russell King - ARM Linux Subject: Re: [PATCH] arm: socfpga: fix build break for allyesconfig Message-ID: <20121026223654.GB2597@elf.ucw.cz> References: <1351289861-16297-1-git-send-email-dinguyen@altera.com> <20121026215136.GC21164@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20121026215136.GC21164@n2100.arm.linux.org.uk> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Note: CRM114 invocation failed X-Spam-Score: 1.1 (+) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (1.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- 3.0 KHOP_BIG_TO_CC Sent to 10+ recipients instaed of Bcc or a list -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [195.113.26.193 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: thomas.petazzoni@free-electrons.com, dinh.linux@gmail.com, wd@denx.de, arnd@arndb.de, rob.herring@calxeda.com, arm@kernel.org, dinguyen@altera.com, atull@altera.com, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi! > > index 17d6eaf..9031a3c 100644 > > --- a/arch/arm/mach-socfpga/headsmp.S > > +++ b/arch/arm/mach-socfpga/headsmp.S > > @@ -15,8 +15,10 @@ > > #define CPU1_START_ADDR 0xffd08010 > > > > ENTRY(secondary_trampoline) > > +#if __LINUX_ARM_ARCH__ >= 7 > > movw r0, #:lower16:CPU1_START_ADDR > > movt r0, #:upper16:CPU1_START_ADDR > > +#endif > > If you do that, then it effectively means you don't need these instructions > and you might as well just delete them... but looking at the following one: > > > ldr r1, [r0] > > it's clear that you do need it. So you need to find a different solution. > If the above assembly file can only run on ARMv7, consider putting > > .march armv7 > > or similar before it. My version of gas does not seem to recognize .march ( AS arch/arm/mach-socfpga/headsmp.o arch/arm/mach-socfpga/headsmp.S: Assembler messages: arch/arm/mach-socfpga/headsmp.S:17: Error: unknown pseudo-op: `.march' arch/arm/mach-socfpga/headsmp.S:24: Error: selected processor does not support `movw r0,#:lower16:(0xffd08000+0x10)' arch/arm/mach-socfpga/headsmp.S:25: Error: selected processor does not support `movt r0,#:upper16:(0xffd08000+0x10)' ) This seems to do the trick: Fix compilation with CPU_V6 option. Signed-off-by: Pavel Machek diff --git a/arch/arm/mach-socfpga/Makefile b/arch/arm/mach-socfpga/Makefile index a0fc372..6956e93 100644 --- a/arch/arm/mach-socfpga/Makefile +++ b/arch/arm/mach-socfpga/Makefile @@ -4,3 +4,5 @@ obj-y := socfpga.o obj-$(CONFIG_SMP) += headsmp.o platsmp.o hotplug.o + +AFLAGS_headsmp.o := -Wa,-march=armv7-a