From patchwork Fri Oct 26 23:00:53 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 1654431 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 60D0DDF2F6 for ; Fri, 26 Oct 2012 23:03:13 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TRstc-0006dW-AP; Fri, 26 Oct 2012 23:00:56 +0000 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TRstZ-0006dI-1m for linux-arm-kernel@lists.infradead.org; Fri, 26 Oct 2012 23:00:53 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id CB2C2F0688; Sat, 27 Oct 2012 01:00:51 +0200 (CEST) Date: Sat, 27 Oct 2012 01:00:53 +0200 From: Pavel Machek To: Russell King - ARM Linux Subject: Re: [PATCH] arm: socfpga: fix build break for allyesconfig Message-ID: <20121026230052.GA24573@elf.ucw.cz> References: <1351289861-16297-1-git-send-email-dinguyen@altera.com> <20121026215136.GC21164@n2100.arm.linux.org.uk> <20121026223654.GB2597@elf.ucw.cz> <20121026224358.GD21164@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20121026224358.GD21164@n2100.arm.linux.org.uk> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Note: CRM114 invocation failed X-Spam-Score: 1.1 (+) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (1.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [195.113.26.193 listed in list.dnswl.org] 3.0 KHOP_BIG_TO_CC Sent to 10+ recipients instaed of Bcc or a list -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: thomas.petazzoni@free-electrons.com, dinh.linux@gmail.com, wd@denx.de, arnd@arndb.de, rob.herring@calxeda.com, arm@kernel.org, dinguyen@altera.com, atull@altera.com, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi! > > > If the above assembly file can only run on ARMv7, consider putting > > > > > > .march armv7 > > > > > > or similar before it. > > > > My version of gas does not seem to recognize .march > > Ah, that's because it's .arch not .march. Please could you check with > .arch instead. If proven successful we should move the existing > AFLAGS_xxx.o Makefile stuff into the assembly files concerned. .arch armv7 results in arch/arm/mach-socfpga/headsmp.S:21: Error: attempt to use an ARM instruction on a Thumb-only processor -- `movw r0,#:lower16:(0xffd08000+0x10)' ... Using .arch armv7-a indeed works and is a very nice solution. Signed-off-by: Pavel Machek --- a/arch/arm/mach-socfpga/headsmp.S +++ b/arch/arm/mach-socfpga/headsmp.S @@ -11,6 +11,7 @@ #include __INIT + .arch armv7-a #define HPS_SYSMGR_ADDRESS 0xffd08000 #define CONFIG_SYSTEM_MANAGER HPS_SYSMGR_ADDRESS