From patchwork Fri Nov 9 22:18:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Turquette X-Patchwork-Id: 1722501 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 88129DF264 for ; Fri, 9 Nov 2012 22:20:23 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TWwuM-0006iB-Ci; Fri, 09 Nov 2012 22:18:38 +0000 Received: from bear.ext.ti.com ([192.94.94.41]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TWwuI-0006hW-9H for linux-arm-kernel@lists.infradead.org; Fri, 09 Nov 2012 22:18:35 +0000 Received: from dlelxv30.itg.ti.com ([172.17.2.17]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id qA9MIV9c013045; Fri, 9 Nov 2012 16:18:31 -0600 Received: from DLEE74.ent.ti.com (dlee74.ent.ti.com [157.170.170.8]) by dlelxv30.itg.ti.com (8.13.8/8.13.8) with ESMTP id qA9MIVhM007561; Fri, 9 Nov 2012 16:18:31 -0600 Received: from localhost (10.188.36.112) by DLEE74.ent.ti.com (157.170.170.8) with Microsoft SMTP Server (TLS) id 14.1.323.3; Fri, 9 Nov 2012 16:18:30 -0600 MIME-Version: 1.0 To: Paul Walmsley , From: Mike Turquette In-Reply-To: References: <1352337181-29427-1-git-send-email-mturquette@ti.com> Message-ID: <20121109221813.17381.31431@nucleus> User-Agent: alot/0.3.2+ Subject: Re: [PATCH v2 00/26] Move OMAP2+ over to common clk framework Date: Fri, 9 Nov 2012 14:18:13 -0800 X-Originating-IP: [10.188.36.112] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121109_171834_447766_C46EEDAD X-CRM114-Status: GOOD ( 21.75 ) X-Spam-Score: -7.6 (-------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-7.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [192.94.94.41 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@linaro.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Quoting Paul Walmsley (2012-11-09 13:12:24) > Hi > > With the fixes that have been posted, this is testing clean here. Mike > and Rajendra have put in months of work on these patches under > often-difficult conditions, and it's really great that we've arrived at > this point with zero obvious remaining regressions from the current code. > > The branch has been posted for the time being at > git://git.pwsan.com/linux-2.6 in the branch 'common_clk_devel_3.8', with > the head at commit 376676b429cb6dc95c39cdac82b2be816ea22893, in case > anyone else wants to try it. > Thanks a lot Paul. You put in a lot of work on this series as well and that should not go unnoticed. I'm truly happy to see this series come together. > Anyway, barring any further regressions that haven't reared their ugly > heads yet, and barring anything truly horrible in the code or data that > I've missed so far, will take this branch from here. It still needs some > more work before it's ready to merge. The clockdomain usecounting fix > patch needs to be split and moved earlier in the patch stack so 'git > bisect' doesn't result in warnings and broken PM on OMAP3. And it all is > going to be rebased on the second set of PRCM cleanup patches at commit > b99db36cdf37decb1b5575c5f293d170cbbc53d6, which I'm assuming Tony is > planning to pull. Then will plan to send that pull request to Tony. > I just did some more testing on your branch and everything looks great. The only thing that caught my eye was using the clk-private.h header in the top-most patch. The following patch will help me sleep better at night: Tested on 3530 ES3.0 Beagleboard, boot + suspend/resume. Regards, Mike > Then after that, if there's still time to merge some of the clock changes > that have showed up on the lists for 3.8, those will get stacked onto a > topic branch based on the branch that's sent to Tony. > > > - Paul diff --git a/arch/arm/mach-omap2/clockdomain.c b/arch/arm/mach-omap2/clockdomain.c index ba4d14c..3848735 100644 --- a/arch/arm/mach-omap2/clockdomain.c +++ b/arch/arm/mach-omap2/clockdomain.c @@ -22,7 +22,7 @@ #include #include #include -#include +#include #include