From patchwork Mon Dec 17 15:14:46 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 1887661 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 2C29C40DEC for ; Mon, 17 Dec 2012 15:18:42 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TkcQ4-00008v-Sw; Mon, 17 Dec 2012 15:15:54 +0000 Received: from db3ehsobe006.messaging.microsoft.com ([213.199.154.144] helo=db3outboundpool.messaging.microsoft.com) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TkcPn-00005P-CT for linux-arm-kernel@lists.infradead.org; Mon, 17 Dec 2012 15:15:37 +0000 Received: from mail68-db3-R.bigfish.com (10.3.81.239) by DB3EHSOBE001.bigfish.com (10.3.84.21) with Microsoft SMTP Server id 14.1.225.23; Mon, 17 Dec 2012 15:15:32 +0000 Received: from mail68-db3 (localhost [127.0.0.1]) by mail68-db3-R.bigfish.com (Postfix) with ESMTP id DC4114003B2; Mon, 17 Dec 2012 15:15:32 +0000 (UTC) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI X-SpamScore: -10 X-BigFish: VS-10(zz98dI1818P1432Izz1de0h1202h1e76h1d1ah1d2ahz8dhzz2dh87h2a8h668h839h944hd25hf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h1155h) X-FB-DOMAIN-IP-MATCH: fail Received: from mail68-db3 (localhost.localdomain [127.0.0.1]) by mail68-db3 (MessageSwitch) id 1355757293550914_10869; Mon, 17 Dec 2012 15:14:53 +0000 (UTC) Received: from DB3EHSMHS004.bigfish.com (unknown [10.3.81.249]) by mail68-db3.bigfish.com (Postfix) with ESMTP id 83ABD1E0119; Mon, 17 Dec 2012 15:14:53 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by DB3EHSMHS004.bigfish.com (10.3.87.104) with Microsoft SMTP Server (TLS) id 14.1.225.23; Mon, 17 Dec 2012 15:14:47 +0000 Received: from tx30smr01.am.freescale.net (10.81.153.31) by 039-SN1MMR1-002.039d.mgd.msft.net (10.84.1.15) with Microsoft SMTP Server (TLS) id 14.2.318.3; Mon, 17 Dec 2012 15:14:46 +0000 Received: from S2101-09.ap.freescale.net ([10.192.185.103]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id qBHFEXsT019641; Mon, 17 Dec 2012 08:14:34 -0700 Date: Mon, 17 Dec 2012 23:14:46 +0800 From: Shawn Guo To: Frank Li Subject: Re: [PATCH 4/4] FEC: Add time stamping code and a PTP hardware clock Message-ID: <20121217151445.GA17907@S2101-09.ap.freescale.net> References: <1351657531-25989-1-git-send-email-Frank.Li@freescale.com> <20121217091345.GA753@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: sigmatel.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121217_101536_652928_62B20EA3 X-CRM114-Status: GOOD ( 13.61 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [213.199.154.144 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Frank Li , netdev@vger.kernel.org, Sascha Hauer , lznua@gmail.com, davem@davemloft.net, richardcochran@gmail.com, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi Sascha, On Mon, Dec 17, 2012 at 10:48:31PM +0800, Frank Li wrote: > > I don't know how to continue from here. Since the whole patch doesn't > > seem to reviewed very much I tend to say we should revert it for now and > > let Frank redo it for the next merge window. > > > > Other opinions? > > Can we just disable CONFIG_FEC_PTP defaut instead of revert whole patch? > To be clear, the following is what Frank meant. Since Frank is out of office for some time, I will send this immediate fix to David, if you are fine with it. Shawn diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig index 5ba6e1c..d1edb2e 100644 --- a/drivers/net/ethernet/freescale/Kconfig +++ b/drivers/net/ethernet/freescale/Kconfig @@ -96,7 +96,6 @@ config FEC_PTP bool "PTP Hardware Clock (PHC)" depends on FEC && ARCH_MXC select PTP_1588_CLOCK - default y if SOC_IMX6Q --help--- Say Y here if you want to use PTP Hardware Clock (PHC) in the driver. Only the basic clock operations have been implemented.