From patchwork Sun Jan 6 03:34:55 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Guinot X-Patchwork-Id: 1937021 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id AE0BEDF2A2 for ; Sun, 6 Jan 2013 03:46:59 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Trh8X-0001HE-Nm; Sun, 06 Jan 2013 03:43:02 +0000 Received: from vm1.sequanux.org ([188.165.36.56]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Trh8U-0001Gv-7c for linux-arm-kernel@lists.infradead.org; Sun, 06 Jan 2013 03:42:59 +0000 Received: from localhost (softwrestling.org [188.165.144.248]) by vm1.sequanux.org (Postfix) with ESMTPSA id A6D6D1080BB; Sun, 6 Jan 2013 04:42:54 +0100 (CET) Date: Sun, 6 Jan 2013 04:34:55 +0100 From: Simon Guinot To: Andrew Lunn , Jason Cooper Subject: Reboot hangs on Kirkwood ns2 boards with 3.8-rc2 Message-ID: <20130106033455.GH1357@kw.sim.vm.gnt> MIME-Version: 1.0 User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130105_224258_625697_C7102762 X-CRM114-Status: GOOD ( 14.37 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux ARM X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi Andrew and Jason, While testing 3.8-rc2 on the ns2 boards (DT based), I noticed that reboot is not working. After issuing a reboot, the kernel hangs. No error messages are displayed. Moreover, on my non-DT Kirkwood boards, reboot is working as expected. Am I the only one to experiment this issue ? After some painful investigations, I found out that my problem may be related with the device tree binding addition to the driver ehci-orion. I still don't understand exactly why, but if I add the "clocks" property to the ehci node, reboot works. Do you have any idea ? Regards, Simon diff --git a/arch/arm/boot/dts/kirkwood.dtsi b/arch/arm/boot/dts/kirkwood.dtsi index 7735cee..110d6cb 100644 --- a/arch/arm/boot/dts/kirkwood.dtsi +++ b/arch/arm/boot/dts/kirkwood.dtsi @@ -144,6 +144,7 @@ compatible = "marvell,orion-ehci"; reg = <0x50000 0x1000>; interrupts = <19>; + clocks = <&gate_clk 3>; status = "okay"; };