From patchwork Tue Jan 8 20:38:53 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Greer X-Patchwork-Id: 1948081 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 1E2863FC5A for ; Tue, 8 Jan 2013 20:41:53 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Tsfwp-0003SR-HB; Tue, 08 Jan 2013 20:38:59 +0000 Received: from m1plsmtpa01-04.prod.mesa1.secureserver.net ([64.202.165.6]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Tsfwm-0003Ru-Bm for linux-arm-kernel@lists.infradead.org; Tue, 08 Jan 2013 20:38:57 +0000 Received: from blue.animalcreek.com ([68.3.93.7]) by m1plsmtpa01-04.prod.mesa1.secureserver.net with id lYet1k00K09Xvcc01Yet1E; Tue, 08 Jan 2013 13:38:54 -0700 Received: by blue.animalcreek.com (Postfix, from userid 1001) id 971E965A5F; Tue, 8 Jan 2013 13:38:53 -0700 (MST) Date: Tue, 8 Jan 2013 13:38:53 -0700 From: "Mark A. Greer" To: Paul Walmsley Subject: Re: [PATCH 00/15] OMAP SHAM & AES Crypto Updates Message-ID: <20130108203853.GB1876@animalcreek.com> References: <1356107295-11121-1-git-send-email-mgreer@animalcreek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Animal Creek Technologies, Inc. User-Agent: Mutt/1.5.20 (2009-06-14) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130108_153856_573422_D660E554 X-CRM114-Status: GOOD ( 21.12 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [64.202.165.6 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Sun, Dec 23, 2012 at 08:40:43AM +0000, Paul Walmsley wrote: > Hi Mark, Hi Paul. > On Fri, 21 Dec 2012, Mark A. Greer wrote: > > > From: "Mark A. Greer" > > > > [This series supersedes the hwmod related patches sent in the > > "crypto: omap-sham updates" and "crypto: omap-aes updates" > > series a few weeks ago.] > > > > This series adds hwmod support for the OMAP SHAM and AES > > modules on OMAP2, OMAP3, and OMAP4/AM33XX SoCs. It also > > adds device tree info for those modules. > > Thanks for working on this, this will get us much closer to being able to > convert the hwmod code into an OMAP bus. I haven't looked closely at > these patches yet, but a few comments/questions: > - The patch series causes AM3517/3505 to crash. I'd guess this is due to > the SHAM/AES modules being initialized on those chips, but they probably > don't exist there. Can you change the initialization for those on OMAP3 > to only take place on OMAP34xx/36xx GP? I guess you'd need to create new > lists for those in the hwmod init. All am35xx GPs have the SHAM and AES modules except some very old ones. I've been told that there should be very few of the "old" ones around (I don't know how to differentiate them). We're likely safe since the SHAM & AES modules are not enabled in omap2plus_defconfig so nobody should be enabling them on an am35xx unless they know that they have the modules. Do you agree? The issue that you're likely running into is that 'CK_AM35XX' needs to be added for aes2_ick & sha12_ick in cclock3xxx_data.c. The following patch should fix it (applies to my submitted/crypto/hwmod branch): Please let me know if this patch works for you and, if it does, I'll respin my patches to add those changes. Thanks, Mark diff --git a/arch/arm/mach-omap2/cclock3xxx_data.c b/arch/arm/mach-omap2/cclock3xxx_data.c index 582b055..aa5bdf6 100644 --- a/arch/arm/mach-omap2/cclock3xxx_data.c +++ b/arch/arm/mach-omap2/cclock3xxx_data.c @@ -3332,10 +3332,10 @@ static struct omap_clk omap3xxx_clks[] = { CLK("omap_hsmmc.2", "ick", &mmchs3_ick, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), CLK(NULL, "mmchs3_ick", &mmchs3_ick, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), CLK(NULL, "icr_ick", &icr_ick, CK_34XX | CK_36XX), - CLK("omap-aes", "ick", &aes2_ick, CK_34XX | CK_36XX), - CLK(NULL, "aes2_ick", &aes2_ick, CK_34XX | CK_36XX), - CLK("omap-sham", "ick", &sha12_ick, CK_34XX | CK_36XX), - CLK(NULL, "sha12_ick", &sha12_ick, CK_34XX | CK_36XX), + CLK("omap-aes", "ick", &aes2_ick, CK_34XX | CK_AM35XX | CK_36XX), + CLK(NULL, "aes2_ick", &aes2_ick, CK_34XX | CK_AM35XX | CK_36XX), + CLK("omap-sham", "ick", &sha12_ick, CK_34XX | CK_AM35XX | CK_36XX), + CLK(NULL, "sha12_ick", &sha12_ick, CK_34XX | CK_AM35XX | CK_36XX), CLK(NULL, "des2_ick", &des2_ick, CK_34XX | CK_36XX), CLK("omap_hsmmc.1", "ick", &mmchs2_ick, CK_3XXX), CLK("omap_hsmmc.0", "ick", &mmchs1_ick, CK_3XXX),