From patchwork Fri Jan 18 21:09:28 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Turquette X-Patchwork-Id: 2004491 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 475FEDF280 for ; Fri, 18 Jan 2013 21:12:05 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TwJBw-0000OI-KI; Fri, 18 Jan 2013 21:09:36 +0000 Received: from mail-pb0-f43.google.com ([209.85.160.43]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TwJBu-0000Ne-8a for linux-arm-kernel@lists.infradead.org; Fri, 18 Jan 2013 21:09:34 +0000 Received: by mail-pb0-f43.google.com with SMTP id jt11so884897pbb.2 for ; Fri, 18 Jan 2013 13:09:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:content-type:mime-version:content-transfer-encoding:to :from:in-reply-to:cc:references:message-id:user-agent:subject:date :x-gm-message-state; bh=4WY/kkenJcUu7s7foNu3NQQLPHVOartyBFCeNPuk33w=; b=I30Gvj3tgKCgf97qFqQz1ojUdv5voQWv8v95I+GQlzdv3OMhkew2xqjf7YRFF7GTfc o+iooHYZgWAs8/byIPuXErmaolVm6L5JSppH4cVARbwG2bkSLa5Zhi2EVuFb+yGlTjGR a1kUOECi9+9s3cIvYvIlxqbzo7U86aYm+43iQf9qXDe8rygtYTfCRDVbe4yRzrQAugS5 JsYHRXJeW9yPaI4tSt2q1hkqm92C1n2uOhCzMMCqZj8nKF15qyVhe/mdcFgqJnNLy617 y8c1kZGQBu7o5heVwAtMkTdhQFpqCRRItr34tNCm2wx1OV0jo1eaRNj9KQdM4YVB5Wd/ Cojw== X-Received: by 10.68.137.167 with SMTP id qj7mr27329910pbb.148.1358543372777; Fri, 18 Jan 2013 13:09:32 -0800 (PST) Received: from localhost (adsl-69-228-81-205.dsl.pltn13.pacbell.net. [69.228.81.205]) by mx.google.com with ESMTPS id z10sm4050106pax.38.2013.01.18.13.09.30 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 18 Jan 2013 13:09:31 -0800 (PST) MIME-Version: 1.0 To: Prashant Gaikwad , From: Mike Turquette In-Reply-To: <1357278706-28149-1-git-send-email-pgaikwad@nvidia.com> References: <1357278706-28149-1-git-send-email-pgaikwad@nvidia.com> Message-ID: <20130118210928.3982.75303@quantum> User-Agent: alot/0.3.3+ Subject: Re: [PATCH 1/2] clk: Add composite clock type Date: Fri, 18 Jan 2013 13:09:28 -0800 X-Gm-Message-State: ALoCoQlel/k5PuEwYFgXjF/cgr8leMhRLZv0OQ/C0C5KLorGkdB0+F4Ft0b98Qie9p/KPxWQ5X9b X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130118_160934_379794_A883E422 X-CRM114-Status: GOOD ( 14.89 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.160.43 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Prashant Gaikwad , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Quoting Prashant Gaikwad (2013-01-03 21:51:45) > Not all clocks are required to be decomposed into basic clock > types but at the same time want to use the functionality > provided by these basic clock types instead of duplicating. > > For example, Tegra SoC has ~100 clocks which can be decomposed > into Mux -> Div -> Gate clock types making the clock count to > ~300. Also, parent change operation can not be performed on gate > clock which forces to use mux clock in driver if want to change > the parent. > > Instead aggregate the basic clock types functionality into one > clock and just use this clock for all operations. This clock > type re-uses the functionality of basic clock types and not > limited to basic clock types but any hardware-specific > implementation. > > Signed-off-by: Prashant Gaikwad Hi Prashant, I'm OK with the general concept of the composite clock, but a V2 patch addressing all of the comments needs to be submitted first. You might base your patch on top of the following cleanup: From 135a829744067cb825b48f7422e22861e57d5ecd Mon Sep 17 00:00:00 2001 From: Mike Turquette Date: Fri, 18 Jan 2013 13:00:05 -0800 Subject: [PATCH] clk: beautify Makefile The list of common clock types was getting a bit unmanageable. This patch puts only one file on each line and reorders the object files alphabetically. Also a newline is added to separate the sections. Reported-by: Stephen Boyd Cc: Prashant Gaikwad Signed-off-by: Mike Turquette --- drivers/clk/Makefile | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index ee90e87..e73b1d6 100644 --- a/drivers/clk/Makefile +++ b/drivers/clk/Makefile @@ -1,8 +1,13 @@ # common clock types obj-$(CONFIG_HAVE_CLK) += clk-devres.o obj-$(CONFIG_CLKDEV_LOOKUP) += clkdev.o -obj-$(CONFIG_COMMON_CLK) += clk.o clk-fixed-rate.o clk-gate.o \ - clk-mux.o clk-divider.o clk-fixed-factor.o +obj-$(CONFIG_COMMON_CLK) += clk.o +obj-$(CONFIG_COMMON_CLK) += clk-divider.o +obj-$(CONFIG_COMMON_CLK) += clk-fixed-factor.o +obj-$(CONFIG_COMMON_CLK) += clk-fixed-rate.o +obj-$(CONFIG_COMMON_CLK) += clk-gate.o +obj-$(CONFIG_COMMON_CLK) += clk-mux.o + # SoCs specific obj-$(CONFIG_ARCH_BCM2835) += clk-bcm2835.o obj-$(CONFIG_ARCH_NOMADIK) += clk-nomadik.o