| Message ID | 20130122074518.13822.86992.stgit@srivatsabhat.in.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jan 22, 2013 at 01:15:22PM +0530, Srivatsa S. Bhat wrote: > ... and also cleanup a comment that refers to CPU hotplug being dependent on > stop_machine(). > > Cc: David Howells <dhowells@redhat.com> > Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> (Hey, I thought I owed myself an easy one!) > --- > > include/linux/stop_machine.h | 2 +- > init/Kconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/stop_machine.h b/include/linux/stop_machine.h > index 3b5e910..ce2d3c4 100644 > --- a/include/linux/stop_machine.h > +++ b/include/linux/stop_machine.h > @@ -120,7 +120,7 @@ int stop_machine(int (*fn)(void *), void *data, const struct cpumask *cpus); > * @cpus: the cpus to run the @fn() on (NULL = any online cpu) > * > * Description: This is a special version of the above, which assumes cpus > - * won't come or go while it's being called. Used by hotplug cpu. > + * won't come or go while it's being called. > */ > int __stop_machine(int (*fn)(void *), void *data, const struct cpumask *cpus); > > diff --git a/init/Kconfig b/init/Kconfig > index be8b7f5..048a0c5 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -1711,7 +1711,7 @@ config INIT_ALL_POSSIBLE > config STOP_MACHINE > bool > default y > - depends on (SMP && MODULE_UNLOAD) || HOTPLUG_CPU > + depends on (SMP && MODULE_UNLOAD) > help > Need stop_machine() primitive. > >
On 02/09/2013 05:45 AM, Paul E. McKenney wrote: > On Tue, Jan 22, 2013 at 01:15:22PM +0530, Srivatsa S. Bhat wrote: >> ... and also cleanup a comment that refers to CPU hotplug being dependent on >> stop_machine(). >> >> Cc: David Howells <dhowells@redhat.com> >> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> > > Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > > (Hey, I thought I owed myself an easy one!) > Haha ;-) Regards, Srivatsa S. Bhat >> --- >> >> include/linux/stop_machine.h | 2 +- >> init/Kconfig | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/include/linux/stop_machine.h b/include/linux/stop_machine.h >> index 3b5e910..ce2d3c4 100644 >> --- a/include/linux/stop_machine.h >> +++ b/include/linux/stop_machine.h >> @@ -120,7 +120,7 @@ int stop_machine(int (*fn)(void *), void *data, const struct cpumask *cpus); >> * @cpus: the cpus to run the @fn() on (NULL = any online cpu) >> * >> * Description: This is a special version of the above, which assumes cpus >> - * won't come or go while it's being called. Used by hotplug cpu. >> + * won't come or go while it's being called. >> */ >> int __stop_machine(int (*fn)(void *), void *data, const struct cpumask *cpus); >> >> diff --git a/init/Kconfig b/init/Kconfig >> index be8b7f5..048a0c5 100644 >> --- a/init/Kconfig >> +++ b/init/Kconfig >> @@ -1711,7 +1711,7 @@ config INIT_ALL_POSSIBLE >> config STOP_MACHINE >> bool >> default y >> - depends on (SMP && MODULE_UNLOAD) || HOTPLUG_CPU >> + depends on (SMP && MODULE_UNLOAD) >> help >> Need stop_machine() primitive. >> >>
diff --git a/include/linux/stop_machine.h b/include/linux/stop_machine.h index 3b5e910..ce2d3c4 100644 --- a/include/linux/stop_machine.h +++ b/include/linux/stop_machine.h @@ -120,7 +120,7 @@ int stop_machine(int (*fn)(void *), void *data, const struct cpumask *cpus); * @cpus: the cpus to run the @fn() on (NULL = any online cpu) * * Description: This is a special version of the above, which assumes cpus - * won't come or go while it's being called. Used by hotplug cpu. + * won't come or go while it's being called. */ int __stop_machine(int (*fn)(void *), void *data, const struct cpumask *cpus); diff --git a/init/Kconfig b/init/Kconfig index be8b7f5..048a0c5 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -1711,7 +1711,7 @@ config INIT_ALL_POSSIBLE config STOP_MACHINE bool default y - depends on (SMP && MODULE_UNLOAD) || HOTPLUG_CPU + depends on (SMP && MODULE_UNLOAD) help Need stop_machine() primitive.
... and also cleanup a comment that refers to CPU hotplug being dependent on stop_machine(). Cc: David Howells <dhowells@redhat.com> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> --- include/linux/stop_machine.h | 2 +- init/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)