From patchwork Thu Jan 24 17:08:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Cartwright X-Patchwork-Id: 2033991 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 7F2423FD56 for ; Thu, 24 Jan 2013 17:09:56 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TyQH8-0005yd-Rr; Thu, 24 Jan 2013 17:07:42 +0000 Received: from mailserver5.natinst.com ([130.164.80.5] helo=spamkiller05.natinst.com) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TyQH5-0005x9-8X for linux-arm-kernel@lists.infradead.org; Thu, 24 Jan 2013 17:07:40 +0000 Received: from mailserv58-us.natinst.com (nb-hsrp-1338.natinst.com [130.164.19.133]) by spamkiller05.natinst.com (8.14.5/8.14.5) with ESMTP id r0OH7VkU009597; Thu, 24 Jan 2013 11:07:31 -0600 Received: from beefymiracle.amer.corp.natinst.com ([130.164.14.197]) by mailserv58-us.natinst.com (Lotus Domino Release 8.5.3FP2 HF169) with ESMTP id 2013012411073128-628450 ; Thu, 24 Jan 2013 11:07:31 -0600 Received: by beefymiracle.amer.corp.natinst.com (Postfix, from userid 1000) id 8E21B603F2; Thu, 24 Jan 2013 11:08:03 -0600 (CST) Date: Thu, 24 Jan 2013 11:08:03 -0600 From: Josh Cartwright To: Russell King - ARM Linux Subject: Re: OMAP4 randconfig failure: Zynq Message-ID: <20130124170803.GA1036@beefymiracle.amer.corp.natinst.com> References: <20130124111117.GU23505@n2100.arm.linux.org.uk> <20130124155704.GJ11970@beefymiracle.amer.corp.natinst.com> <20130124160609.GW23505@n2100.arm.linux.org.uk> <20130124161211.GX23505@n2100.arm.linux.org.uk> MIME-Version: 1.0 In-Reply-To: <20130124161211.GX23505@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.21 (2011-07-01) X-MIMETrack: Itemize by SMTP Server on MailServ58-US/AUS/H/NIC(Release 8.5.3FP2 HF169|September 14, 2012) at 01/24/2013 11:07:31 AM, Serialize by Router on MailServ58-US/AUS/H/NIC(Release 8.5.3FP2 HF169|September 14, 2012) at 01/24/2013 11:07:31 AM, Serialize complete at 01/24/2013 11:07:31 AM Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.9.8327, 1.0.431, 0.0.0000 definitions=2013-01-24_06:2013-01-24, 2013-01-24, 1970-01-01 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130124_120739_427876_8C134D6A X-CRM114-Status: GOOD ( 22.73 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: arm@kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Thu, Jan 24, 2013 at 04:12:11PM +0000, Russell King - ARM Linux wrote: > On Thu, Jan 24, 2013 at 04:06:09PM +0000, Russell King - ARM Linux wrote: > > On Thu, Jan 24, 2013 at 09:57:04AM -0600, Josh Cartwright wrote: > > > On Thu, Jan 24, 2013 at 11:11:17AM +0000, Russell King - ARM Linux wrote: > > > > The OMAP4 randconfig build last night failed with this error: > > > > > > > > arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init' undeclared here (not in a function) > > > > > > > > Full details at the usual place - > > > > http://www.arm.linux.org.uk/developer/build/ > > > > > > Curious. This doesn't look like a valid config to me. > > > > I think you're wrong. Yes, indeed. I was running my tests using the wrong tree. I can see this issue in today's linux-next. Sorry for the noise. [..] > > And what's missing is _specific_ to Zynq. Let's look at the error again: > > arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init' undeclared here (not in a function) > > What it means is that the "irqchip_init" identifier was not declared by > anything before it has been used. That means arch/arm/mach-zynq/common.c > is missing a required #include statement. > > irqchip_init can be found in linux/irqchip.h. Does arch/arm/mach-zynq/common.c > include this required include? No. Therefore, the build fails with the > above error. > > You need to add this include file... Agreed, thanks. Looks like this was introduced with "ARM: use common irqchip_init for GIC init". Here's a patch to fix it up, it probably makes sense to be pulled into Rob's irqchip/gic-vic-move branch. -- 8< -- Subject: [PATCH] ARM: zynq: include irqchip.h to prevent build failure Commit 0529e315bbda5d502c93df2cfafba9bb337fbdf4 ("ARM: use common irqchip_init for GIC init") converts Zynq to make use of irqchip_init, but fails to include linux/irqchip.h. Fixes this build error: arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init' undeclared here (not in a function) Reported-by: Russell King Cc: Rob Herring Signed-off-by: Josh Cartwright --- arch/arm/mach-zynq/common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c index 8513b16..8a0b8ab 100644 --- a/arch/arm/mach-zynq/common.c +++ b/arch/arm/mach-zynq/common.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include #include