From patchwork Thu Jan 24 19:15:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Turquette X-Patchwork-Id: 2034621 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 0F88BDF264 for ; Thu, 24 Jan 2013 19:18:33 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TySH3-00078R-3Z; Thu, 24 Jan 2013 19:15:45 +0000 Received: from mail-pa0-f54.google.com ([209.85.220.54]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TySH0-000786-2g for linux-arm-kernel@lists.infradead.org; Thu, 24 Jan 2013 19:15:42 +0000 Received: by mail-pa0-f54.google.com with SMTP id bi5so5670550pad.13 for ; Thu, 24 Jan 2013 11:15:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:content-type:mime-version:content-transfer-encoding:to :from:in-reply-to:cc:references:message-id:user-agent:subject:date :x-gm-message-state; bh=kz0DhXX5Uzl3asltsIHArTxCnZ+7OIs9ywCIpUMV2AY=; b=cBZd3daIHTgLofJt8ALpUz+rXJrJoxPgQuMOo6tZyDBokW10yBVIuWWzA4YGhfR4Gx IFW06KpJyMJx6jXhqC9IQX9POf4OC0aMEOptvGLsow7r5uDCudVDQqfSahgrdoayiRzL lRj1zKkUT1nSc5YlN0/1j3IyGLRTTu68N8IXgMJ8C5URg3zfR/sDwBeiepAPxHoC2joH a5bW+74vzrcSeQOMJTMFC7pXBm56bwCpMEAEaRt6ds7NIwKNYUNpyJMv8huevCVHz/hy zEJoS3xLkHzY82vmxcflXDW1q13golzNlB5rXDpHXj/K0IusxHUNRUfhwWBBOYscXA83 i0cw== X-Received: by 10.68.235.1 with SMTP id ui1mr7670595pbc.138.1359054940297; Thu, 24 Jan 2013 11:15:40 -0800 (PST) Received: from localhost (adsl-69-228-81-205.dsl.pltn13.pacbell.net. [69.228.81.205]) by mx.google.com with ESMTPS id nt5sm15342908pbb.59.2013.01.24.11.15.37 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 24 Jan 2013 11:15:38 -0800 (PST) MIME-Version: 1.0 To: Tony Prisk , From: Mike Turquette In-Reply-To: <1358543280.8280.2.camel@gitbox> References: <1357282858-2112-1-git-send-email-pgaikwad@nvidia.com> <1357282858-2112-5-git-send-email-pgaikwad@nvidia.com> <20130118175621.3982.82838@quantum> <1358543280.8280.2.camel@gitbox> Message-ID: <20130124191534.10623.14882@quantum> User-Agent: alot/0.3.3+ Subject: Re: [PATCH 5/7] clk: vt8500: Use common of_clk_init() function Date: Thu, 24 Jan 2013 11:15:34 -0800 X-Gm-Message-State: ALoCoQm0f704n4gefsQzraoIXm9gucdXrooOKjU3cDxc2BrCdlx7CIZ2tcY3Ms/4QlvTlu1N9/t1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130124_141542_191305_5714FB18 X-CRM114-Status: GOOD ( 16.44 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.54 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: josh.cartwright@ni.com, Prashant Gaikwad , swarren@nvidia.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, rob.herring@calxeda.com, grant.likely@secretlab.ca, maxime.ripard@free-electrons.com, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Quoting Tony Prisk (2013-01-18 13:08:00) > On Fri, 2013-01-18 at 09:56 -0800, Mike Turquette wrote: > > Quoting Prashant Gaikwad (2013-01-03 23:00:56) > > > Use common of_clk_init() function for clock initialization. > > > > > > Signed-off-by: Prashant Gaikwad > > > > Tony, > > > > Can I get a Tested-by from you before I take this in? > > > Tested-by: Tony Prisk > > FYI: This will need another patch to complete as we added another set of > clocks to this clk-vt8500.c for 3.9. > Tony, is the following patch correct? From 5b6e0adb69674c684c33503f50010644b049029c Mon Sep 17 00:00:00 2001 From: Prashant Gaikwad Date: Fri, 4 Jan 2013 12:30:56 +0530 Subject: [PATCH] clk: vt8500: Use common of_clk_init() function Use common of_clk_init() function for clock initialization. Signed-off-by: Prashant Gaikwad Tested-by: Tony Prisk Signed-off-by: Mike Turquette [mturquette@linaro.org: added entry for wm8750-pll-clock] Signed-off-by: Mike Turquette Tested-by: Tony Prisk Acked-by: Tony Prisk --- drivers/clk/clk-vt8500.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c index 2515d4f..b5538bb 100644 --- a/drivers/clk/clk-vt8500.c +++ b/drivers/clk/clk-vt8500.c @@ -291,7 +291,7 @@ static __init void vtwm_device_clk_init(struct device_node *node) rc = of_clk_add_provider(node, of_clk_src_simple_get, clk); clk_register_clkdev(clk, clk_name, NULL); } - +CLK_OF_DECLARE(vt8500_device, "via,vt8500-device-clock", vtwm_device_clk_init); /* PLL clock related functions */ @@ -612,26 +612,19 @@ static void __init vt8500_pll_init(struct device_node *node) { vtwm_pll_clk_init(node, PLL_TYPE_VT8500); } +CLK_OF_DECLARE(vt8500_pll, "via,vt8500-pll-clock", vt8500_pll_init); static void __init wm8650_pll_init(struct device_node *node) { vtwm_pll_clk_init(node, PLL_TYPE_WM8650); } +CLK_OF_DECLARE(wm8650_pll, "wm,wm8650-pll-clock", wm8650_pll_init); static void __init wm8750_pll_init(struct device_node *node) { vtwm_pll_clk_init(node, PLL_TYPE_WM8750); } - -static const __initconst struct of_device_id clk_match[] = { - { .compatible = "fixed-clock", .data = of_fixed_clk_setup, }, - { .compatible = "via,vt8500-pll-clock", .data = vt8500_pll_init, }, - { .compatible = "wm,wm8650-pll-clock", .data = wm8650_pll_init, }, - { .compatible = "wm,wm8750-pll-clock", .data = wm8750_pll_init, }, - { .compatible = "via,vt8500-device-clock", - .data = vtwm_device_clk_init, }, - { /* sentinel */ } -}; +CLK_OF_DECLARE(wm8750_pll, "wm,wm8750-pll-clock", wm8750_pll_init); void __init vtwm_clk_init(void __iomem *base) { @@ -640,5 +633,5 @@ void __init vtwm_clk_init(void __iomem *base) pmc_base = base; - of_clk_init(clk_match); + of_clk_init(NULL); }