From patchwork Sun Feb 10 03:22:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 2121331 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 291F33FC23 for ; Sun, 10 Feb 2013 03:25:34 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1U4NV8-0005Vy-0d; Sun, 10 Feb 2013 03:22:46 +0000 Received: from mho-03-ewr.mailhop.org ([204.13.248.66] helo=mho-01-ewr.mailhop.org) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U4NV4-0005Vf-Fc for linux-arm-kernel@lists.infradead.org; Sun, 10 Feb 2013 03:22:43 +0000 Received: from c-50-131-214-131.hsd1.ca.comcast.net ([50.131.214.131] helo=localhost.localdomain) by mho-01-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1U4NV0-0008PF-PX; Sun, 10 Feb 2013 03:22:39 +0000 Received: from Mutt by mutt-smtp-wrapper.pl 1.2 (www.zdo.com/articles/mutt-smtp-wrapper.shtml) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.131.214.131 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18ZcktRhWCwtzGzEUJkdb33 Date: Sat, 9 Feb 2013 19:22:34 -0800 From: Tony Lindgren To: Olof Johansson Subject: Re: Latest additional build warnings Message-ID: <20130210032234.GE4801@atomide.com> References: <20130205142218.GB17833@n2100.arm.linux.org.uk> <20130209114918.GJ17852@n2100.arm.linux.org.uk> <20130210030032.GC4801@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130209_222242_797603_EF45DA86 X-CRM114-Status: GOOD ( 18.91 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [204.13.248.66 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines Cc: linux-omap@vger.kernel.org, Russell King - ARM Linux , arm@kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org * Olof Johansson [130209 19:08]: > On Sat, Feb 9, 2013 at 7:00 PM, Tony Lindgren wrote: > > * Russell King - ARM Linux [130209 03:53]: > >> On Tue, Feb 05, 2013 at 02:22:18PM +0000, Russell King - ARM Linux wrote: > >> > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or storage class > >> > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: type defaults to 'int' in declaration of 'omap_postcore_initcall' > >> > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: parameter names (without types) in function declaration > >> > arch/arm/mach-omap2/hwspinlock.c:31:122: warning: 'hwspinlocks_init' defined but not used > >> > >> I'm still seeing the above in the build of Friday's merge. I'm also > >> seeing additional warnings in the randconfig similar to the above for > >> arch/arm/mach-omap2/omap-iommu.c. > > > > Thanks for letting me know about the omap-iommu.c one. Looks like > > there's also one patch for drm.c. > > > > Olof, if you did not yet apply the hwspinlock.c warning fix, I'll > > just do a branch with all three of them for you. > > I haven't (must have missed it), so please just send a branch. OK will do. Probably you started fixing up the bad Reported-by line in my patch and then got disrupted :) Found one more after some grepping, after the following patch they should be all fixed up. Pull request coming shortly. Tony From: Tony Lindgren Date: Sat, 9 Feb 2013 19:20:57 -0800 Subject: [PATCH] ARCH: OMAP2+: Make sure files with omap initcalls include soc.h Looks like there are few more places that I missed that can cause compiler warnings. After grepping for omap initcall, all files needing soc.h should now have it. Reported-by: Russell King Signed-off-by: Tony Lindgren --- a/arch/arm/mach-omap2/omap-iommu.c +++ b/arch/arm/mach-omap2/omap-iommu.c @@ -16,6 +16,7 @@ #include #include +#include "soc.h" #include "omap_hwmod.h" #include "omap_device.h" --- a/arch/arm/mach-omap2/smartreflex-class3.c +++ b/arch/arm/mach-omap2/smartreflex-class3.c @@ -12,6 +12,7 @@ */ #include +#include "soc.h" #include "voltage.h" static int sr_class3_enable(struct omap_sr *sr)