From patchwork Fri Feb 15 20:11:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Turquette X-Patchwork-Id: 2149881 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 8AD2C3FCF6 for ; Fri, 15 Feb 2013 20:14:26 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1U6Rd6-0002AX-6c; Fri, 15 Feb 2013 20:11:32 +0000 Received: from mail-da0-f50.google.com ([209.85.210.50]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U6Rd2-0002AD-Hb for linux-arm-kernel@lists.infradead.org; Fri, 15 Feb 2013 20:11:29 +0000 Received: by mail-da0-f50.google.com with SMTP id h15so1571331dan.37 for ; Fri, 15 Feb 2013 12:11:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:content-type:mime-version:content-transfer-encoding:to :from:in-reply-to:cc:references:message-id:user-agent:subject:date :x-gm-message-state; bh=q8uOmtOYHqT4p7x4HVfrG8IFTkTGyuoLMYNjt4DaIog=; b=fHGPTgYsqLnst5YqrczK7jYpUor/nF513tdNYsjmkV/G0IW3oMSUKqyIwDulfFw8zY 1iJZnDdu1DMYpWXLwVRAArLVpdRjh+Z26KLUcARXDatHXSACtMvpwKVKeIfj+Ndyv0c/ UskACPawVtPekcCyHUm2po4NYX1hrvaJ1GlAjo7VaggJdjrqmSCULJxvvxohwjXeLpFO iQnKHXWPHWlUazo2NURwdQn5fOQr7GC0LWGovF37rQiLZScgNql0+fSoUBv5nw08DhAh Q14Q5F7GzltsNhoaT58I+11iomlqKOw03cH7krxWe/naGCRagyaZANparbuXpVzH0IAU scSQ== X-Received: by 10.68.232.69 with SMTP id tm5mr8719520pbc.150.1360959086835; Fri, 15 Feb 2013 12:11:26 -0800 (PST) Received: from localhost (adsl-69-228-95-101.dsl.pltn13.pacbell.net. [69.228.95.101]) by mx.google.com with ESMTPS id ri1sm5649204pbc.16.2013.02.15.12.11.24 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 15 Feb 2013 12:11:25 -0800 (PST) MIME-Version: 1.0 To: Arnd Bergmann , Rob Herring , Matt Porter From: Mike Turquette In-Reply-To: <201302151800.36948.arnd@arndb.de> References: <511E6FA4.2000709@gmail.com> <201302151800.36948.arnd@arndb.de> Message-ID: <20130215201121.11471.66349@quantum> User-Agent: alot/0.3.3+ Subject: Re: randconfig errors Date: Fri, 15 Feb 2013 12:11:21 -0800 X-Gm-Message-State: ALoCoQlgtY1c/oqqPQfEeoBglghxEdtgZF4iZAp183R2wRZB2WudjAIvkFvN/KxtvACG+982l94Q X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130215_151128_672165_A6F6D6EC X-CRM114-Status: GOOD ( 14.94 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.210.50 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Quoting Arnd Bergmann (2013-02-15 10:00:36) > On Friday 15 February 2013, Rob Herring wrote: > > /var/lib/jenkins/jobs/linux-randconfig/workspace/drivers/clk/clk-vt8500.c:160:24: error: 'prate' undeclared (first use in this function) > > I've seen this one with allyesconfig but have not tried to make a fix Looks like this one was introduced by 7248001, "clk: vt8500: Fix device clock divisor calculations". Looks like a copy/paste error where prate was used instead of parent_rate. Tony can you test the below patch? Regards, Mike From efb8dbe114579b4f459b3810e83d79b11593436a Mon Sep 17 00:00:00 2001 From: Mike Turquette Date: Fri, 15 Feb 2013 12:03:51 -0800 Subject: [PATCH] clk: vt8500: copy-paste mistake in dclk_set_rate Commit 7248001, "clk: vt8500: Fix device clock divisor calculations" introduced logic to improve divider selection while changing rates for the VT8500 dclk. However a copy-paste error results in using the wrong variable name in the .set_rate callback. Fixed by changing *prate to parent_rate. The .round_rate function is correct and remains unchanged. Signed-off-by: Mike Turquette Cc: Tony Prisk Cc: Arnd Bergmann Cc: Rob Herring --- drivers/clk/clk-vt8500.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c index b5538bb..c010861 100644 --- a/drivers/clk/clk-vt8500.c +++ b/drivers/clk/clk-vt8500.c @@ -156,8 +156,8 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate, divisor = parent_rate / rate; - /* If prate / rate would be decimal, incr the divisor */ - if (rate * divisor < *prate) + /* If parent_rate / rate would be decimal, incr the divisor */ + if (rate * divisor < parent_rate) divisor++; if (divisor == cdev->div_mask + 1)